Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit a3d2316

Browse files
committed
Ignore target: "es6" following the README instructions
1 parent 91c7136 commit a3d2316

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/_tests/fixtures/49841/derived.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
},
2626
{
2727
"path": "types/react-native-sha1/tsconfig.json",
28-
"kind": "package-meta",
29-
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`)"
28+
"kind": "package-meta-ok"
3029
},
3130
{
3231
"path": "types/react-native-sha1/tslint.json",

src/_tests/fixtures/49841/mutations.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"variables": {
55
"input": {
66
"subjectId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5",
7-
"body": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) — [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n - Config files to check:\n - [`react-native-sha1/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files/4849e8876b0ab7adc889ccc35b55fde6f0274837#diff-579fae17725faf40efb4aac22d7bcfb2337ec7080258e4a206f5a479968d3556): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49841&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
7+
"body": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) — [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49841&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
88
}
99
}
1010
},
@@ -14,8 +14,7 @@
1414
"input": {
1515
"labelIds": [
1616
"MDU6TGFiZWwyMDk2NzQzNjAw",
17-
"MDU6TGFiZWw2NDY3ODg4ODg=",
18-
"MDU6TGFiZWwyMTU0ODE2NTQ5"
17+
"MDU6TGFiZWw2NDY3ODg4ODg="
1918
],
2019
"labelableId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5"
2120
}

src/_tests/fixtures/49841/result.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@
22
"projectColumn": "Needs Author Action",
33
"labels": [
44
"The CI failed",
5-
"New Definition",
6-
"Check Config"
5+
"New Definition"
76
],
87
"responseComments": [
98
{
109
"tag": "welcome",
11-
"status": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) — [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n - Config files to check:\n - [`react-native-sha1/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files/4849e8876b0ab7adc889ccc35b55fde6f0274837#diff-579fae17725faf40efb4aac22d7bcfb2337ec7080258e4a206f5a479968d3556): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49841&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
10+
"status": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) — [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=49841&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1211
},
1312
{
1413
"tag": "pinging-reviewers-others",

src/pr-info.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,9 @@ configSuspicious["tsconfig.json"] = makeChecker(
370370
data.compilerOptions.lib = data.compilerOptions.lib.filter((value: unknown) =>
371371
!(typeof value === "string" && value.toLowerCase() === "dom"));
372372
["baseUrl", "typeRoots", "paths", "jsx"].forEach(k => delete data.compilerOptions[k]);
373+
if (typeof data.compilerOptions?.target === "string" && data.compilerOptions.target.toLowerCase() === "es6") {
374+
delete data.compilerOptions.target;
375+
}
373376
delete data.files;
374377
} }
375378
);

0 commit comments

Comments
 (0)