Simplify

Author: andrewbranch

src/_tests/fixtures/58764/mutations.json

@@ -8,6 +8,17 @@
       }
     }
   },
+  {
+    "mutation": "mutation ($input: RemoveLabelsFromLabelableInput!) {\n  removeLabelsFromLabelable(input: $input) {\n    __typename\n  }\n}\n",
+    "variables": {
+      "input": {
+        "labelIds": [
+          "MDU6TGFiZWwyMDk2NzQ1NzQx"
+        ],
+        "labelableId": "PR_kwDOAFz6BM4yvxmj"
+      }
+    }
+  },
   {
     "mutation": "mutation ($input: MoveProjectCardInput!) {\n  moveProjectCard(input: $input) {\n    __typename\n  }\n}\n",
     "variables": {

src/_tests/fixtures/58764/result.json

@@ -4,8 +4,7 @@
     "Critical package",
     "Edits Owners",
     "Edits multiple packages",
-    "Untested Change",
-    "Where is GH Actions?"
+    "Untested Change"
   ],
   "responseComments": [
     {

src/comments.ts

@@ -151,7 +151,6 @@ export const StalenessExplanations: { [k: string]: string } = {
 
 // Comments to post for the staleness timeline (the tag is computed in `makeStaleness`)
 export const StalenessComment = (author: string, ownersToPing: string[], expires: string) => {
-    if (author === "github-actions") return {};
     const ownerPing = ownersToPing.map(o => "@"+o).join(", ");
     return {
         // --Unmerged--

src/compute-pr-actions.ts

@@ -274,6 +274,10 @@ export function process(prInfo: BotResult,
     }
 
     // Some step should override actions.projectColumn, the default "Other" indicates a problem
+    if (info.author === "github-actions") {
+        actions.projectColumn = "Needs Maintainer Action";
+        return actions;
+    }
 
     // First-timers are blocked from CI runs until approved, this case is for infra edits (require a maintainer)
     if (info.ciResult === "action_required") {
@@ -335,15 +339,11 @@ export function process(prInfo: BotResult,
     // Has it: got no DT tests but is approved by DT modules and basically blocked by the DT maintainers - and it has been over 3 days?
     // Send a message reminding them that they can un-block themselves by adding tests.
     if (!info.hasTests && !info.hasMultiplePackages && info.approvedBy.includes("owner") && !info.editsInfra
-        && info.approverKind === "maintainer" && (info.staleness?.days ?? 0) > 3 && info.author !== "github-actions") {
+        && info.approverKind === "maintainer" && (info.staleness?.days ?? 0) > 3) {
         post(Comments.RemindPeopleTheyCanUnblockPR(info.author, info.approvedReviews.map(r => r.reviewer),
                                                    info.ciResult === "pass", headCommitAbbrOid));
     }
 
-    if (info.author === "github-actions") {
-        actions.projectColumn = "Needs Maintainer Action";
-    }
-
     // Timeline-related actions
     info.staleness?.doTimelineActions(actions);