Revise staleness timelines and timeline handling

* `staleness` is now an optional object with fields for the
  `state` (fresh / attention / nearly / done) `kind` (which is also the
  label that will be applied when the timeline is done), and `days` for
  the count (replacing `stalenessInDays`).  It's `undefined` when we're
  not on any of the timelines.

* Shuffle the code so staleness handling is used in the same place
  regardless of other state.  Note that it's done regardless of other
  actions which leads to some changes test in tests, but in practice it
  shouldn't be a problem (unless the bot dies for many days).

* The `Staleness` generation becomes the place for configuring staleness
  timelines, together with mappings in `comments.ts` for the explanation
  and comments of various states.

* Added the `Unreviewed` kind --- changed the 44857 test to use it
  instead of `Abandoned`.

* Staleness also has a `doTimelineActions` which is now the central
  place for doing all timeline-related actions.

* Change: the stalness comment tags are computed (in `makeStaleness`),
  they depend on the state:
  - `nearly`: a tag that includes the date that the countdown started
    at, so these comments can be repeated if there's a timeline change
    that voided the previous staleness, but a new one triggered.
  - `done`: no date in the tag, since these comments are terminal.

* Change: `YSYL` is renamed to `Unmerged`.

* Change: put the `Unmerged`/`Abandoned`/`Unreviewd` label when reaching
  `nearly` state, so it is useful to find PRs that are approaching their
  terminal (`done`) state.

* Revise the timelines, with some minor changes, and update all comments
  accordingly.  Notable changes from #208:
  - The waits are slightly different, but roughly the same.
  - "Becoming mergable" is measured from the merge offer comment when
    found.
  - The unreviewed timeline counts days from the last update rather than
    from the creation time.  This because I see a lot of PR's that have
    a few days of work following their creation.  It could be confusing
    if the count starts at creation, since some of these PRs would seem
    to be announced unreviewed very quickly.

* Update `docs/how-it-works.md`.

Closes #208
Closes #207
Closes #204

Author: elibarzilay

docs/how-it-works.md

@@ -1,4 +1,4 @@
-_Disclaimer: This could be out of date, the source of truth is always [compute-pr-actions.ts](https://github.com/DefinitelyTyped/dt-mergebot/blob/master/src/compute-pr-actions.ts)_
+_Disclaimer: This could be out of date, the source of truth is always [compute-pr-actions]_
 
 <img src="./dt-mergebot-lifecycle.png" />
 <!-- https://www.figma.com/file/qE7BDiEucqI55Q9u0yZO3b/dt-pr-lifecycle?node-id=6%3A7 -->
@@ -21,26 +21,34 @@ _Disclaimer: This could be out of date, the source of truth is always [compute-p
 PRs that are blessed (see `info.maintainerBlessed`) are excluded when
 possible.
 
-### Idle PR Removal
+### Stale PRs
 
-When a PR:
+There are several categories for PRs getting stale: "Unmerged" (good to go, but
+author+owners didn't request to merge them), "Abandoned" (bad CI, change
+requests), "Unreviewed" (got no reviews).  Each of these starts a day countdown
+at a configurable point, and goes through several states at configurable day
+counts:
 
-- Has merge conflicts, CI is failing or has Reviews which reject the most recent commit
-- Has not had any commits/comments/reviews/review comments in the last three weeks
+- `fresh`: just entered the corresponding staleness timeline, nothing done.
+- `attention`: the inactivity is now shown on the welcome message with a brief
+  explanation.
+- `nearly`: a comment is posted and a label with the staleness category is
+  added.
+- `done`: the timeline is done, either move the PR to a column (unreviewed) or
+  close it (the other).
 
-it will get a ping that it has about a week for something to happen.
+See the `getStaleness` definition in [compute-pr-actions] for the current
+configuration (conditions, count start, day counts, and final action).
 
-Then, assuming no new activities, a PR which:
+The explanations for `attention` and the posted comments are defined in
+`StalenessExplanations` and `StalenessComment` respectively (in [comments]).
 
-- Has merge conflicts, CI is failing or has Reviews which reject the most recent commit
-- Has not had any commits/comments/reviews/review comments in the last 30 days
-
-will be closed.
+### Cleanup
 
-For PRs that are ready to merge but were not, there is a similar (but
-much shorter) progression: pinged after 4 days, and moved to YSYL state
-after 8.
+A [daily script](../src/scripts/daily.ts) is running every night, cutting the
+`Recently Merged` column to 50.  It also removes closed PRs from other columns
+as a safeguard in case the bot missed a PR closing event.
 
-### Cleanup
 
-A [daily script](../src/scripts/daily.ts) is running every night, cutting the `Recently Merged` column to 50.  It also removes closed PRs from other columns as a safeguard in case the bot missed a PR closing event.
+[compute-pr-actions]: <https://github.com/DefinitelyTyped/dt-mergebot/blob/master/src/compute-pr-actions.ts>
+[comments]: <https://github.com/DefinitelyTyped/dt-mergebot/blob/master/src/comments.ts>

src/_tests/cachedQueries.json

@@ -163,6 +163,11 @@
       "name": "Mergebot Error",
       "__typename": "Label"
     },
+    {
+      "id": "MDU6TGFiZWwyNTI5Mjc2Njc2",
+      "name": "Multiple Languages",
+      "__typename": "Label"
+    },
     {
       "id": "MDU6TGFiZWw2NDY3ODg4ODg=",
       "name": "New Definition",
@@ -253,6 +258,11 @@
       "name": "Unmergeable",
       "__typename": "Label"
     },
+    {
+      "id": "MDU6TGFiZWw2NDQwOTU4ODI=",
+      "name": "Unmerged",
+      "__typename": "Label"
+    },
     {
       "id": "MDU6TGFiZWw2NDY3ODkyMDU=",
       "name": "Unowned",
@@ -272,11 +282,6 @@
       "id": "MDU6TGFiZWwyMDk2NzQ1NzQx",
       "name": "Where is GH Actions?",
       "__typename": "Label"
-    },
-    {
-      "id": "MDU6TGFiZWw2NDQwOTU4ODI=",
-      "name": "YSYL",
-      "__typename": "Label"
     }
   ]
 }

src/_tests/fixtures/38979/mutations.json

@@ -4,7 +4,8 @@
     "variables": {
       "input": {
         "labelIds": [
-          "MDU6TGFiZWwxNjA4NjM0NDg0"
+          "MDU6TGFiZWwxNjA4NjM0NDg0",
+          "MDU6TGFiZWwyNDYyODA0MzE1"
         ],
         "labelableId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0"
       }
@@ -26,7 +27,7 @@
     "variables": {
       "input": {
         "contentId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0",
-        "projectColumnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTIy"
+        "projectColumnId": "MDEzOlByb2plY3RDb2x1bW45ODY3MDA2"
       }
     }
   },
@@ -35,7 +36,7 @@
     "variables": {
       "input": {
         "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==",
-        "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n   - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n   - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
+        "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n   - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n   - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
       }
     }
   },
@@ -56,5 +57,14 @@
         "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-764528-0e6e7f4-->"
       }
     }
+  },
+  {
+    "query": "mutation($input: AddCommentInput!) { addComment(input: $input) { clientMutationId } }",
+    "variables": {
+      "input": {
+        "subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0",
+        "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)\n<!--typescript_bot_Unreviewed:done-->"
+      }
+    }
   }
 ]

src/_tests/fixtures/38979/result.json

@@ -1,15 +1,16 @@
 {
   "pr_number": 38979,
-  "targetColumn": "Needs Maintainer Review",
+  "targetColumn": "Needs Maintainer Action",
   "labels": [
     "Critical package",
     "Other Approved",
-    "Config Edit"
+    "Config Edit",
+    "Unreviewed"
   ],
   "responseComments": [
     {
       "tag": "welcome",
-      "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n   - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n   - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
+      "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n   - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n   - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..."
     },
     {
       "tag": "pinging-reviewers",
@@ -18,6 +19,10 @@
     {
       "tag": "stale-ping-764528-0e6e7f4",
       "status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
+    },
+    {
+      "tag": "Unreviewed:done",
+      "status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)"
     }
   ],
   "shouldClose": false,

src/_tests/fixtures/43144/mutations.json

@@ -24,7 +24,7 @@
     "variables": {
       "input": {
         "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4NDkxOTI2",
-        "body": "@jeffreymeng Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mailcheck` [on npm](https://www.npmjs.com/package/mailcheck), [on unpkg](https://unpkg.com/browse/mailcheck@latest/)\n  - owner-approval: @pocesar\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n## Inactive\n\nThis PR has been inactive for 4 days.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
+        "body": "@jeffreymeng Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mailcheck` [on npm](https://www.npmjs.com/package/mailcheck), [on unpkg](https://unpkg.com/browse/mailcheck@latest/)\n  - owner-approval: @pocesar\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
       }
     }
   },

src/_tests/fixtures/43144/result.json

@@ -8,7 +8,7 @@
   "responseComments": [
     {
       "tag": "welcome",
-      "status": "@jeffreymeng Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mailcheck` [on npm](https://www.npmjs.com/package/mailcheck), [on unpkg](https://unpkg.com/browse/mailcheck@latest/)\n  - owner-approval: @pocesar\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n## Inactive\n\nThis PR has been inactive for 4 days.\n\n----------------------\n... diagnostics scrubbed ..."
+      "status": "@jeffreymeng Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `mailcheck` [on npm](https://www.npmjs.com/package/mailcheck), [on unpkg](https://unpkg.com/browse/mailcheck@latest/)\n  - owner-approval: @pocesar\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..."
     },
     {
       "tag": "merge-offer",

src/_tests/fixtures/43695-duplicate-comment/mutations.json

@@ -1,4 +1,15 @@
 [
+  {
+    "query": "mutation($input: AddLabelsToLabelableInput!) { addLabelsToLabelable(input: $input) { clientMutationId } }",
+    "variables": {
+      "input": {
+        "labelIds": [
+          "MDU6TGFiZWwyNDYyODA0MzE1"
+        ],
+        "labelableId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2"
+      }
+    }
+  },
   {
     "query": "mutation($input: RemoveLabelsFromLabelableInput!) { removeLabelsFromLabelable(input: $input) { clientMutationId } }",
     "variables": {
@@ -25,7 +36,7 @@
     "variables": {
       "input": {
         "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==",
-        "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n  - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
+        "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n  - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
       }
     }
   },
@@ -46,5 +57,14 @@
         "body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n<!--typescript_bot_stale-ping-61f252-a5285cd-->"
       }
     }
+  },
+  {
+    "query": "mutation($input: AddCommentInput!) { addComment(input: $input) { clientMutationId } }",
+    "variables": {
+      "input": {
+        "subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2",
+        "body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @alexandercerutti.\n\n(Ping «anyone?».)\n<!--typescript_bot_Unreviewed:done-->"
+      }
+    }
   }
 ]