Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit f9c7057

Browse files
jablkojablko
committed
Add tests
1 parent f654aac commit f9c7057

File tree

6 files changed

+640
-0
lines changed

6 files changed

+640
-0
lines changed

‎src/_tests/fixtures/49639/_downloads.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"jasmine": 7855902
3+
}

‎src/_tests/fixtures/49639/_files.json

Lines changed: 6 additions & 0 deletions
Large diffs are not rendered by default.

‎src/_tests/fixtures/49639/_response.json

Lines changed: 463 additions & 0 deletions
Large diffs are not rendered by default.

‎src/_tests/fixtures/49639/derived.json

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
{
2+
"type": "info",
3+
"now": "2020-11-26T15:09:52.097Z",
4+
"pr_number": 49639,
5+
"author": "ienzam",
6+
"headCommitAbbrOid": "c5e5c98",
7+
"headCommitOid": "c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856",
8+
"lastPushDate": "2020-11-17T22:12:35.000Z",
9+
"lastActivityDate": "2020-11-19T16:12:15.000Z",
10+
"maintainerBlessed": false,
11+
"hasMergeConflict": false,
12+
"isFirstContribution": false,
13+
"popularityLevel": "Critical",
14+
"pkgInfo": [
15+
{
16+
"name": "jasmine",
17+
"kind": "edit",
18+
"files": [
19+
{
20+
"path": "types/jasmine/index.d.ts",
21+
"kind": "definition"
22+
},
23+
{
24+
"path": "types/jasmine/tslint.json",
25+
"kind": "package-meta",
26+
"suspect": "not the required form and not moving towards it",
27+
"suggestion": {
28+
"startLine": 4,
29+
"line": 4,
30+
"suggestion": ""
31+
}
32+
}
33+
],
34+
"owners": [
35+
"borisyankov",
36+
"theodorejb",
37+
"davidparsson",
38+
"gmoothart",
39+
"lukas-zech-software",
40+
"Engineer2B",
41+
"cyungmann",
42+
"Roaders",
43+
"devoto13",
44+
"fdim",
45+
"kolodny",
46+
"stephenfarrar",
47+
"zvirja",
48+
"djungowski",
49+
"chivesrs",
50+
"kirjs",
51+
"ienzam"
52+
],
53+
"addedOwners": [],
54+
"deletedOwners": [],
55+
"popularityLevel": "Critical"
56+
}
57+
],
58+
"reviews": [
59+
{
60+
"type": "approved",
61+
"reviewer": "sandersn",
62+
"date": "2020-11-19T16:12:15.000Z",
63+
"isMaintainer": false
64+
},
65+
{
66+
"type": "approved",
67+
"reviewer": "chivesrs",
68+
"date": "2020-11-18T01:47:38.000Z",
69+
"isMaintainer": false
70+
}
71+
],
72+
"ciResult": "pass"
73+
}

‎src/_tests/fixtures/49639/mutations.json

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
[
2+
{
3+
"query": "mutation($input: AddLabelsToLabelableInput!) { addLabelsToLabelable(input: $input) { clientMutationId } }",
4+
"variables": {
5+
"input": {
6+
"labelIds": [
7+
"MDU6TGFiZWw1ODYxNzcwNjM="
8+
],
9+
"labelableId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx"
10+
}
11+
}
12+
},
13+
{
14+
"query": "mutation($input: RemoveLabelsFromLabelableInput!) { removeLabelsFromLabelable(input: $input) { clientMutationId } }",
15+
"variables": {
16+
"input": {
17+
"labelIds": [
18+
"MDU6TGFiZWwxNjA4NTUyNDEw",
19+
"MDU6TGFiZWw2OTcwMTg5NzI="
20+
],
21+
"labelableId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx"
22+
}
23+
}
24+
},
25+
{
26+
"query": "mutation($input: AddProjectCardInput!) { addProjectCard(input: $input) { clientMutationId } }",
27+
"variables": {
28+
"input": {
29+
"contentId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx",
30+
"projectColumnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTIy"
31+
}
32+
}
33+
},
34+
{
35+
"query": "mutation($input: UpdateIssueCommentInput!) { updateIssueComment(input: $input) { clientMutationId } }",
36+
"variables": {
37+
"input": {
38+
"id": "MDEyOklzc3VlQ29tbWVudDcyOTI0NjE3Mw==",
39+
"body": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package) to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856/types/jasmine/tslint.json): not the required form and not moving towards it\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
40+
}
41+
}
42+
},
43+
{
44+
"query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }",
45+
"variables": {
46+
"input": {
47+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx",
48+
"path": "types/jasmine/tslint.json",
49+
"line": 4,
50+
"body": "```suggestion\n"
51+
}
52+
}
53+
},
54+
{
55+
"query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }",
56+
"variables": {
57+
"input": {
58+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0NTIyNzM5MjUx",
59+
"body": "@ienzam I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed (unless it's obvious) and a maintainer will take a look. Thanks!\n<!--typescript_bot_suggestions-->",
60+
"event": "COMMENT"
61+
}
62+
}
63+
}
64+
]

‎src/_tests/fixtures/49639/result.json

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
{
2+
"pr_number": 49639,
3+
"targetColumn": "Needs Maintainer Review",
4+
"labels": [
5+
"Critical package",
6+
"Other Approved",
7+
"Owner Approved",
8+
"Author is Owner",
9+
"Config Edit",
10+
"Untested Change"
11+
],
12+
"responseComments": [
13+
{
14+
"tag": "welcome",
15+
"status": "@ienzam Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package) to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n\n## 1 package in this PR\n\n* `jasmine` [on npm](https://www.npmjs.com/package/jasmine), [on unpkg](https://unpkg.com/browse/jasmine@latest/) (author is owner)\n - owner-approval: @chivesrs\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jasmine/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c5e5c9885d23e7d1c1ea8f54b53c8283d5f4f856/types/jasmine/tslint.json): not the required form and not moving towards it\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
16+
}
17+
],
18+
"suggestions": {
19+
"types/jasmine/tslint.json": {
20+
"startLine": 4,
21+
"line": 4,
22+
"suggestion": ""
23+
}
24+
},
25+
"shouldClose": false,
26+
"shouldMerge": false,
27+
"shouldUpdateLabels": true,
28+
"shouldUpdateProjectColumn": true,
29+
"shouldRemoveFromActiveColumns": false,
30+
"isReadyForAutoMerge": false
31+
}

0 commit comments

Comments
 (0)