Merge pull request #431 from DefinitelyTyped/update-tslint-extends

Update tslint "extends" requirement

Author: sandersn

src/_tests/fixtures/44299-with-files/_files.json

@@ -1,4 +1,4 @@
 {
-  "683fb3b1298223256be3a49823686f35bd94a730:types/hcaptcha__vue-hcaptcha/tslint.json": "{\n  \"extends\": \"dtslint/dt.json\"\n}\n",
+  "683fb3b1298223256be3a49823686f35bd94a730:types/hcaptcha__vue-hcaptcha/tslint.json": "{\n  \"extends\": \"@definitelytyped/dtslint/dt.json\"\n}\n",
   "683fb3b1298223256be3a49823686f35bd94a730:types/hcaptcha__vue-hcaptcha/index.d.ts": "// Type definitions for @hcaptcha/vue-hcaptcha 0.2\n// Project: https://github.com/hCaptcha/vue-hcaptcha\n// Definitions by: George Pickering <https://github.com/geopic>\n// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n// TypeScript Version: 3.8\n\nimport { VueConstructor } from 'vue';\nexport const h: HCaptcha;\nexport default h;\n"
 }

src/_tests/fixtures/46019/derived.json

@@ -31,7 +31,8 @@
         },
         {
           "path": "types/is-secret/tslint.json",
-          "kind": "package-meta-ok"
+          "kind": "package-meta",
+          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `extends`)"
         }
       ],
       "owners": [],

src/_tests/fixtures/46019/mutations.json

@@ -4,7 +4,18 @@
     "variables": {
       "input": {
         "id": "MDEyOklzc3VlQ29tbWVudDY1NzEyNjg3Mg==",
-        "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) — [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n  - 2 added owners: @wrumsby, ✎@peterblazejewicz\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=46019&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
+        "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) — [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n  - 2 added owners: @wrumsby, ✎@peterblazejewicz\n  - Config files to check:\n    - [`is-secret/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46019/files/ceca9f768be945932c692d7dd48fa14b6ff38096#diff-2069dd3c71913a21a2c622131eaceeb2125b66d5c6b10077423d4c01735f6fd0): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `extends`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=46019&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
+      }
+    }
+  },
+  {
+    "mutation": "mutation ($input: AddLabelsToLabelableInput!) {\n  addLabelsToLabelable(input: $input) {\n    __typename\n  }\n}\n",
+    "variables": {
+      "input": {
+        "labelIds": [
+          "MDU6TGFiZWwyMTU0ODE2NTQ5"
+        ],
+        "labelableId": "MDExOlB1bGxSZXF1ZXN0NDQ3ODE1MDgx"
       }
     }
   },

src/_tests/fixtures/46019/result.json

@@ -3,12 +3,13 @@
   "labels": [
     "Maintainer Approved",
     "New Definition",
+    "Check Config",
     "Self Merge"
   ],
   "responseComments": [
     {
       "tag": "welcome",
-      "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) — [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n  - 2 added owners: @wrumsby, ✎@peterblazejewicz\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=46019&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..."
+      "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) — [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n  - 2 added owners: @wrumsby, ✎@peterblazejewicz\n  - Config files to check:\n    - [`is-secret/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46019/files/ceca9f768be945932c692d7dd48fa14b6ff38096#diff-2069dd3c71913a21a2c622131eaceeb2125b66d5c6b10077423d4c01735f6fd0): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `extends`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=46019&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..."
     },
     {
       "tag": "merge-offer",

src/_tests/fixtures/46196/_files.json

@@ -1,6 +1,6 @@
 {
   "2f300d234e09e9e34c88e884f6466f2d6d0db399:types/date-arithmetic/tsconfig.json": "{\n    \"compilerOptions\": {\n        \"module\": \"commonjs\",\n        \"lib\": [\"es6\"],\n        \"noImplicitAny\": true,\n        \"noImplicitThis\": true,\n        \"strictNullChecks\": true,\n        \"strictFunctionTypes\": true,\n        \"baseUrl\": \"../\",\n        \"typeRoots\": [\"../\"],\n        \"types\": [],\n        \"noEmit\": true,\n        \"forceConsistentCasingInFileNames\": true\n    },\n    \"files\": [\"index.d.ts\", \"some-new-file.ts\"]\n}\n",
-  "2f300d234e09e9e34c88e884f6466f2d6d0db399:types/date-arithmetic/tslint.json": "{\n    \"extends\": \"dtslint/dt.json\"\n}\n",
+  "2f300d234e09e9e34c88e884f6466f2d6d0db399:types/date-arithmetic/tslint.json": "{\n    \"extends\": \"@definitelytyped/dtslint/dt.json\"\n}\n",
   "master:types/date-arithmetic/tsconfig.json": "{\n    \"compilerOptions\": {\n        \"module\": \"commonjs\",\n        \"lib\": [\n            \"es6\"\n        ],\n        \"noImplicitAny\": true,\n        \"noImplicitThis\": true,\n        \"strictNullChecks\": true,\n        \"strictFunctionTypes\": true,\n        \"baseUrl\": \"../\",\n        \"typeRoots\": [\n            \"../\"\n        ],\n        \"types\": [],\n        \"noEmit\": true,\n        \"forceConsistentCasingInFileNames\": true\n    },\n    \"files\": [\n        \"an-old-file.ts\",\n        \"index.d.ts\",\n        \"date-arithmetic-tests.ts\"\n    ]\n}\n",
   "master:types/date-arithmetic/index.d.ts": "// Type definitions for date-arithmetic v3.1.0\n// Project: https://github.com/jquense/date-math\n// Definitions by: Sergii Paryzhskyi <https://github.com/HeeL>\n// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n\ntype Unit = 'second' | 'minutes' | 'hours' | 'day' | 'week' | 'month' | 'year' | 'decade' | 'century';\n\n/** dateArithmetic Public Instance Methods */\ninterface dateArithmeticStatic {\n    /** Add specified amount of units to a provided date and return new date as a result */\n    add(date: Date, num: number, unit: Unit): Date;\n\n    /** Subtract specified amount of units from a provided date and return new date as a result */\n    subtract(date: Date, num: number, unit: Unit): Date;\n\n    /** Compare two dates and return true if they are equal */\n    eq(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return false if they are equal */\n    neq(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is greater than date2 */\n    gt(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is greater or equal than date2 */\n    gte(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is less than date2 */\n    lt(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is less or equal than date2 */\n    lte(date: Date, date2: Date): Boolean;\n}\n\ndeclare module 'dateArithmetic' {\n    const dateArithmetic: dateArithmeticStatic;\n    export = dateArithmetic;\n}\n",
   "2f300d234e09e9e34c88e884f6466f2d6d0db399:types/date-arithmetic/index.d.ts": "// Type definitions for date-arithmetic v4.1\n// Project: https://github.com/jquense/date-math\n// Definitions by: Sergii Paryzhskyi <https://github.com/HeeL>\n// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n\ntype Unit = 'second' | 'minutes' | 'hours' | 'day' | 'week' | 'month' | 'year' | 'decade' | 'century';\n\n/** dateArithmetic Public Instance Methods */\ninterface dateArithmeticStatic {\n    /** Add specified amount of units to a provided date and return new date as a result */\n    add(date: Date, num: number, unit: Unit): Date;\n\n    /** Subtract specified amount of units from a provided date and return new date as a result */\n    subtract(date: Date, num: number, unit: Unit): Date;\n\n    /** Compare two dates and return true if they are equal */\n    eq(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return false if they are equal */\n    neq(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is greater than date2 */\n    gt(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is greater or equal than date2 */\n    gte(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is less than date2 */\n    lt(date: Date, date2: Date): Boolean;\n\n    /** Compare two dates and return true if date is less or equal than date2 */\n    lte(date: Date, date2: Date): Boolean;\n}\n\ndeclare module 'dateArithmetic' {\n    const dateArithmetic: dateArithmeticStatic;\n    export = dateArithmetic;\n}\n"

src/_tests/fixtures/49841/_files.json

@@ -1,5 +1,5 @@
 {
   "4849e8876b0ab7adc889ccc35b55fde6f0274837:types/react-native-sha1/tsconfig.json": "{\r\n    \"compilerOptions\": {\r\n        \"module\": \"commonjs\",\r\n        \"lib\": [\r\n            \"es6\"\r\n        ],\r\n        \"noImplicitAny\": true,\r\n        \"noImplicitThis\": true,\r\n        \"strictNullChecks\": true,\r\n        \"strictFunctionTypes\": true,\r\n        \"baseUrl\": \"../\",\r\n        \"typeRoots\": [\r\n            \"../\"\r\n        ],\r\n        \"types\": [],\r\n        \"noEmit\": true,\r\n        \"target\": \"es6\",\r\n        \"forceConsistentCasingInFileNames\": true\r\n    },\r\n    \"files\": [\r\n        \"index.d.ts\",\r\n        \"react-native-sha1-test.ts\"\r\n    ]\r\n}",
-  "4849e8876b0ab7adc889ccc35b55fde6f0274837:types/react-native-sha1/tslint.json": "{ \"extends\": \"dtslint/dt.json\" }",
+  "4849e8876b0ab7adc889ccc35b55fde6f0274837:types/react-native-sha1/tslint.json": "{ \"extends\": \"@definitelytyped/dtslint/dt.json\" }",
   "4849e8876b0ab7adc889ccc35b55fde6f0274837:types/react-native-sha1/index.d.ts": "// Definitions by: Amir Hossein Shekari <https://github.com/shekari-ah>\r\n\r\n\r\n\r\nexport function sha1(input: string): Promise<string>;"
 }

src/_tests/fixtures/52579-edits-infra/_files.json

@@ -1,5 +1,5 @@
 {
   "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/tsconfig.json": "{\n    \"compilerOptions\": {\n        \"module\": \"commonjs\",\n        \"lib\": [\n            \"es6\"\n        ],\n        \"noImplicitAny\": true,\n        \"noImplicitThis\": true,\n        \"strictFunctionTypes\": true,\n        \"strictNullChecks\": true,\n        \"baseUrl\": \"../\",\n        \"typeRoots\": [\n            \"../\"\n        ],\n        \"types\": [],\n        \"noEmit\": true,\n        \"forceConsistentCasingInFileNames\": true\n    },\n    \"files\": [\n        \"index.d.ts\",\n        \"vertx__eventbus-bridge-client.js-tests.ts\"\n    ]\n}\n",
-  "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/tslint.json": "{ \"extends\": \"dtslint/dt.json\" }\n",
+  "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/tslint.json": "{ \"extends\": \"@definitelytyped/dtslint/dt.json\" }\n",
   "5337ea17b2407707bead503cd20c9ca29438f5df:package.json": "{}"
 }

src/_tests/fixtures/52579/_files.json

@@ -1,5 +1,5 @@
 {
   "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/tsconfig.json": "{\n    \"compilerOptions\": {\n        \"module\": \"commonjs\",\n        \"lib\": [\n            \"es6\"\n        ],\n        \"noImplicitAny\": true,\n        \"noImplicitThis\": true,\n        \"strictFunctionTypes\": true,\n        \"strictNullChecks\": true,\n        \"baseUrl\": \"../\",\n        \"typeRoots\": [\n            \"../\"\n        ],\n        \"types\": [],\n        \"noEmit\": true,\n        \"forceConsistentCasingInFileNames\": true\n    },\n    \"files\": [\n        \"index.d.ts\",\n        \"vertx__eventbus-bridge-client.js-tests.ts\"\n    ]\n}\n",
-  "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/tslint.json": "{ \"extends\": \"dtslint/dt.json\" }\n",
+  "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/tslint.json": "{ \"extends\": \"@definitelytyped/dtslint/dt.json\" }\n",
   "5337ea17b2407707bead503cd20c9ca29438f5df:types/vertx__eventbus-bridge-client.js/index.d.ts": "// Type definitions for @vertx/eventbus-bridge-client.js 1.0\n// Project: http://vertx.io\n// Definitions by: Chiramet Phong Penglerd <https://github.com/Phong6698>\n// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n\ndeclare namespace EventBus {\n    type EventBusStatic = new(url: string, options?: any) => EventBus;\n\n    interface EventBus {\n        url: string;\n        options?: EventBusOptions;\n        onopen(): void;\n        onerror(error: EventBusError): void;\n        onclose(): void;\n        registerHandler(address: string, headers?: object, callback?: (error: Error, message: any) => void): void;\n        unregisterHandler(address: string, headers?: object, callback?: (error: Error, message: any) => void): void;\n        send(address: string, message: any, headers?: object, callback?: (error: Error, message: any) => void): void;\n        publish(address: string, message: any, headers?: any): void;\n        enableReconnect(enable: boolean): void;\n        enablePing(enable: boolean): void;\n        close(): void;\n    }\n\n    interface EventBusOptions {\n        vertxbus_reconnect_attempts_max: number; // Max reconnect attempts\n        vertxbus_reconnect_delay_min: number; // Initial delay (in ms) before first reconnect attempt\n        vertxbus_reconnect_delay_max: number; // Max delay (in ms) between reconnect attempts\n        vertxbus_reconnect_exponent: number; // Exponential backoff factor\n        vertxbus_randomization_factor: number; // Randomization factor between 0 and 1\n    }\n\n    interface EventBusError {\n        body: string;\n        type: string;\n    }\n}\n\ndeclare var EventBus: EventBus.EventBusStatic;\nexport = EventBus;\n"
 }