From 10406049ffda06014dbbc9edd5eb35471818b8e2 Mon Sep 17 00:00:00 2001 From: Eli Barzilay Date: Sat, 19 Dec 2020 05:52:08 -0500 Subject: [PATCH] Always show the list of files to check Motivated by the recent change of showing the `Check Config` label also for new packages, where in such cases the usual place where the suspicious configs are shown is not reached since there's an earlier case that shows a different comment for new packages. Instead of showing the list of files there too, this just moves the whole thing into the packages display section (which shows the links and pre-package approvals). --- src/_tests/fixtures/38979/mutations.json | 2 +- src/_tests/fixtures/38979/result.json | 2 +- src/_tests/fixtures/43151/mutations.json | 2 +- src/_tests/fixtures/43151/result.json | 2 +- src/_tests/fixtures/43314/mutations.json | 2 +- src/_tests/fixtures/43314/result.json | 2 +- .../43695-duplicate-comment/mutations.json | 2 +- .../43695-duplicate-comment/result.json | 2 +- .../fixtures/43695-post-review/mutations.json | 2 +- .../fixtures/43695-post-review/result.json | 2 +- src/_tests/fixtures/43695/mutations.json | 2 +- src/_tests/fixtures/43695/result.json | 2 +- .../fixtures/44299-with-files/mutations.json | 2 +- .../fixtures/44299-with-files/result.json | 2 +- src/_tests/fixtures/44299/mutations.json | 2 +- src/_tests/fixtures/44299/result.json | 2 +- src/_tests/fixtures/44316/mutations.json | 2 +- src/_tests/fixtures/44316/result.json | 2 +- src/_tests/fixtures/44411/mutations.json | 2 +- src/_tests/fixtures/44411/result.json | 2 +- .../mutations.json | 2 +- .../result.json | 2 +- .../mutations.json | 2 +- .../44424-2-after-travis-second/result.json | 2 +- src/_tests/fixtures/45890/mutations.json | 2 +- src/_tests/fixtures/45890/result.json | 2 +- src/_tests/fixtures/45946/mutations.json | 2 +- src/_tests/fixtures/45946/result.json | 2 +- src/_tests/fixtures/46019/mutations.json | 2 +- src/_tests/fixtures/46019/result.json | 2 +- src/_tests/fixtures/49841/mutations.json | 2 +- src/_tests/fixtures/49841/result.json | 2 +- src/compute-pr-actions.ts | 19 +++++++++++++------ 33 files changed, 45 insertions(+), 38 deletions(-) diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json index 265ca4551..2dff4599c 100644 --- a/src/_tests/fixtures/38979/mutations.json +++ b/src/_tests/fixtures/38979/mutations.json @@ -36,7 +36,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==", - "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n - Config files to check:\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json index 12e639ca2..eb143a4fa 100644 --- a/src/_tests/fixtures/38979/result.json +++ b/src/_tests/fixtures/38979/result.json @@ -10,7 +10,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n - Config files to check:\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/src/_tests/fixtures/43151/mutations.json b/src/_tests/fixtures/43151/mutations.json index ba6d89c69..ad7e93f39 100644 --- a/src/_tests/fixtures/43151/mutations.json +++ b/src/_tests/fixtures/43151/mutations.json @@ -35,7 +35,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5", - "body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n - Config files to check:\n - [`gaze/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-75a1852febb3e488c3c078da451a82e5a8609bd59ef44ddd0656bbb96150c1a0): couldn't fetch contents\n - [`gaze/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-a0512397f95f6b7994f9713c8ceb6144061e7cf0d81618a2a9a90cceda075f80): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/43151/result.json b/src/_tests/fixtures/43151/result.json index e04c698dd..d84c445db 100644 --- a/src/_tests/fixtures/43151/result.json +++ b/src/_tests/fixtures/43151/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n - Config files to check:\n - [`gaze/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-75a1852febb3e488c3c078da451a82e5a8609bd59ef44ddd0656bbb96150c1a0): couldn't fetch contents\n - [`gaze/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-a0512397f95f6b7994f9713c8ceb6144061e7cf0d81618a2a9a90cceda075f80): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/43314/mutations.json b/src/_tests/fixtures/43314/mutations.json index f6b52ba48..59349da25 100644 --- a/src/_tests/fixtures/43314/mutations.json +++ b/src/_tests/fixtures/43314/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYwMjIzODI3OQ==", - "body": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n - Config files to check:\n - [`carbon__icon-helpers/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-b85b46e7b1a183dc24eae51fb57ec188fd779236bfc818bea60bf6ac573d7be5): couldn't fetch contents\n - [`carbon__icon-helpers/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-9f7808ddcec9553672dd10ae54a269326e3346253364745d3f187e0b2b95b27b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/43314/result.json b/src/_tests/fixtures/43314/result.json index ec463273e..4524137fe 100644 --- a/src/_tests/fixtures/43314/result.json +++ b/src/_tests/fixtures/43314/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@metonym Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `carbon__icon-helpers` (*new!*) [on npm](https://www.npmjs.com/package/@carbon/icon-helpers), [on unpkg](https://unpkg.com/browse/@carbon/icon-helpers@latest/)\n - 1 added owner: ✎@metonym\n - Config files to check:\n - [`carbon__icon-helpers/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-b85b46e7b1a183dc24eae51fb57ec188fd779236bfc818bea60bf6ac573d7be5): couldn't fetch contents\n - [`carbon__icon-helpers/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43314/files/432f23fe1b87b12fe58bb1a8958f77ee3242741e#diff-9f7808ddcec9553672dd10ae54a269326e3346253364745d3f187e0b2b95b27b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index 7b7744ce5..a80a36d54 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -35,7 +35,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index 16e7a11a4..3d3fffece 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/3e836178b736e5512361ffda46e84a5c668d7a90#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 24 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/43695-post-review/mutations.json b/src/_tests/fixtures/43695-post-review/mutations.json index b77536f66..cd15e8e79 100644 --- a/src/_tests/fixtures/43695-post-review/mutations.json +++ b/src/_tests/fixtures/43695-post-review/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/43695-post-review/result.json b/src/_tests/fixtures/43695-post-review/result.json index 1418d0724..e875ce34b 100644 --- a/src/_tests/fixtures/43695-post-review/result.json +++ b/src/_tests/fixtures/43695-post-review/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/90c94f91120c026f5f8bcc586426e8590b7b4048#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "reviewer-complaint-90c94f9", diff --git a/src/_tests/fixtures/43695/mutations.json b/src/_tests/fixtures/43695/mutations.json index 9cd9dc6c8..baf7801c1 100644 --- a/src/_tests/fixtures/43695/mutations.json +++ b/src/_tests/fixtures/43695/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/43695/result.json b/src/_tests/fixtures/43695/result.json index 929950e83..6d75d4846 100644 --- a/src/_tests/fixtures/43695/result.json +++ b/src/_tests/fixtures/43695/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@alexandercerutti Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `accedo__accedo-one` (*new!*) [on npm](https://www.npmjs.com/package/@accedo/accedo-one), [on unpkg](https://unpkg.com/browse/@accedo/accedo-one@latest/)\n - 1 added owner: ✎@alexandercerutti\n - Config files to check:\n - [`accedo__accedo-one/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-9f409d2973c0c7c01b0c410e0e89f3ca15cfae8ffaa27caf2170925ae36d298b): couldn't fetch contents\n - [`accedo__accedo-one/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files/a5285cda2722912a390770722a334e6d6e43d1ab#diff-4413d8770def1e851a87a519d27ff32bc17eee42f2c9a26c9a0d59dc710e09ba): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "reviewer-complaint-a5285cd", diff --git a/src/_tests/fixtures/44299-with-files/mutations.json b/src/_tests/fixtures/44299-with-files/mutations.json index 5b1ca4e85..316908073 100644 --- a/src/_tests/fixtures/44299-with-files/mutations.json +++ b/src/_tests/fixtures/44299-with-files/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMDcwMjk5OQ==", - "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/44299-with-files/result.json b/src/_tests/fixtures/44299-with-files/result.json index 610c0f033..37dcbc8fb 100644 --- a/src/_tests/fixtures/44299-with-files/result.json +++ b/src/_tests/fixtures/44299-with-files/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/44299/mutations.json b/src/_tests/fixtures/44299/mutations.json index 5b1ca4e85..fa7a56424 100644 --- a/src/_tests/fixtures/44299/mutations.json +++ b/src/_tests/fixtures/44299/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMDcwMjk5OQ==", - "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-c441c94ec5219d4722929ccb738301643b5eef17a151184505f387fdbec13408): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/44299/result.json b/src/_tests/fixtures/44299/result.json index 610c0f033..78f85673c 100644 --- a/src/_tests/fixtures/44299/result.json +++ b/src/_tests/fixtures/44299/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@geopic Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `hcaptcha__vue-hcaptcha` (*new!*) [on npm](https://www.npmjs.com/package/@hcaptcha/vue-hcaptcha), [on unpkg](https://unpkg.com/browse/@hcaptcha/vue-hcaptcha@latest/)\n - 1 added owner: ✎@geopic\n - Config files to check:\n - [`hcaptcha__vue-hcaptcha/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-7f6b3c89357f5b55cbe423c5b8d87644a735796ed0ba5d4be803a615d304a83b): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-6ded07af09e0936a1c143bb0fbfaca37e9df9668ecc22d402a833077e66abe54): couldn't fetch contents\n - [`hcaptcha__vue-hcaptcha/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44299/files/683fb3b1298223256be3a49823686f35bd94a730#diff-c441c94ec5219d4722929ccb738301643b5eef17a151184505f387fdbec13408): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/44316/mutations.json b/src/_tests/fixtures/44316/mutations.json index e8ed4fcb2..a349bdd7e 100644 --- a/src/_tests/fixtures/44316/mutations.json +++ b/src/_tests/fixtures/44316/mutations.json @@ -13,7 +13,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMDg5MzUyMA==", - "body": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n - Config files to check:\n - [`vimeo/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files/55357f7d60d059b5c84a23bd92854276a8f9a419#diff-2b7f4c3a0b1cb5a892e62dacc9c3d0caa20601673c8d00380be51ba66708f2d1): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/44316/result.json b/src/_tests/fixtures/44316/result.json index 7502d9eb6..8f62a9b51 100644 --- a/src/_tests/fixtures/44316/result.json +++ b/src/_tests/fixtures/44316/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@mattleff Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `vimeo` [on npm](https://www.npmjs.com/package/vimeo), [on unpkg](https://unpkg.com/browse/vimeo@latest/) (author is owner)\n - Config files to check:\n - [`vimeo/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files/55357f7d60d059b5c84a23bd92854276a8f9a419#diff-2b7f4c3a0b1cb5a892e62dacc9c3d0caa20601673c8d00380be51ba66708f2d1): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/44411/mutations.json b/src/_tests/fixtures/44411/mutations.json index 1c26125e1..efd6554e4 100644 --- a/src/_tests/fixtures/44411/mutations.json +++ b/src/_tests/fixtures/44411/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjMzMzI3Ng==", - "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n - Config files to check:\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/src/_tests/fixtures/44411/result.json b/src/_tests/fixtures/44411/result.json index 301ed23b1..014e7dd6a 100644 --- a/src/_tests/fixtures/44411/result.json +++ b/src/_tests/fixtures/44411/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `jest-image-snapshot` [on npm](https://www.npmjs.com/package/jest-image-snapshot), [on unpkg](https://unpkg.com/browse/jest-image-snapshot@latest/)\n - 1 added owner: ✎@peterblazejewicz\n - Config files to check:\n - [`jest-image-snapshot/v2/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-1f4726d9a1e26e3aece8d2702af9d5d3edb1e32180192e2298b02147509485dc): couldn't fetch contents\n - [`jest-image-snapshot/v2/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44411/files/d0d51a062525a6a4b83b297cd0e75adb4d5628f6#diff-651efbe7a0eea62a82aef2b62fa707b7e8b8ea105e561e291b401f8b5b910b1b): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json index 7a05011a9..4d0f3839c 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/mutations.json @@ -13,7 +13,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjUyNzAxNQ==", - "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json b/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json index 8cc4ee757..df549323c 100644 --- a/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json +++ b/src/_tests/fixtures/44424-1-travis-instantly-finished/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/src/_tests/fixtures/44424-2-after-travis-second/mutations.json b/src/_tests/fixtures/44424-2-after-travis-second/mutations.json index bfaaa52cc..6b1b6e7d3 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/mutations.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYyMjUyNzAxNQ==", - "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/src/_tests/fixtures/44424-2-after-travis-second/result.json b/src/_tests/fixtures/44424-2-after-travis-second/result.json index 1b7d7d6b0..a900d747e 100644 --- a/src/_tests/fixtures/44424-2-after-travis-second/result.json +++ b/src/_tests/fixtures/44424-2-after-travis-second/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@tomer-openfin Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `openfin` [on npm](https://www.npmjs.com/package/openfin), [on unpkg](https://unpkg.com/browse/openfin@latest/) (author is owner)\n - Config files to check:\n - [`openfin/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-004d79898182f654ce84ac7deed9a38f3c41c438de9af7a5e1edf9c5cfa0fcb4): couldn't fetch contents\n - [`openfin/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-59b1ab6d62c34c8b064f27d3f16a88e20e60adde2ed7bf0d3529a59fa0c8ed03): couldn't fetch contents\n - [`openfin/v49/OTHER_FILES.txt`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44424/files/af636941dac21c0752befa1617297dfdac3e0a52#diff-90b0a88e7d7d6ab8f4246471243a6fbc2699361d94c22ab900ff93b9e190893c): couldn't fetch contents\n\n## Code Reviews\n\nBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have finished\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/src/_tests/fixtures/45890/mutations.json b/src/_tests/fixtures/45890/mutations.json index 09763e823..13e5b8e67 100644 --- a/src/_tests/fixtures/45890/mutations.json +++ b/src/_tests/fixtures/45890/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDY1MzgxMDQ1NA==", - "body": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n - Config files to check:\n - [`greek-utils/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-8580e62e675e57ce0e41bc84092e01b449be703b016d9bf5378c75fb02e5adc3): couldn't fetch contents\n - [`greek-utils/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-1beeab429f4237a976a64069a8a9b4eee96b609637784407d8975647ca13c8a5): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/45890/result.json b/src/_tests/fixtures/45890/result.json index 97dfc899a..fd5674186 100644 --- a/src/_tests/fixtures/45890/result.json +++ b/src/_tests/fixtures/45890/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@dimkirt Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `greek-utils` (*new!*) [on npm](https://www.npmjs.com/package/greek-utils), [on unpkg](https://unpkg.com/browse/greek-utils@latest/)\n - 1 added owner: ✎@dimkirt\n - Config files to check:\n - [`greek-utils/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-8580e62e675e57ce0e41bc84092e01b449be703b016d9bf5378c75fb02e5adc3): couldn't fetch contents\n - [`greek-utils/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45890/files/146c312eac4c4ac8931b4ec6b2762457f8f4b6e6#diff-1beeab429f4237a976a64069a8a9b4eee96b609637784407d8975647ca13c8a5): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/45946/mutations.json b/src/_tests/fixtures/45946/mutations.json index c9b9f4aea..2218376cb 100644 --- a/src/_tests/fixtures/45946/mutations.json +++ b/src/_tests/fixtures/45946/mutations.json @@ -35,7 +35,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDY1NTMxNzQwNQ==", - "body": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n - Config files to check:\n - [`asynciterator/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-be20504719e5f1036e683d4ddaab8bf2b1c609ea12aa30786497768f575095ad): couldn't fetch contents\n - [`asynciterator/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-e3a26c4ba64c5ed587d2b797151728488e274f4be74c1558722a8a32cf7a31c9): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/45946/result.json b/src/_tests/fixtures/45946/result.json index 94c795ccd..f6ad3f658 100644 --- a/src/_tests/fixtures/45946/result.json +++ b/src/_tests/fixtures/45946/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@rubensworks Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR\n\n* `asynciterator` (*probably deleted!*) [on npm](https://www.npmjs.com/package/asynciterator), [on unpkg](https://unpkg.com/browse/asynciterator@latest/) (author is owner)\n - Config files to check:\n - [`asynciterator/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-be20504719e5f1036e683d4ddaab8bf2b1c609ea12aa30786497768f575095ad): couldn't fetch contents\n - [`asynciterator/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-e3a26c4ba64c5ed587d2b797151728488e274f4be74c1558722a8a32cf7a31c9): couldn't fetch contents\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files/a5eb1f19e7a31387e7d7c79b3acc483b0e60b32e#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/_tests/fixtures/46019/mutations.json b/src/_tests/fixtures/46019/mutations.json index 411b2c1a7..ae94ff4ac 100644 --- a/src/_tests/fixtures/46019/mutations.json +++ b/src/_tests/fixtures/46019/mutations.json @@ -15,7 +15,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDY1NzEyNjg3Mg==", - "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n - Config files to check:\n - [`is-secret/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46019/files/ceca9f768be945932c692d7dd48fa14b6ff38096#diff-d5cb28ac6bc4842869aa49fee16653bddadedda2f36bf881ddd3ed7cdc6cce6b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/46019/result.json b/src/_tests/fixtures/46019/result.json index 395ac097b..e900e2c5d 100644 --- a/src/_tests/fixtures/46019/result.json +++ b/src/_tests/fixtures/46019/result.json @@ -10,7 +10,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@peterblazejewicz Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `is-secret` (*new!*) [on npm](https://www.npmjs.com/package/is-secret), [on unpkg](https://unpkg.com/browse/is-secret@latest/)\n - 2 added owners: @wrumsby, ✎@peterblazejewicz\n - Config files to check:\n - [`is-secret/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46019/files/ceca9f768be945932c692d7dd48fa14b6ff38096#diff-d5cb28ac6bc4842869aa49fee16653bddadedda2f36bf881ddd3ed7cdc6cce6b): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/src/_tests/fixtures/49841/mutations.json b/src/_tests/fixtures/49841/mutations.json index 461ca1bb9..adf494c7d 100644 --- a/src/_tests/fixtures/49841/mutations.json +++ b/src/_tests/fixtures/49841/mutations.json @@ -37,7 +37,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5", - "body": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n - Config files to check:\n - [`react-native-sha1/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files/4849e8876b0ab7adc889ccc35b55fde6f0274837#diff-579fae17725faf40efb4aac22d7bcfb2337ec7080258e4a206f5a479968d3556): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/src/_tests/fixtures/49841/result.json b/src/_tests/fixtures/49841/result.json index b996a0fed..ef2472d4b 100644 --- a/src/_tests/fixtures/49841/result.json +++ b/src/_tests/fixtures/49841/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@shekari-ah Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `react-native-sha1` (*new!*) [on npm](https://www.npmjs.com/package/react-native-sha1), [on unpkg](https://unpkg.com/browse/react-native-sha1@latest/)\n - Config files to check:\n - [`react-native-sha1/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files/4849e8876b0ab7adc889ccc35b55fde6f0274837#diff-579fae17725faf40efb4aac22d7bcfb2337ec7080258e4a206f5a479968d3556): not [the required form](https://github.com/DefinitelyTyped/DefinitelyTyped#tsconfigjson)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/src/compute-pr-actions.ts b/src/compute-pr-actions.ts index 09b1043c0..a3a857462 100644 --- a/src/compute-pr-actions.ts +++ b/src/compute-pr-actions.ts @@ -433,6 +433,9 @@ function createWelcomeComment(info: ExtendedPrInfo, post: (c: Comments.Comment) const announceList = (what: string, xs: readonly string[]) => `${xs.length} ${what}${xs.length > 1 ? "s" : ""}` const usersToString = (users: string[]) => users.map(u => (info.isAuthor(u) ? "✎" : "") + "@" + u).join(", "); + const reviewLink = (f: FileInfo) => + `[\`${f.path.replace(/^types\/(.*\/)/, "$1")}\`](${ + urls.review(info.pr_number)}/${info.headCommitOid}#diff-${sha256(f.path)})`; display(``, `## ${announceList("package", info.packages)} in this PR`, @@ -463,8 +466,17 @@ function createWelcomeComment(info: ExtendedPrInfo, post: (c: Comments.Comment) displayOwners("added", p.addedOwners); displayOwners("removed", p.deletedOwners); if (!info.authorIsOwner && p.owners.length >= 4 && p.addedOwners.some(info.isAuthor)) addedSelfToManyOwners++; + + let showSuspects = false; + for (const file of p.files) { + if (!file.suspect) continue; + if (!showSuspects) display(` - Config files to check:`); + display(` - ${reviewLink(file)}: ${file.suspect}`); + showSuspects = true; + } + } - if (addedSelfToManyOwners) { + if (addedSelfToManyOwners > 0) { display(``, `@${info.author}: I see that you have added yourself as an owner${addedSelfToManyOwners > 1 ? " to several packages" : ""}, are you sure you want to [become an owner](${urls.definitionOwners})?`); } @@ -501,9 +513,6 @@ function createWelcomeComment(info: ExtendedPrInfo, post: (c: Comments.Comment) display(` * ${emoji(info.ciResult === CIResult.Pass)} Continuous integration tests have ${expectedResults}`); const approved = emoji(info.approved); - const reviewLink = (f: FileInfo) => - `[\`${f.path.replace(/^types\/(.*\/)/, "$1")}\`](${ - urls.review(info.pr_number)}/${info.headCommitOid}#diff-${sha256(f.path)})`; if (info.hasNewPackages) { display(` * ${approved} Only ${requiredApprover} can approve changes when there are new packages added`); @@ -525,8 +534,6 @@ function createWelcomeComment(info: ExtendedPrInfo, post: (c: Comments.Comment) display(` * ${approved} ${RequiredApprover} can merge changes when there are no other reviewers`); } else if (info.checkConfig) { display(` * ${approved} ${RequiredApprover} needs to approve changes which affect module config files`); - info.pkgInfo.forEach(pkg => pkg.files.forEach(file => - file.suspect && display(` - ${reviewLink(file)}: ${file.suspect}`))); } else { display(` * ${approved} Only ${requiredApprover} can approve changes [without tests](${testsLink})`); }