Skip to content

Commit dd2a894

Browse files
Petter Walbø JohnsgårdAnna
authored andcommitted
Move padding on large and medium sized cards from .savage-card-body to .savage-card-body-inner (#63)
* Move padding to `.savage-card-body-inner` to solve overflow issue in IE * Compile css * Add PR link in changelog
1 parent b01a1cb commit dd2a894

File tree

5 files changed

+835
-6
lines changed

5 files changed

+835
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 1.4.0
4+
### Breaking Change
5+
- Moved padding on large and medium sized cards from `.savage-card-body` to `.savage-card-body-inner`. This solves an issue in IE where the text got outside of the grid. [#63](https://github.com/DekodeInteraktiv/hogan-grid/pull/63)
6+
37
## 1.3.1
48
- Add filters for grid and item class names. [#61](https://github.com/DekodeInteraktiv/hogan-grid/pull/61)
59

assets/hogan-grid.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

hogan-grid.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* Plugin URI: https://github.com/dekodeinteraktiv/hogan-grid
55
* GitHub Plugin URI: https://github.com/dekodeinteraktiv/hogan-grid
66
* Description: Card Grid Module for Hogan
7-
* Version: 1.3.1
7+
* Version: 1.4.0
88
* Author: Dekode
99
* Author URI: https://dekode.no
1010
* License: GPL-3.0-or-later
@@ -24,7 +24,7 @@
2424
exit; // Exit if accessed directly.
2525
}
2626

27-
define( 'HOGAN_GRID_VERSION', '1.2.1' );
27+
define( 'HOGAN_GRID_VERSION', '1.4.0' );
2828

2929
add_action( 'plugins_loaded', __NAMESPACE__ . '\\hogan_grid_load_textdomain' );
3030
add_action( 'hogan/include_modules', __NAMESPACE__ . '\\hogan_grid_register_module', 10, 1 );

src/style.css

Lines changed: 30 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,10 @@
264264
}
265265

266266
.hogan-grid .hogan-grid-item-size-large .savage-card-body {
267+
padding: 0;
268+
}
269+
270+
.hogan-grid .hogan-grid-item-size-large .savage-card-body-inner {
267271
padding: 0 60px;
268272
}
269273

@@ -335,6 +339,10 @@
335339
}
336340

337341
.hogan-grid-item-size-medium .savage-card-body {
342+
padding: 0;
343+
}
344+
345+
.hogan-grid-item-size-medium .savage-card-body-inner {
338346
padding: 0 40px;
339347
}
340348

@@ -398,6 +406,10 @@
398406
}
399407

400408
.hogan-grid .hogan-grid-item-size-large .savage-card-body {
409+
padding: 0;
410+
}
411+
412+
.hogan-grid .hogan-grid-item-size-large .savage-card-body-inner {
401413
padding: 0 80px;
402414
}
403415

@@ -450,6 +462,10 @@
450462
}
451463

452464
.hogan-grid .hogan-grid-item-size-large .savage-card-body {
465+
padding: 0;
466+
}
467+
468+
.hogan-grid .hogan-grid-item-size-large .savage-card-body-inner {
453469
padding: 0 120px;
454470
}
455471

@@ -487,6 +503,11 @@
487503

488504
.hogan-grid-item-size-medium .savage-card-body,
489505
.hogan-grid-item-size-large .savage-card-body {
506+
padding: 0;
507+
}
508+
509+
.hogan-grid-item-size-medium .savage-card-body-inner,
510+
.hogan-grid-item-size-large .savage-card-body-inner {
490511
padding: 0 60px;
491512
}
492513

@@ -565,12 +586,18 @@
565586
}
566587
}
567588

568-
.hogan-grid .hogan-grid-item-size-large .savage-card-body {
589+
.hogan-grid .hogan-grid-item-size-large .savage-card-body,
590+
.hogan-grid-item-size-medium .savage-card-body,
591+
.hogan-grid-item-size-large .savage-card-body {
592+
padding: 0;
593+
}
594+
595+
.hogan-grid .hogan-grid-item-size-large .savage-card-body-inner {
569596
padding: 0 130px;
570597
}
571598

572-
.hogan-grid-item-size-medium .savage-card-body,
573-
.hogan-grid-item-size-large .savage-card-body {
599+
.hogan-grid-item-size-medium .savage-card-body-inner,
600+
.hogan-grid-item-size-large .savage-card-body-inner {
574601
padding: 0 65px;
575602
}
576603

0 commit comments

Comments
 (0)