Merge branch 'master' of github.com:lucasteles/Backdash

Author: lucasteles

.config/dotnet-tools.json

@@ -17,7 +17,7 @@
       "rollForward": false
     },
     "docfx": {
-      "version": "2.78.4",
+      "version": "2.78.5",
       "commands": [
         "docfx"
       ],

Directory.Build.props

@@ -58,7 +58,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="SonarAnalyzer.CSharp" Version="10.19.*">
+    <PackageReference Include="SonarAnalyzer.CSharp" Version="10.22.*">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

src/Backdash/Data/ByteSize.cs

@@ -241,6 +241,12 @@ public bool TryFormat(Span<char> destination, out int charsWritten, ReadOnlySpan
         return writer.Write(value, format);
     }
 
+    /// <summary>Cast <see cref="ByteSize"/> to <see cref="long"/> byte-count value.</summary>
+    public static explicit operator long(ByteSize size) => size.ByteCount;
+
+    /// <summary>Cast <see cref="ByteSize"/> to <see cref="int"/> byte-count value.</summary>
+    public static explicit operator int(ByteSize size) => (int)size.ByteCount;
+
     /// <inheritdoc />
     public static bool operator >(ByteSize left, ByteSize right) => left.ByteCount > right.ByteCount;
 

src/Backdash/Session/NetcodeSessionExtensions.cs

@@ -11,27 +11,42 @@ public static class NetcodeSessionExtensions
     /// <summary>
     ///    Returns the current state string representation
     /// </summary>
+    public static string GetStateString<T>(this INetcodeSession<T> @this, IStateStringParser? parser = null)
+        where T : unmanaged
+    {
+        var state = @this.GetCurrentSavedFrame();
+        var currentBytes = state.GameState.WrittenSpan;
+        return @this.GetStateString(state.Frame, currentBytes, parser);
+    }
+
+    /// <summary>
+    ///    Returns string representation for given <paramref name="state"/>
+    /// </summary>
     public static string GetStateString<T>(
         this INetcodeSession<T> @this,
+        StateSnapshot state,
         IStateStringParser? parser = null
-    ) where T : unmanaged =>
-        @this.GetStateString(@this.GetCurrentSavedFrame(), parser);
+    ) where T : unmanaged
+    {
+        var stateBytes = state.State.AsSpan(0, (int)state.Size);
+        return @this.GetStateString(state.Frame, stateBytes, parser);
+    }
 
     /// <summary>
-    ///    Returns string representation for given <paramref name="state"/>
+    ///    Returns string representation for given <paramref name="frame"/> and <paramref name="stateBytes"/>
     /// </summary>
-    public static string GetStateString<T>(
+    static string GetStateString<T>(
         this INetcodeSession<T> @this,
-        SavedFrame state,
+        Frame frame,
+        ReadOnlySpan<byte> stateBytes,
         IStateStringParser? parser = null
     ) where T : unmanaged
     {
         parser ??= JsonStateStringParser.Singleton;
-        var currentOffset = 0;
-        var currentBytes = state.GameState.WrittenSpan;
-        BinaryBufferReader currentReader = new(currentBytes, ref currentOffset, @this.StateSerializationEndianness);
-        var currentObject = @this.GetHandler().CreateState(state.Frame, ref currentReader);
-        return parser.GetStateString(state.Frame, in currentReader, currentObject);
+        var offset = 0;
+        BinaryBufferReader reader = new(stateBytes, ref offset, @this.StateSerializationEndianness);
+        var stateObject = @this.GetHandler().CreateState(frame, ref reader);
+        return parser.GetStateString(frame, in reader, stateObject);
     }
 
     /// <summary>

tests/Backdash.Tests/Backdash.Tests.csproj

@@ -14,14 +14,14 @@
     <PackageReference Include="FakeItEasy.AutoFakeIt" Version="2.0.0"/>
     <PackageReference Include="FluentAssertions" Version="[7.2.0]"/>
     <PackageReference Include="FsCheck.Xunit" Version="3.3.2" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.4.0" />
     <PackageReference Include="ObjectLayoutInspector" Version="0.1.4" />
     <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="8.0.0">
+    <PackageReference Include="coverlet.collector" Version="8.0.1">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>