add notready error case

Author: lucasteles

benchmarks/Backdash.Benchmarks/Cases/StructWriteBenchmark.cs

@@ -43,10 +43,10 @@ public void ReadWrite()
     public void AsBytes()
     {
         var buffer = GetBuffer();
-        Mem.AsBytes(in data).CopyTo(buffer);
+        Mem.AsBytes(ref data).CopyTo(buffer);
 
         StructData copy = default;
-        buffer.CopyTo(Mem.AsBytes(in copy));
+        buffer.CopyTo(Mem.AsBytes(ref copy));
 
         Debug.Assert(data == copy);
     }

src/Backdash/Core/Mem.cs

@@ -15,8 +15,7 @@ static class Mem
     public static ReadOnlySpan<T> AsSpan<T>(ref readonly T data) where T : unmanaged => new(in data);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static Span<byte> AsBytes<T>(scoped ref readonly T data) where T : unmanaged =>
-        MemoryMarshal.AsBytes(new Span<T>(ref Unsafe.AsRef(in data)));
+    public static Span<byte> AsBytes<T>(ref T data) where T : unmanaged => MemoryMarshal.AsBytes(new Span<T>(ref data));
 
     public static bool EqualBytes(ReadOnlySpan<byte> left, ReadOnlySpan<byte> right, bool truncate = false)
     {

src/Backdash/Network/Protocol/Comm/ProtocolInbox.cs

@@ -50,7 +50,7 @@ public void OnPeerMessage(ref readonly ProtocolMessage message, in SocketAddress
         }
 
         var seqNum = message.Header.SequenceNumber;
-        if (message.Header.Type is not MessageType.SyncRequest and not MessageType.SyncReply)
+        if (message.Header.Type is not (MessageType.SyncRequest or MessageType.SyncReply))
         {
             if (state.CurrentStatus is not ProtocolStatus.Running)
             {
@@ -245,7 +245,7 @@ bool OnSyncReply(ref readonly ProtocolMessage msg, ref ProtocolMessage replyMsg)
         if (options.NumberOfSyncRoundTrips >= state.Sync.RemainingRoundTrips)
             state.Sync.TotalRoundTripsPing = TimeSpan.Zero;
         state.Sync.TotalRoundTripsPing += elapsed;
-        if (--state.Sync.RemainingRoundTrips == 0)
+        if (--state.Sync.RemainingRoundTrips is 0)
         {
             var ping = state.Sync.TotalRoundTripsPing / options.NumberOfSyncRoundTrips;
             logger.Write(LogLevel.Information,

src/Backdash/ResultCode.cs

@@ -51,4 +51,7 @@ public enum ResultCode : short
 
     /// <summary>The current session type not support the requested operation.</summary>
     NotSupported,
+
+    /// <summary>The value is not ready to be ready.</summary>
+    NotReady,
 }

src/Backdash/Session/Backends/SpectatorSession.cs

@@ -309,7 +309,7 @@ public ResultCode SynchronizeInputs()
         if (input.Frame.Number < CurrentFrame.Number)
         {
             // Haven't received the input from the host yet.  Wait
-            return ResultCode.PredictionThreshold;
+            return ResultCode.NotReady;
         }
 
         if (input.Frame.Number > CurrentFrame.Number)

tests/Backdash.Tests/Backdash.Tests.csproj

@@ -14,14 +14,14 @@
     <PackageReference Include="FakeItEasy.AutoFakeIt" Version="2.0.0"/>
     <PackageReference Include="FluentAssertions" Version="[7.2.0]"/>
     <PackageReference Include="FsCheck.Xunit" Version="3.3.2" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
     <PackageReference Include="ObjectLayoutInspector" Version="0.1.4" />
     <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="coverlet.collector" Version="6.0.4">
+    <PackageReference Include="coverlet.collector" Version="8.0.0">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>