allow empty "WIthPlayers" in SessionBuilder

lucasteles · lucasteles · commit 48df406d903b · 2026-02-10T19:55:24.000-03:00
diff --git a/src/Backdash/Session/NetcodeSessionBuilder.cs b/src/Backdash/Session/NetcodeSessionBuilder.cs
@@ -159,7 +159,6 @@ public NetcodeSessionBuilder<TInput> WithPlayerCount(int count)
     {
         ArgumentOutOfRangeException.ThrowIfNegativeOrZero(count);
         options.NumberOfPlayers = count;
-
         return this;
     }
 
@@ -169,7 +168,6 @@ public NetcodeSessionBuilder<TInput> WithPlayerCount(int count)
     public NetcodeSessionBuilder<TInput> WithPlayers(params NetcodePlayer[] players)
     {
         ArgumentNullException.ThrowIfNull(players);
-        ArgumentOutOfRangeException.ThrowIfZero(players.Length);
         playerList.AddRange(players);
         return this;
     }
@@ -181,7 +179,6 @@ public NetcodeSessionBuilder<TInput> WithPlayers(IEnumerable<NetcodePlayer> play
     {
         ArgumentNullException.ThrowIfNull(players);
         playerList.AddRange(players);
-        ArgumentOutOfRangeException.ThrowIfZero(playerList.Count);
         return this;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,6 @@ public NetcodeSessionBuilder<TInput> WithPlayerCount(int count)`
`159`	`159`	`{`
`160`	`160`	`ArgumentOutOfRangeException.ThrowIfNegativeOrZero(count);`
`161`	`161`	`options.NumberOfPlayers = count;`
`162`		`-`
`163`	`162`	`return this;`
`164`	`163`	`}`
`165`	`164`
`@@ -169,7 +168,6 @@ public NetcodeSessionBuilder<TInput> WithPlayerCount(int count)`
`169`	`168`	`public NetcodeSessionBuilder<TInput> WithPlayers(params NetcodePlayer[] players)`
`170`	`169`	`{`
`171`	`170`	`ArgumentNullException.ThrowIfNull(players);`
`172`		`- ArgumentOutOfRangeException.ThrowIfZero(players.Length);`
`173`	`171`	`playerList.AddRange(players);`
`174`	`172`	`return this;`
`175`	`173`	`}`
`@@ -181,7 +179,6 @@ public NetcodeSessionBuilder<TInput> WithPlayers(IEnumerable<NetcodePlayer> play`
`181`	`179`	`{`
`182`	`180`	`ArgumentNullException.ThrowIfNull(players);`
`183`	`181`	`playerList.AddRange(players);`
`184`		`- ArgumentOutOfRangeException.ThrowIfZero(playerList.Count);`
`185`	`182`	`return this;`
`186`	`183`	`}`
`187`	`184`