GRIDEDIT-1926 '-Wno-unused-parameters' behind optional configuration parameter (#517)

* GRIDEDIT-1926 '-Wno-unused-parameters' behind optional configuration. Only needed on MacOS15-intel runners
* Update cmake/compiler_config.cmake

Fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Remove unused ARCH_FLAG variable from workflow (#518)

* Initial plan

* Remove unused ARCH_FLAG variable

Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Author: 3 people

.github/workflows/build-and-test-workflow.yml

@@ -109,9 +109,10 @@ jobs:
       # Step: CMake configuration
       - name: Configure
         run: |
-          ARCH_FLAG=""
-          if [ "${{ runner.arch }}" = "ARM64" ]; then
-            ARCH_FLAG="-DCMAKE_OSX_ARCHITECTURES=arm64"
+          SUPPRESS_PARAM_FLAG=""
+          if [ "${{ inputs.platform }}" = "macos-15-intel" ]; then
+            # Suppress unused parameter warnings on macOS 15 Intel runner (known platform-specific issue)
+            SUPPRESS_PARAM_FLAG="-DSUPPRESS_UNUSED_PARAMETER_WARNING=ON"
           fi
           
           cmake \
@@ -120,7 +121,7 @@ jobs:
             -DCMAKE_BUILD_TYPE=${{ inputs.build_type }} \
             -DCMAKE_PREFIX_PATH=${{ steps.paths.outputs.ext_deps_dir }}/netcdf-c/install/netcdf-c \
             -DCMAKE_INSTALL_PREFIX=${{ steps.paths.outputs.install_dir }} \
-            $ARCH_FLAG \
+            $SUPPRESS_PARAM_FLAG \
             -DOpenMP_C_FLAGS="-Xpreprocessor -fopenmp -I$HOMEBREW_PREFIX/opt/libomp/include" \
             -DOpenMP_CXX_FLAGS="-Xpreprocessor -fopenmp -I$HOMEBREW_PREFIX/opt/libomp/include" \
             -DOpenMP_C_LIB_NAMES="omp" \

cmake/compiler_config.cmake

@@ -14,7 +14,12 @@ if(APPLE)
   if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     message(STATUS "Configuring build for macOS with ${CMAKE_CXX_COMPILER_ID} (${CMAKE_CXX_COMPILER_VERSION}).")
     # Common warning and visibility flags
-    add_compile_options("-fvisibility=hidden;-Wall;-Wextra;-pedantic;-Werror;-Wno-unused-function;-Wno-unused-parameter")
+    add_compile_options("-fvisibility=hidden;-Wall;-Wextra;-pedantic;-Werror;-Wno-unused-function")
+    # Conditionally suppress unused parameter warnings (used for platform-specific compiler issues)
+    if(SUPPRESS_UNUSED_PARAMETER_WARNING)
+      add_compile_options("-Wno-unused-parameter")
+      message(STATUS "Suppressing -Wno-unused-parameter warnings for macOS Clang build on macOS15-intel")
+    endif()
     # Be lenient for Eigen (deprecated enum conversion) on all macOS Clang builds
     add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-Wno-deprecated-enum-enum-conversion>)
     # Optimization / debug flags

cmake/options.cmake

@@ -37,3 +37,10 @@ option(
   "Includes source location information in customized exceptions."
   OFF
 )
+
+# suppress unused parameter warnings (sometimes necessary for platform-specific builds)
+option(
+  SUPPRESS_UNUSED_PARAMETER_WARNING
+  "Suppress -Wno-unused-parameter warning flag (used for platform-specific compiler issues)."
+  OFF
+)