Skip to content

Commit 48d1726

Browse files
authored
Switch to default check-bounds (#2927)
Fixes #2908 Might close this issue, let's see #2850.
1 parent 7078730 commit 48d1726

File tree

5 files changed

+14
-23
lines changed

5 files changed

+14
-23
lines changed

.vscode/settings.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@
6565
],
6666
"files.insertFinalNewline": true,
6767
"julia.executablePath": "julia +1.12.5",
68-
"julia.additionalArgs": [
69-
"--check-bounds=yes"
70-
],
7168
"julia.lint.disabledDirs": [
7269
".pixi"
7370
],

docs/reference/node/discrete-control.qmd

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
---
22
title: "![](/assets/node-icons/DiscreteControl.svg){height=20} DiscreteControl"
33
engine: julia
4-
julia:
5-
exeflags: ["--check-bounds=yes"]
64
---
75

86
Set parameters of other nodes based on model state conditions (e.g. Basin level).

docs/reference/node/tabulated-rating-curve.qmd

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
---
22
title: "![](/assets/node-icons/TabulatedRatingCurve.svg){height=20} TabulatedRatingCurve"
33
engine: julia
4-
julia:
5-
exeflags: ["--check-bounds=yes"]
64
---
75

86
A TabulatedRatingCurve determines outflow from a Basin by looking up the flow rate that corresponds to the current upstream level from a rating curve.

docs/reference/validation.qmd

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
---
22
title: "Validation"
33
engine: julia
4-
julia:
5-
exeflags: ["--check-bounds=yes"]
64
---
75

86
The tables below show the validation rules applied to the input to the Julia core before running the model.

pixi.toml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ install = { depends-on = [
2929
"initialize-julia",
3030
] }
3131
# Julia
32-
update-registry-julia = { cmd = "julia --check-bounds=yes --eval='using Pkg; Registry.update()'" }
33-
update-manifest-julia = { cmd = "julia --check-bounds=yes --project utils/update-manifest.jl" }
34-
instantiate-julia = { cmd = "julia --project --check-bounds=yes --eval='using Pkg; Pkg.instantiate()'" }
32+
update-registry-julia = { cmd = "julia --eval='using Pkg; Registry.update()'" }
33+
update-manifest-julia = { cmd = "julia --project utils/update-manifest.jl" }
34+
instantiate-julia = { cmd = "julia --project --eval='using Pkg; Pkg.instantiate()'" }
3535
initialize-julia = { depends-on = [
3636
"update-registry-julia",
3737
"instantiate-julia",
3838
] }
39-
initialize-julia-test = { cmd = "julia --project=core --check-bounds=yes --eval 'using Pkg; Pkg.test(allow_reresolve=false, test_args=[\"skip\"])'", depends-on = [
39+
initialize-julia-test = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test(allow_reresolve=false, test_args=[\"skip\"])'", depends-on = [
4040
"initialize-julia",
4141
] }
4242
# Docs
@@ -74,7 +74,7 @@ lint = { depends-on = [
7474
"mypy-ribasim-qgis",
7575
] }
7676
# Build
77-
build = { "cmd" = "julia --project --check-bounds=yes build/build.jl", depends-on = [
77+
build = { "cmd" = "julia --project build/build.jl", depends-on = [
7878
"generate-testmodels",
7979
"initialize-julia",
8080
] }
@@ -88,7 +88,7 @@ s3-upload = { cmd = "python utils/s3_upload.py {{ source }} {{ destination }}",
8888
"destination",
8989
] }
9090
test-ribasim-cli = "pytest --numprocesses=4 --basetemp=build/tests/temp --junitxml=report.xml build/tests"
91-
test-ribasim-core = { cmd = "julia --project=core --check-bounds=yes --eval 'using Pkg; Pkg.test(allow_reresolve=false)'", depends-on = [
91+
test-ribasim-core = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test(allow_reresolve=false)'", depends-on = [
9292
"generate-testmodels",
9393
] }
9494
test-ribasim-migration = { cmd = "pytest --numprocesses=4 -m regression python/ribasim/tests", depends-on = [
@@ -97,10 +97,10 @@ test-ribasim-migration = { cmd = "pytest --numprocesses=4 -m regression python/r
9797
"hws_migration_test/",
9898
] },
9999
] }
100-
test-ribasim-core-cov = { cmd = "julia --project=core --check-bounds=yes --eval 'using Pkg; Pkg.test(allow_reresolve=false, coverage=true)'", depends-on = [
100+
test-ribasim-core-cov = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test(allow_reresolve=false, coverage=true)'", depends-on = [
101101
"generate-testmodels",
102102
] }
103-
test-ribasim-regression = { cmd = "julia --project=core --check-bounds=yes --eval 'using Pkg; Pkg.test(allow_reresolve=false, test_args=[\"regression\"])'", depends-on = [
103+
test-ribasim-regression = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test(allow_reresolve=false, test_args=[\"regression\"])'", depends-on = [
104104
"generate-testmodels",
105105
"test-ribasim-migration",
106106
{ task = "s3-download", args = [
@@ -120,14 +120,14 @@ upload-node-icons = "python utils/write_node_icons.py --upload"
120120
tests = { depends-on = ["lint", "test-ribasim-python", "test-ribasim-core"] }
121121
delwaq = { cmd = "pytest --basetemp=python/ribasim/ribasim/delwaq/model python/ribasim/tests/test_delwaq.py" }
122122
gen-delwaq = { cmd = "python python/ribasim/ribasim/delwaq/generate.py" }
123-
model-integration-test = { cmd = "julia --project=core --check-bounds=yes --eval 'using Pkg; Pkg.test(allow_reresolve=false, test_args=[\"integration\"])'", depends-on = [
123+
model-integration-test = { cmd = "julia --project=core --eval 'using Pkg; Pkg.test(allow_reresolve=false, test_args=[\"integration\"])'", depends-on = [
124124
{ task = "s3-download", args = [
125125
"hws_2025_4_0/",
126126
"hws/",
127127
] },
128128
] }
129129
# Codegen
130-
codegen = { cmd = "julia --project --check-bounds=yes utils/gen_python.jl && ruff format python/ribasim/ribasim/schemas.py python/ribasim/ribasim/validation.py", depends-on = [
130+
codegen = { cmd = "julia --project utils/gen_python.jl && ruff format python/ribasim/ribasim/schemas.py python/ribasim/ribasim/validation.py", depends-on = [
131131
"initialize-julia",
132132
], inputs = [
133133
"core",
@@ -157,14 +157,14 @@ test-ribasim-qgis = { cmd = "python ribasim_qgis/scripts/run_qgis_ui_tests.py",
157157
] }
158158
mypy-ribasim-qgis = "mypy ribasim_qgis"
159159
# Run
160-
ribasim-core = { cmd = "julia --project=core --check-bounds=yes -e 'using Ribasim; Ribasim.main(ARGS)'", depends-on = [
160+
ribasim-core = { cmd = "julia --project=core -e 'using Ribasim; Ribasim.main(ARGS)'", depends-on = [
161161
"initialize-julia",
162162
] }
163-
ribasim-core-testmodels = { cmd = "julia --project --check-bounds=yes utils/testmodelrun.jl", depends-on = [
163+
ribasim-core-testmodels = { cmd = "julia --project utils/testmodelrun.jl", depends-on = [
164164
"generate-testmodels",
165165
"initialize-julia",
166166
] }
167-
write-allocation-problems = { cmd = "julia --project --check-bounds=yes utils/write_allocation_problems.jl", depends-on = [
167+
write-allocation-problems = { cmd = "julia --project utils/write_allocation_problems.jl", depends-on = [
168168
"generate-testmodels",
169169
"initialize-julia",
170170
] }
@@ -213,7 +213,7 @@ depends-on = [
213213
]
214214

215215
[tasks.generate-sbom-ribasim-core]
216-
cmd = "julia --project --check-bounds=yes -- utils/generate-sbom.jl"
216+
cmd = "julia --project -- utils/generate-sbom.jl"
217217
depends-on = ["initialize-julia"]
218218
inputs = ["core/Project.toml"]
219219
outputs = ["Ribasim.spdx.json"]

0 commit comments

Comments
 (0)