Test replacement sopn matches filename

Author: VirginiaDooley

ynr/apps/official_documents/tests/example-file.pdf

@@ -2,3 +2,4 @@
 
 EXAMPLE_DOCX_FILENAME = abspath(join(dirname(__file__), "example-file.docx"))
 EXAMPLE_HTML_FILENAME = abspath(join(dirname(__file__), "example-file.html"))
+EXAMPLE_PDF_FILENAME = abspath(join(dirname(__file__), "example-file.pdf"))

ynr/apps/official_documents/tests/paths.py

@@ -17,6 +17,7 @@
 from official_documents.tests.paths import (
     EXAMPLE_DOCX_FILENAME,
     EXAMPLE_HTML_FILENAME,
+    EXAMPLE_PDF_FILENAME,
 )
 from sopn_parsing.tests import should_skip_conversion_tests
 from webtest import Upload
@@ -37,6 +38,7 @@ class TestModels(TestUserMixin, WebTest):
     example_image_filename = EXAMPLE_IMAGE_FILENAME
     example_docx_filename = EXAMPLE_DOCX_FILENAME
     example_html_filename = EXAMPLE_HTML_FILENAME
+    example_pdf_filename = EXAMPLE_PDF_FILENAME
 
     def setUp(self):
         gb_parties = PartySetFactory.create(slug="gb", name="Great Britain")
@@ -229,3 +231,124 @@ def test_jpg_form_validation(self):
             "File extension “jpg” is not allowed. Allowed extensions are: pdf, docx.",
             response.text,
         )
+
+    def test_filename_updated(self):
+        # # When a SoPN has already been uploaded, test the filename
+        # # is updated when a new SoPN is uploaded.
+        self.assertFalse(LoggedAction.objects.exists())
+        request = self.app.get(
+            self.ballot.get_absolute_url(),
+            user=self.user_who_can_upload_documents,
+        )
+
+        self.assertInHTML("Upload SOPN", request.text)
+
+        response = self.app.get(
+            reverse(
+                "upload_document_view",
+                kwargs={"ballot_paper_id": self.ballot.ballot_paper_id},
+            ),
+            user=self.user_who_can_upload_documents,
+        )
+        form = response.forms["document-upload-form"]
+        form["source_url"] = "http://example.org/foo"
+        with open(self.example_image_filename, "rb") as f:
+            form["uploaded_file"] = Upload("initial.pdf", f.read())
+
+        with patch(
+            "official_documents.views.extract_pages_for_ballot"
+        ) as extract_pages, patch(
+            "official_documents.views.extract_ballot_table"
+        ) as extract_tables, patch(
+            "official_documents.views.parse_raw_data_for_ballot"
+        ) as parse_tables:
+            response = form.submit()
+            self.assertEqual(response.status_code, 302)
+            extract_pages.assert_called_once()
+            extract_tables.assert_called_once()
+            parse_tables.assert_called_once()
+
+        ods = OfficialDocument.objects.all()
+        self.assertEqual(ods.count(), 1)
+        od = ods[0]
+        self.assertEqual(od.source_url, "http://example.org/foo")
+        self.assertEqual(
+            od.uploaded_file.name,
+            "official_documents/parl.dulwich-and-west-norwood.2015-05-07/initial.pdf",
+        )
+        self.assertEqual(
+            od.ballot.ballot_paper_id,
+            "parl.dulwich-and-west-norwood.2015-05-07",
+        )
+
+        # repeat the above with another file and check the filename is updated
+        # again
+        request = self.app.get(
+            self.ballot.get_absolute_url(),
+            user=self.user_who_can_upload_documents,
+        )
+
+        self.assertInHTML('"SOPN" uploaded.', request.text)
+        # at this stage we know the sopn has been uploaded. Now we need to
+        # check the filename is updated when a new SoPN is uploaded.
+
+        response = self.app.get(
+            reverse(
+                "ballot_paper_sopn",
+                kwargs={"ballot_id": self.ballot.ballot_paper_id},
+            ),
+            user=self.user_who_can_upload_documents,
+        )
+
+        self.assertInHTML("Update SOPN", response.text)
+
+        response = self.app.get(
+            reverse(
+                "upload_document_view",
+                kwargs={"ballot_paper_id": self.ballot.ballot_paper_id},
+            ),
+            user=self.user_who_can_upload_documents,
+        )
+
+        form = response.forms["document-upload-form"]
+        form["source_url"] = "http://example.org/bar"
+        with open(self.example_image_filename, "rb") as f:
+            form["uploaded_file"] = Upload("replacement.pdf", f.read())
+
+        with patch(
+            "official_documents.views.extract_pages_for_ballot"
+        ) as extract_pages, patch(
+            "official_documents.views.extract_ballot_table"
+        ) as extract_tables, patch(
+            "official_documents.views.parse_raw_data_for_ballot"
+        ) as parse_tables:
+            response = form.submit()
+            self.assertEqual(response.status_code, 302)
+            extract_pages.assert_called_once()
+            extract_tables.assert_called_once()
+            parse_tables.assert_called_once()
+
+        ods = OfficialDocument.objects.all()
+        self.assertEqual(ods.count(), 2)
+        od = ods[1]
+        self.assertEqual(od.source_url, "http://example.org/bar")
+        self.assertEqual(
+            od.uploaded_file.name,
+            "official_documents/parl.dulwich-and-west-norwood.2015-05-07/replacement.pdf",
+        )
+
+        self.assertEqual(
+            od.ballot.ballot_paper_id,
+            "parl.dulwich-and-west-norwood.2015-05-07",
+        )
+        response = self.app.get(
+            reverse(
+                "ballot_paper_sopn",
+                kwargs={"ballot_id": self.ballot.ballot_paper_id},
+            ),
+            user=self.user_who_can_upload_documents,
+        )
+        self.assertInHTML(
+            '<div class="pdf_container" id="sopn-parl.dulwich-and-west-norwood.2015-05-07">',
+            response.text,
+        )