Disable metrics collection if HEAP_ANALYTICS_ID not set

Author: marlonkeating

common/components/utils/heapApi.js

@@ -1,42 +1,44 @@
 // @flow
 
 export function loadHeap() {
-  window.heap = window.heap || [];
-  heap.load = function(e, t) {
-    window.heap.appid = e;
-    window.heap.config = t = t || {};
-    let r = document.createElement("script");
-    r.type = "text/javascript";
-    r.async = !0;
-    r.src = "https://cdn.heapanalytics.com/js/heap-" + e + ".js";
-    let a = document.getElementsByTagName("script")[0];
-    a.parentNode.insertBefore(r, a);
-    for (
-      let n = function(e) {
-          return function() {
-            heap.push([e].concat(Array.prototype.slice.call(arguments, 0)));
-          };
-        },
-        p = [
-          "addEventProperties",
-          "addUserProperties",
-          "clearEventProperties",
-          "identify",
-          "resetIdentity",
-          "removeEventProperty",
-          "setEventProperties",
-          "track",
-          "unsetEventProperty",
-        ],
-        o = 0;
-      o < p.length;
-      o++
-    )
-      heap[p[o]] = n(p[o]);
-  };
-  heap.load(window.HEAP_ANALYTICS_ID);
-  window.democracyLabEvents = { heapLoaded: true };
-  window.dispatchEvent(new Event("heapLoaded"));
+  if (window.HEAP_ANALYTICS_ID) {
+    window.heap = window.heap || [];
+    heap.load = function(e, t) {
+      window.heap.appid = e;
+      window.heap.config = t = t || {};
+      let r = document.createElement("script");
+      r.type = "text/javascript";
+      r.async = !0;
+      r.src = "https://cdn.heapanalytics.com/js/heap-" + e + ".js";
+      let a = document.getElementsByTagName("script")[0];
+      a.parentNode.insertBefore(r, a);
+      for (
+        let n = function(e) {
+            return function() {
+              heap.push([e].concat(Array.prototype.slice.call(arguments, 0)));
+            };
+          },
+          p = [
+            "addEventProperties",
+            "addUserProperties",
+            "clearEventProperties",
+            "identify",
+            "resetIdentity",
+            "removeEventProperty",
+            "setEventProperties",
+            "track",
+            "unsetEventProperty",
+          ],
+          o = 0;
+        o < p.length;
+        o++
+      )
+        heap[p[o]] = n(p[o]);
+    };
+    heap.load(window.HEAP_ANALYTICS_ID);
+    window.democracyLabEvents = { heapLoaded: true };
+    window.dispatchEvent(new Event("heapLoaded"));
+  }
 }
 
 loadHeap();

common/components/utils/metrics.js

@@ -21,9 +21,11 @@ type HeapInterface = {|
 |};
 
 function _logEvent(eventName: string, parameters: ?MetricsParameters): void {
-  Async.onEvent("heapLoaded", () => {
-    window.heap.track(eventName, parameters);
-  });
+  if (window.HEAP_ANALYTICS_ID) {
+    Async.onEvent("heapLoaded", () => {
+      window.heap.track(eventName, parameters);
+    });
+  }
 }
 
 class metrics {