About Us: Name new operations lead role as Salesforce Team Lead

Author: marlonkeating

common/components/componentsBySection/AboutUs/BioPersonData.jsx

@@ -1,6 +1,7 @@
 // @flow
 
 import type {VolunteerUserData, VolunteerDetailsAPIData} from "../../utils/ProjectAPIUtils.js";
+import type {Dictionary} from "../../types/Generics.jsx";
 
 export type BioPersonData = {|
   first_name: string,
@@ -12,16 +13,17 @@ export type BioPersonData = {|
   profile_id: ?number
 |};
 
-export function VolunteerUserDataToBioPersonData(v: VolunteerUserData, title: string, title_tag: ?string): BioPersonData {
-    return {
-      first_name: v.first_name,
-      last_name: v.last_name,
-      title: [title],
-      title_tag: title_tag,
-      user_thumbnail: v.user_thumbnail && v.user_thumbnail.publicUrl,
-      bio_text: v.about_me,
-      profile_id: v.id
-    };
+export function VolunteerUserDataToBioPersonData(v: VolunteerUserData, title: string, title_tag: ?string, nameOverrides: ?Dictionary<string>): BioPersonData {
+  const _title: string = nameOverrides && title_tag in nameOverrides ? nameOverrides[title_tag] : title;
+  return {
+    first_name: v.first_name,
+    last_name: v.last_name,
+    title: [_title],
+    title_tag: title_tag,
+    user_thumbnail: v.user_thumbnail && v.user_thumbnail.publicUrl,
+    bio_text: v.about_me,
+    profile_id: v.id
+  };
 }
 
 export function VolunteerDetailsAPIDataEqualsBioPersonData(v: VolunteerDetailsAPIData, b: BioPersonData): boolean {

common/components/componentsBySection/AboutUs/TeamSections.jsx

@@ -12,7 +12,8 @@ import {VolunteerDetailsAPIDataEqualsBioPersonData, VolunteerUserDataToBioPerson
 import GroupBy from "../../utils/groupBy.js";
 import BioModal from "./BioModal.jsx";
 import Sort from "../../utils/sort.js";
-import array from "../../utils/array";
+import array from "../../utils/array.js";
+import type {Dictionary} from "../../types/Generics.jsx";
 
 type Props = {|
   teamResponse: TeamAPIData
@@ -54,14 +55,18 @@ const SectionConfigs: $ReadOnlyArray<SectionConfig> = [
   }, {
     title: "Salesforce Dev/Admin",
     sectionRoleCategory: "Operations",
-    topRoles: []
+    topRoles: ["business-operations-lead"]
   }, {
     title: "Operations",
     sectionRoleCategory: "Business",
     topRoles: []
   }
 ];
 
+const roleNameOverride: Dictionary<string> = {
+  "business-operations-lead": "Salesforce Team Lead"
+};
+
 class TeamSections extends React.PureComponent<Props, State> {
   constructor(props: Props): void {
     super(props);
@@ -97,7 +102,7 @@ class TeamSections extends React.PureComponent<Props, State> {
         uniqueVolunteers,
         (pv: VolunteerDetailsAPIData) => pv.roleTag.subcategory,
         (pv: VolunteerDetailsAPIData) => {
-          return VolunteerUserDataToBioPersonData(pv.user, pv.roleTag.display_name, pv.roleTag.tag_name);
+          return VolunteerUserDataToBioPersonData(pv.user, pv.roleTag.display_name, pv.roleTag.tag_name, roleNameOverride);
         });
     }
 

common/fixtures/testdata.json

@@ -221,6 +221,7 @@ marketing-lead,Marketing Team Lead,,Role,Marketing,
 marketing,Marketing,,Role,Marketing,
 sales,Sales,,Role,Business,
 business-operations,Operations,,Role,Operations,
+business-operations-lead,Operations Lead,,Role,Operations,
 business-management,Management,,Role,Business,
 business-strategy,Strategy,,Role,Business,
 business-legal,Legal,,Role,Business,