Improved JSONata error handling

Author: jscottsf

dist/commands/tasks/meta/patch-resources.js

@@ -71,7 +71,21 @@ module.exports = ({
         });
         await utils.sleep();
         let res = await conns.web.app.service(servicePath).get(id);
-        const data = expr.evaluate(res) || {};
+        let data = {};
+        if (expr) try {
+          data = expr.evaluate(res);
+        } catch (err) {
+          if (err.message) {
+            output.push([{
+              text: 'Eval error',
+              tail: ':'
+            }, id]);
+            output.push(err.message);
+            break;
+          } else {
+            throw err;
+          }
+        }
 
         if (p.dry_run) {
           output.push([{

dist/commands/tasks/meta/pull-resources.js

@@ -74,7 +74,21 @@ module.exports = ({
         });
         await utils.sleep();
         const res = await conns.web.app.service(servicePath).get(item._id);
-        const data = expr ? expr.evaluate(res) : res;
+        let data = res;
+        if (expr) try {
+          data = expr.evaluate(res);
+        } catch (err) {
+          if (err.message) {
+            output.push([{
+              text: 'Eval error',
+              tail: ':'
+            }, fn]);
+            output.push(err.message);
+            break;
+          } else {
+            throw err;
+          }
+        }
 
         if (p.dry_run) {
           output.push([{

dist/lib/print.js

@@ -15,12 +15,15 @@ const {
   FeathersError
 } = require('@feathersjs/errors');
 
-function print(obj, p) {
+function print(obj, p = {}) {
   if (obj instanceof FeathersError) {
     console.log(chalk`{inverse  ERR! } ${obj.message}`);
     console.log(jsome.getColoredString(obj.toJSON()));
   } else if (obj instanceof Error) {
     console.log(chalk`{inverse  ERR! } ${obj.message}`);
+  } else if (typeof obj === 'object' && obj.stack && obj.code && obj.message) {
+    // JSONata evaluate errors
+    console.log(chalk`{inverse  ERR! } ${obj.message}`);
   } else if (Array.isArray(obj)) {
     obj.forEach(el => {
       if (Array.isArray(el)) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dendra-science/dendra-cli",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "Dendra command line interface tool.",
   "license": "BSD-2-Clause-FreeBSD",
   "author": "J. Scott Smith <scott@newleafsolutionsinc.com>",

src/commands/tasks/meta/patch-resources.js

@@ -67,7 +67,20 @@ module.exports = (
         await utils.sleep()
 
         let res = await conns.web.app.service(servicePath).get(id)
-        const data = expr.evaluate(res) || {}
+        let data = {}
+
+        if (expr)
+          try {
+            data = expr.evaluate(res)
+          } catch (err) {
+            if (err.message) {
+              output.push([{ text: 'Eval error', tail: ':' }, id])
+              output.push(err.message)
+              break
+            } else {
+              throw err
+            }
+          }
 
         if (p.dry_run) {
           output.push([{ text: 'Will patch', tail: ':' }, id])

src/commands/tasks/meta/pull-resources.js

@@ -68,7 +68,20 @@ module.exports = (
         await utils.sleep()
 
         const res = await conns.web.app.service(servicePath).get(item._id)
-        const data = expr ? expr.evaluate(res) : res
+        let data = res
+
+        if (expr)
+          try {
+            data = expr.evaluate(res)
+          } catch (err) {
+            if (err.message) {
+              output.push([{ text: 'Eval error', tail: ':' }, fn])
+              output.push(err.message)
+              break
+            } else {
+              throw err
+            }
+          }
 
         if (p.dry_run) {
           output.push([{ text: 'Will save', tail: ':' }, fn])

src/lib/print.js

@@ -10,12 +10,15 @@ const chalk = require('chalk')
 const jsome = require('jsome')
 const { FeathersError } = require('@feathersjs/errors')
 
-function print(obj, p) {
+function print(obj, p = {}) {
   if (obj instanceof FeathersError) {
     console.log(chalk`{inverse  ERR! } ${obj.message}`)
     console.log(jsome.getColoredString(obj.toJSON()))
   } else if (obj instanceof Error) {
     console.log(chalk`{inverse  ERR! } ${obj.message}`)
+  } else if (typeof obj === 'object' && obj.stack && obj.code && obj.message) {
+    // JSONata evaluate errors
+    console.log(chalk`{inverse  ERR! } ${obj.message}`)
   } else if (Array.isArray(obj)) {
     obj.forEach(el => {
       if (Array.isArray(el)) {