Switch to Advanture NBT (#2753)

* Add `adventure-nbt` dependency

* Add NMS conversion utils

* Initial `ItemRawNBT` changes

* convertObjectToNbt - cleaner handling with switch

* convertObjectToNbt - take ObjectTag input

* ItemHelper update

* ItemRawNBT: long array tags

* ItemRawNBT: 1.21 mixed type lists

* EntityHelper update

* Update some more ItemRawNBT usages

* Update ItemCustomData.java

* SNBT parsing

* WorldHelper update

* Schematic loading/saving

* CustomNBT update

* ImprovedOfflinePlayer update

* PacketHelper update

* ItemScriptHelper, Item properties - update

* Update BukkitBinaryTagExtensions.java

* Update ItemTag.java

* Remove JNBT

* Fix relocations (don't relocate adventure text)

* Unwrap lists when loading from binary

* `NBTAdapter`: rename compound tag convert methods

* `NBTAdapter`: dedicated list conversion methods

* Cleanup `snbt_to_map` debug

* Final fixes

* Cleanup

Author: tal5

dist/pom.xml

@@ -137,6 +137,12 @@
                                         <include>**</include>
                                     </includes>
                                 </filter>
+                                <filter>
+                                    <artifact>net.kyori:adventure-nbt</artifact>
+                                    <includes>
+                                        <include>**</include>
+                                    </includes>
+                                </filter>
                             </filters>
                             <relocations>
                                 <relocation>
@@ -159,6 +165,14 @@
                                     <pattern>org.apache</pattern>
                                     <shadedPattern>com.denizenscript.shaded.org.apache</shadedPattern>
                                 </relocation>
+                                <relocation>
+                                    <pattern>net.kyori.option</pattern>
+                                    <shadedPattern>com.denizenscript.shaded.net.kyori.option</shadedPattern>
+                                </relocation>
+                                <relocation>
+                                    <pattern>net.kyori.adventure.nbt</pattern>
+                                    <shadedPattern>com.denizenscript.shaded.net.adventure.nbt</shadedPattern>
+                                </relocation>
                             </relocations>
                         </configuration>
                     </execution>

plugin/pom.xml

@@ -67,6 +67,11 @@
             <scope>system</scope>
             <systemPath>${project.basedir}/lib/Vault.jar</systemPath>
         </dependency>
+        <dependency>
+            <groupId>net.kyori</groupId>
+            <artifactId>adventure-nbt</artifactId>
+            <version>4.23.0</version>
+        </dependency>
         <!-- Contained by Spigot-server -->
         <dependency>
             <groupId>it.unimi.dsi</groupId>

plugin/src/main/java/com/denizenscript/denizen/nms/NMSHandler.java

@@ -3,8 +3,6 @@
 import com.denizenscript.denizen.nms.abstracts.*;
 import com.denizenscript.denizen.nms.interfaces.*;
 import com.denizenscript.denizen.nms.util.PlayerProfile;
-import com.denizenscript.denizen.nms.util.jnbt.CompoundTag;
-import com.denizenscript.denizen.nms.util.jnbt.Tag;
 import org.bukkit.Bukkit;
 import org.bukkit.Location;
 import org.bukkit.NamespacedKey;
@@ -19,7 +17,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Map;
 import java.util.UUID;
 
 public abstract class NMSHandler {
@@ -123,12 +120,6 @@ public BiomeNMS getBiomeAt(Block block) {
 
     public abstract double[] getRecentTps();
 
-    public abstract CompoundTag createCompoundTag(Map<String, Tag> value);
-
-    public CompoundTag parseSNBT(String snbt) {
-        throw new UnsupportedOperationException();
-    }
-
     public abstract String getTitle(Inventory inventory);
 
     public void setInventoryTitle(InventoryView view, String title) {