Change 'COMMIT_MSG_LINES' to 'commit_msg_lines'

PR sysprog21#209's functionality was broken due to changes introduced in PR sysprog21#214,
specifically in commit '4a8d8b5', where some occurrences of
'COMMIT_MSG_LINES' were replaced with 'commit_msg_lines' without
updating all relevant functions.

This commit fixes the issue by replacing all instances of
'COMMIT_MSG_LINES' with 'commit_msg_lines', ensuring consistency and
restoring the functionality introduced in PR sysprog21#209.

Change-Id: I0c93617be83c5f24b1e17678566883c0481ddc48

Author: Dennis40816

scripts/commit-msg.hook

@@ -6,7 +6,7 @@
 # https://github.com/tommarshall/git-good-commit
 
 COMMIT_MSG_FILE="$1"
-COMMIT_MSG_LINES=
+commit_msg_lines=
 HOOK_EDITOR=
 SKIP_DISPLAY_WARNINGS=0
 WARNINGS=
@@ -69,7 +69,7 @@ display_warnings() {
   fi
 
   for i in "${!WARNINGS[@]}"; do
-    printf "%-74s ${WHITE}%s${NC}\n" "${COMMIT_MSG_LINES[$(($i-1))]}" "[line ${i}]"
+    printf "%-74s ${WHITE}%s${NC}\n" "${commit_msg_lines[$(($i-1))]}" "[line ${i}]"
     IFS=';' read -ra WARNINGS_ARRAY <<< "${WARNINGS[$i]}"
     for ERROR in "${WARNINGS_ARRAY[@]}"; do
       echo -e " ${YELLOW}- ${ERROR}${NC}"
@@ -86,7 +86,7 @@ EOF
 # Read the contents of the commit msg into an array of lines.
 read_commit_message() {
   # reset commit_msg_lines
-  COMMIT_MSG_LINES=()
+  commit_msg_lines=()
 
   # read commit message into lines array
   while IFS= read -r; do
@@ -98,7 +98,7 @@ read_commit_message() {
 
     # ignore comments
     [[ $REPLY =~ ^# ]]
-    test $? -eq 0 || COMMIT_MSG_LINES+=("$REPLY")
+    test $? -eq 0 || commit_msg_lines+=("$REPLY")
 
     [[ $REPLY =~ "# ------------------------ >8 ------------------------" ]]
     break
@@ -241,10 +241,10 @@ validate_commit_message() {
   WARNINGS=()
 
   # capture the subject, and remove the 'squash! ' prefix if present
-  COMMIT_SUBJECT=${COMMIT_MSG_LINES[0]/#squash! /}
+  COMMIT_SUBJECT=${commit_msg_lines[0]/#squash! /}
 
   # if the commit is empty there's nothing to validate, we can return here
-  COMMIT_MSG_STR="${COMMIT_MSG_LINES[*]}"
+  COMMIT_MSG_STR="${commit_msg_lines[*]}"
   test -z "${COMMIT_MSG_STR[*]// }" && return;
 
   # if the commit subject starts with 'fixup! ' there's nothing to validate, we can return here
@@ -265,7 +265,7 @@ validate_commit_message() {
       echo "Aspell not installed - unable to check spelling"
   else
       LINE_NUMBER=1
-      MISSPELLED_WORDS=$(echo "$COMMIT_MSG_LINES[LINE_NUMBER]" | $ASPELL --lang=en --list --home-dir=scripts --personal=aspell-pws)
+      MISSPELLED_WORDS=$(echo "$commit_msg_lines[LINE_NUMBER]" | $ASPELL --lang=en --list --home-dir=scripts --personal=aspell-pws)
       if [ -n "$MISSPELLED_WORDS" ]; then
         add_warning LINE_NUMBER "Possible misspelled word(s): $MISSPELLED_WORDS"
       fi
@@ -274,7 +274,7 @@ validate_commit_message() {
   # 1. Separate subject from body with a blank line
   # ------------------------------------------------------------------------------
 
-  test ${#COMMIT_MSG_LINES[@]} -lt 1 || test -z "${COMMIT_MSG_LINES[1]}"
+  test ${#commit_msg_lines[@]} -lt 1 || test -z "${commit_msg_lines[1]}"
   test $? -eq 0 || add_warning 2 "Separate subject from body with a blank line"
 
   # 2. Limit the subject line to configured number of characters