fix: address code review findings - XSS, URLs, schemas, validation

cj-vana · cj-vana · commit e8e868303255 · 2026-01-03T10:18:09.000-07:00
🤖 Committed by claude-swarm
diff --git a/src/app/about/page.tsx b/src/app/about/page.tsx
@@ -2,6 +2,7 @@ import type { Metadata } from 'next';
 import Link from 'next/link';
 import JsonLd from '@/components/JsonLd';
 import { generateBreadcrumbSchema } from '@/lib/schemas/breadcrumb';
+import { BASE_URL } from '@/lib/constants';
 
 export const metadata: Metadata = {
   title: 'About',
@@ -14,13 +15,13 @@ export const metadata: Metadata = {
     title: 'About Denver MeshCore',
     description:
       "Learn about MeshCore technology and the Denver mesh networking community building Colorado's decentralized communication network.",
-    url: 'https://denvermc.com/about',
+    url: `${BASE_URL}/about`,
   },
 };
 
 const breadcrumbData = generateBreadcrumbSchema([
-  { name: 'Home', url: 'https://denvermc.com' },
-  { name: 'About', url: 'https://denvermc.com/about' },
+  { name: 'Home', url: BASE_URL },
+  { name: 'About', url: `${BASE_URL}/about` },
 ]);
 
 export default function AboutPage() {
diff --git a/src/app/blog/[slug]/page.tsx b/src/app/blog/[slug]/page.tsx
@@ -9,6 +9,7 @@ import { MDXRemote } from 'next-mdx-remote/rsc';
 import { useMDXComponents } from '../../../../mdx-components';
 import remarkGfm from 'remark-gfm';
 import rehypeSlug from 'rehype-slug';
+import { BASE_URL } from '@/lib/constants';
 
 interface BlogPostPageProps {
   params: Promise<{
@@ -42,8 +43,7 @@ export async function generateMetadata({ params }: BlogPostPageProps): Promise<M
   }
 
   const { frontmatter } = post;
-  const baseUrl = 'https://denvermc.org';
-  const postUrl = `${baseUrl}/blog/${slug}`;
+  const postUrl = `${BASE_URL}/blog/${slug}`;
 
   return {
     title: frontmatter.title,
@@ -66,13 +66,13 @@ export async function generateMetadata({ params }: BlogPostPageProps): Promise<M
             {
               url: frontmatter.image.startsWith('http')
                 ? frontmatter.image
-                : `${baseUrl}${frontmatter.image}`,
+                : `${BASE_URL}${frontmatter.image}`,
               alt: frontmatter.imageAlt || frontmatter.title,
             },
           ]
         : [
             {
-              url: `${baseUrl}/logo-512.png`,
+              url: `${BASE_URL}/logo-512.png`,
               width: 512,
               height: 512,
               alt: 'Denver MeshCore Logo',
@@ -86,8 +86,8 @@ export async function generateMetadata({ params }: BlogPostPageProps): Promise<M
       title: frontmatter.title,
       description: frontmatter.description,
       images: frontmatter.image
-        ? [frontmatter.image.startsWith('http') ? frontmatter.image : `${baseUrl}${frontmatter.image}`]
-        : [`${baseUrl}/logo-512.png`],
+        ? [frontmatter.image.startsWith('http') ? frontmatter.image : `${BASE_URL}${frontmatter.image}`]
+        : [`${BASE_URL}/logo-512.png`],
     },
   };
 }
@@ -116,9 +116,9 @@ export default async function BlogPostPage({ params }: BlogPostPageProps) {
   });
 
   const breadcrumbSchema = generateBreadcrumbSchema([
-    { name: 'Home', url: 'https://denvermc.org' },
-    { name: 'Blog', url: 'https://denvermc.org/blog' },
-    { name: frontmatter.title, url: `https://denvermc.org/blog/${slug}` },
+    { name: 'Home', url: BASE_URL },
+    { name: 'Blog', url: `${BASE_URL}/blog` },
+    { name: frontmatter.title, url: `${BASE_URL}/blog/${slug}` },
   ]);
 
   // Get related posts based on shared tags
diff --git a/src/app/blog/layout.tsx b/src/app/blog/layout.tsx
@@ -3,6 +3,7 @@ import Link from 'next/link';
 import { getAllTags } from '@/lib/blog';
 import JsonLd from '@/components/JsonLd';
 import { generateBreadcrumbSchema } from '@/lib/schemas/breadcrumb';
+import { BASE_URL } from '@/lib/constants';
 
 export const metadata: Metadata = {
   title: {
@@ -18,7 +19,7 @@ export const metadata: Metadata = {
     title: 'Denver MeshCore Blog',
     description:
       'News, tutorials, and updates from the Denver MeshCore community. Learn about mesh networking and off-grid communication.',
-    url: 'https://denvermc.com/blog',
+    url: `${BASE_URL}/blog`,
     type: 'website',
   },
   twitter: {
@@ -30,8 +31,8 @@ export const metadata: Metadata = {
 };
 
 const breadcrumbData = generateBreadcrumbSchema([
-  { name: 'Home', url: 'https://denvermc.com' },
-  { name: 'Blog', url: 'https://denvermc.com/blog' },
+  { name: 'Home', url: BASE_URL },
+  { name: 'Blog', url: `${BASE_URL}/blog` },
 ]);
 
 interface BlogLayoutProps {
diff --git a/src/app/layout.tsx b/src/app/layout.tsx
@@ -8,6 +8,7 @@ import JsonLd, {
   websiteSchema,
   communityOrganizationSchema,
 } from "@/components/JsonLd";
+import { BASE_URL } from "@/lib/constants";
 
 const inter = Inter({
   variable: "--font-inter",
@@ -22,7 +23,7 @@ const geistMono = Geist_Mono({
 });
 
 export const metadata: Metadata = {
-  metadataBase: new URL("https://denvermc.com"),
+  metadataBase: new URL(BASE_URL),
   title: {
     default: "Denver MeshCore Community Platform",
     template: "%s | Denver MeshCore",
@@ -70,7 +71,7 @@ export const metadata: Metadata = {
   openGraph: {
     type: "website",
     locale: "en_US",
-    url: "https://denvermc.com",
+    url: BASE_URL,
     siteName: "Denver MeshCore",
     title: "Denver MeshCore Community Platform",
     description:
diff --git a/src/app/locations/[city]/page.tsx b/src/app/locations/[city]/page.tsx
@@ -13,6 +13,7 @@ import {
   getCoverageBadgeColor,
   getCoverageDescription,
 } from '@/lib/utils/coverage';
+import { BASE_URL } from '@/lib/constants';
 
 interface CityPageProps {
   params: Promise<{ city: string }>;
@@ -55,7 +56,7 @@ export async function generateMetadata({ params }: CityPageProps): Promise<Metad
     openGraph: {
       title: `${location.name} Mesh Network | Denver MeshCore`,
       description: location.description,
-      url: `https://denvermc.com/locations/${location.slug}`,
+      url: `${BASE_URL}/locations/${location.slug}`,
       type: 'website',
     },
     twitter: {
@@ -117,17 +118,17 @@ export default async function CityPage({ params }: CityPageProps) {
   }
 
   const breadcrumbData = generateBreadcrumbSchema([
-    { name: 'Home', url: 'https://denvermc.com' },
-    { name: 'Locations', url: 'https://denvermc.com/locations' },
-    { name: location.name, url: `https://denvermc.com/locations/${location.slug}` },
+    { name: 'Home', url: BASE_URL },
+    { name: 'Locations', url: `${BASE_URL}/locations` },
+    { name: location.name, url: `${BASE_URL}/locations/${location.slug}` },
   ]);
 
   const pageSchema = {
     '@context': 'https://schema.org',
     '@type': 'Place',
     name: `${location.name} Mesh Network`,
     description: location.description,
-    url: `https://denvermc.com/locations/${location.slug}`,
+    url: `${BASE_URL}/locations/${location.slug}`,
     geo: {
       '@type': 'GeoCoordinates',
       latitude: location.coordinates.lat,
diff --git a/src/app/locations/page.tsx b/src/app/locations/page.tsx
@@ -4,6 +4,7 @@ import JsonLd from '@/components/JsonLd';
 import { generateBreadcrumbSchema } from '@/lib/schemas/breadcrumb';
 import { COLORADO_LOCATIONS } from '@/lib/data/locations';
 import { getCoverageLabel, getCoverageBadgeColor, getCoverageColor } from '@/lib/utils/coverage';
+import { BASE_URL } from '@/lib/constants';
 
 export const metadata: Metadata = {
   title: 'Colorado Mesh Network Coverage | Front Range Cities',
@@ -30,7 +31,7 @@ export const metadata: Metadata = {
     title: 'Colorado Mesh Network Coverage | Denver MeshCore',
     description:
       'Explore MeshCore coverage across the Colorado Front Range. Find nodes in Denver, Boulder, Colorado Springs, and more.',
-    url: 'https://denvermc.com/locations',
+    url: `${BASE_URL}/locations`,
     type: 'website',
   },
   twitter: {
@@ -42,8 +43,8 @@ export const metadata: Metadata = {
 };
 
 const breadcrumbData = generateBreadcrumbSchema([
-  { name: 'Home', url: 'https://denvermc.com' },
-  { name: 'Locations', url: 'https://denvermc.com/locations' },
+  { name: 'Home', url: BASE_URL },
+  { name: 'Locations', url: `${BASE_URL}/locations` },
 ]);
 
 const pageSchema = {
@@ -52,19 +53,19 @@ const pageSchema = {
   name: 'Colorado Mesh Network Coverage',
   description:
     'Explore Colorado mesh network coverage across the Front Range. Find MeshCore nodes in Denver, Boulder, Colorado Springs, and other Front Range cities.',
-  url: 'https://denvermc.com/locations',
+  url: `${BASE_URL}/locations`,
   publisher: {
     '@type': 'Organization',
     name: 'Denver MeshCore',
-    url: 'https://denvermc.com',
+    url: BASE_URL,
   },
   mainEntity: {
     '@type': 'ItemList',
     itemListElement: COLORADO_LOCATIONS.map((location, index) => ({
       '@type': 'ListItem',
       position: index + 1,
       name: `${location.name} Mesh Network`,
-      url: `https://denvermc.com/locations/${location.slug}`,
+      url: `${BASE_URL}/locations/${location.slug}`,
     })),
   },
 };
diff --git a/src/app/map/page.tsx b/src/app/map/page.tsx
@@ -3,6 +3,7 @@ import Link from 'next/link';
 import { NetworkMapWrapper } from '@/components';
 import JsonLd from '@/components/JsonLd';
 import { generateBreadcrumbSchema } from '@/lib/schemas/breadcrumb';
+import { BASE_URL } from '@/lib/constants';
 
 // Force dynamic rendering to prevent stale cache issues on Netlify
 export const dynamic = 'force-dynamic';
@@ -30,13 +31,13 @@ export const metadata: Metadata = {
     title: 'Network Map | Denver MeshCore',
     description:
       'Interactive map of Denver MeshCore network nodes. View node locations and coverage areas across Colorado.',
-    url: 'https://denvermc.com/map',
+    url: `${BASE_URL}/map`,
   },
 };
 
 const breadcrumbData = generateBreadcrumbSchema([
-  { name: 'Home', url: 'https://denvermc.com' },
-  { name: 'Network Map', url: 'https://denvermc.com/map' },
+  { name: 'Home', url: BASE_URL },
+  { name: 'Network Map', url: `${BASE_URL}/map` },
 ]);
 
 export default function MapPage() {
diff --git a/src/app/page.tsx b/src/app/page.tsx
@@ -2,9 +2,10 @@ import Link from 'next/link';
 import { StatsSection } from '@/components';
 import JsonLd from '@/components/JsonLd';
 import { generateBreadcrumbSchema } from '@/lib/schemas/breadcrumb';
+import { BASE_URL } from '@/lib/constants';
 
 const breadcrumbData = generateBreadcrumbSchema([
-  { name: 'Home', url: 'https://denvermc.com' },
+  { name: 'Home', url: BASE_URL },
 ]);
 
 export default function Home() {
diff --git a/src/lib/constants.ts b/src/lib/constants.ts
@@ -6,6 +6,7 @@
 // Site Information
 // =============================================================================
 
+export const BASE_URL = 'https://denvermc.com';
 export const SITE_NAME = 'Denver MeshCore';
 export const SITE_TAGLINE = 'Colorado\'s decentralized mesh network community';
 export const SITE_DESCRIPTION = 'Join Colorado\'s growing mesh network community. Connect with fellow mesh enthusiasts, share knowledge, and help build resilient off-grid communication infrastructure.';
diff --git a/src/lib/schemas/blog.ts b/src/lib/schemas/blog.ts
@@ -1,4 +1,5 @@
 import type { BlogPostFrontmatter } from '../blog';
+import { BASE_URL } from '../constants';
 
 interface BlogPostingSchemaOptions {
   slug: string;
@@ -17,7 +18,7 @@ export function generateBlogPostingSchema({
   frontmatter,
   readingTime,
   wordCount,
-  baseUrl = 'https://denvermc.org',
+  baseUrl = BASE_URL,
 }: BlogPostingSchemaOptions) {
   const postUrl = `${baseUrl}/blog/${slug}`;
 
@@ -73,7 +74,7 @@ export function generateBlogPostingSchema({
  * Generate JSON-LD Blog schema for the blog listing page
  * @see https://schema.org/Blog
  */
-export function generateBlogSchema(baseUrl = 'https://denvermc.org') {
+export function generateBlogSchema(baseUrl = BASE_URL) {
   return {
     '@context': 'https://schema.org',
     '@type': 'Blog',
@@ -99,7 +100,7 @@ export function generateArticleSchema({
   frontmatter,
   readingTime,
   wordCount,
-  baseUrl = 'https://denvermc.org',
+  baseUrl = BASE_URL,
 }: BlogPostingSchemaOptions) {
   const schema = generateBlogPostingSchema({
     slug,
diff --git a/src/lib/schemas/location.ts b/src/lib/schemas/location.ts
@@ -1,4 +1,5 @@
 import type { Location } from '../data/locations';
+import { BASE_URL } from '../constants';
 
 interface LocalBusinessOptions {
   /** Business name (defaults to "Denver MeshCore") */
@@ -34,9 +35,9 @@ export function generateLocalBusinessSchema(
   const {
     name = 'Denver MeshCore',
     description = `${name} provides decentralized mesh networking infrastructure and community support in ${location.name}, ${location.state}. Join Colorado's growing off-grid communication network.`,
-    url = 'https://denvermc.org',
-    logo = 'https://denvermc.org/logo.png',
-    email = 'hello@denvermc.org',
+    url = BASE_URL,
+    logo = `${BASE_URL}/logo.png`,
+    email = 'hello@denvermc.com',
     businessType = 'Organization',
     sameAs = [
       'https://discord.gg/QpaW8FTTCE',
@@ -98,7 +99,7 @@ export function generatePlaceSchema(
 ) {
   const {
     description = location.description,
-    url = `https://denvermc.org/locations/${location.slug}`,
+    url = `${BASE_URL}/locations/${location.slug}`,
     images = [],
   } = options;
 
@@ -158,7 +159,7 @@ export function generateServiceAreaSchema(
     provider: {
       '@type': 'Organization',
       name: providerName,
-      url: 'https://denvermc.org',
+      url: BASE_URL,
     },
     areaServed: locations.map((location) => ({
       '@type': 'City',
