Conversation
Signed-off-by: nscuro <nscuro@protonmail.com>
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Alpine framework from version 3.5.1 to 3.6.0 and adapts code to accommodate API changes introduced in the new version.
Changes:
- Bumped Alpine parent version from 3.5.1 to 3.6.0 in pom.xml
- Updated NvdMirrorServlet to use the new Alpine 3.6.0 API (replaced
setDirectory()andsetAbsolute()calls withsetDirectoryPath()) - Reordered imports to follow standard conventions (jakarta imports before org imports)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updates Alpine parent version from 3.5.1 to 3.6.0 |
| src/main/java/org/dependencytrack/servlets/NvdMirrorServlet.java | Adapts to Alpine 3.6.0 API changes by using new setDirectoryPath() method instead of setDirectory() + setAbsolute(), and reorders imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Description
Bumps Alpine to 3.6.0.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly