refactor: Changed method parameter types from concrete collections to interfaces for improved flexibility

- Changed method parameters in TemplateReader, NodeRenderer, and Drawer from List<T> to IReadOnlyList<T> or IEnumerable<T>
- Made methods more generic and reduced dependencies on specific collection implementations
- Simplified the DrawListAsync method by directly using the incoming List<int> parameter
- Changed the DrawAsync and RegisterFunctions methods to static

Author: Yushu2606

src/Render/Drawer.cs

@@ -8,12 +8,12 @@ namespace Limekuma.Render;
 
 public sealed class Drawer
 {
-    public async Task<Image> DrawBestsAsync(CommonUser user, IList<CommonRecord> ever,
-        IList<CommonRecord> current, int everTotal, int currentTotal, string? condition, string prober, IList<string> tags) =>
+    public async Task<Image> DrawBestsAsync(CommonUser user, IReadOnlyList<CommonRecord> ever,
+        IReadOnlyList<CommonRecord> current, int everTotal, int currentTotal, string? condition, string prober, IEnumerable<string> tags) =>
         await DrawBestsAsync(user, ever, current, everTotal, currentTotal, condition, prober, tags, "./Resources/Layouts/bests.xml");
 
-    public async Task<Image> DrawBestsAsync(CommonUser user, IList<CommonRecord> ever,
-        IList<CommonRecord> current, int everTotal, int currentTotal, string? condition, string prober, IList<string> tags, string xmlPath)
+    public async Task<Image> DrawBestsAsync(CommonUser user, IReadOnlyList<CommonRecord> ever,
+        IReadOnlyList<CommonRecord> current, int everTotal, int currentTotal, string? condition, string prober, IEnumerable<string> tags, string xmlPath)
     {
         int everMax = ever.Count > 0 ? ever[0].DXRating : 0;
         int everMin = ever.Count > 0 ? ever[^1].DXRating : 0;
@@ -39,14 +39,13 @@ public async Task<Image> DrawBestsAsync(CommonUser user, IList<CommonRecord> eve
         return await DrawAsync(scope, xmlPath);
     }
 
-    public async Task<Image> DrawListAsync(CommonUser user, IList<CommonRecord> records, int page, int total,
-        IList<int> counts, int startIndex, string condition, string prober, IList<string> tags) =>
+    public async Task<Image> DrawListAsync(CommonUser user, IReadOnlyList<CommonRecord> records, int page, int total,
+        List<int> counts, int startIndex, string condition, string prober, IEnumerable<string> tags) =>
         await DrawListAsync(user, records, page, total, counts, startIndex, condition, prober, tags, "./Resources/Layouts/list.xml");
 
-    public async Task<Image> DrawListAsync(CommonUser user, IList<CommonRecord> records, int page, int total,
-        IList<int> counts, int startIndex, string condition, string prober, IList<string> tags, string xmlPath)
+    public async Task<Image> DrawListAsync(CommonUser user, IReadOnlyList<CommonRecord> records, int page, int total,
+        List<int> counts, int startIndex, string condition, string prober, IEnumerable<string> tags, string xmlPath)
     {
-        List<int> countList = [.. counts];
         int totalCount = counts.Count > 0 ? counts[^1] : 0;
         bool mayMask = records.Any(r => r.DXScore is 0 && (r.DXStar > 0 || r.Rank > Ranks.A));
         Dictionary<string, object?> scope = new(StringComparer.OrdinalIgnoreCase)
@@ -55,8 +54,8 @@ public async Task<Image> DrawListAsync(CommonUser user, IList<CommonRecord> reco
             ["pageRecords"] = records,
             ["pageNumber"] = page,
             ["totalPages"] = total,
-            ["rankCounts"] = countList[..7],
-            ["comboCounts"] = countList[7..^1],
+            ["rankCounts"] = counts[..7],
+            ["comboCounts"] = counts[7..^1],
             ["totalCount"] = totalCount,
             ["startIndex"] = startIndex,
             ["condition"] = condition,
@@ -67,7 +66,7 @@ public async Task<Image> DrawListAsync(CommonUser user, IList<CommonRecord> reco
         return await DrawAsync(scope, xmlPath);
     }
 
-    private async Task<Image> DrawAsync(IDictionary<string, object?> scope, string xmlPath)
+    private static async Task<Image> DrawAsync(IDictionary<string, object?> scope, string xmlPath)
     {
         AsyncNCalcEngine expr = new();
         RegisterFunctions(expr);
@@ -77,7 +76,7 @@ private async Task<Image> DrawAsync(IDictionary<string, object?> scope, string x
         return NodeRenderer.Render((CanvasNode)tree, assets, assets);
     }
 
-    private void RegisterFunctions(AsyncNCalcEngine expr)
+    private static void RegisterFunctions(AsyncNCalcEngine expr)
     {
         expr.RegisterFunction("ToString", (object x) => Convert.ToString(x));
         expr.RegisterFunction("Count", (IList x) => x.Count);

src/Render/NodeRenderer.Layout.cs

@@ -13,7 +13,7 @@ explicitSize is { } value
                 ? desired
                 : fallback;
 
-    private static List<List<(Node Node, Size Size)>> ResolveStackLines(List<(Node Node, Size Size)> items, bool isRow,
+    private static List<List<(Node Node, Size Size)>> ResolveStackLines(IEnumerable<(Node Node, Size Size)> items, bool isRow,
         bool wrap, float spacing, float containerMain)
     {
         List<List<(Node Node, Size Size)>> lines = [];
@@ -43,11 +43,11 @@ explicitSize is { } value
         return lines;
     }
 
-    private static List<(float Main, int Cross)> ResolveStackLineSizes(List<List<(Node Node, Size Size)>> lines, bool isRow,
+    private static List<(float Main, int Cross)> ResolveStackLineSizes(IEnumerable<IReadOnlyList<(Node Node, Size Size)>> lines, bool isRow,
         float spacing)
     {
         List<(float Main, int Cross)> lineSizes = [];
-        foreach (List<(Node Node, Size Size)> line in lines)
+        foreach (IReadOnlyList<(Node Node, Size Size)> line in lines)
         {
             float lineMain = line.Sum(i => isRow ? i.Size.Width : i.Size.Height);
             if (line.Count > 1)

src/Render/TemplateReader.NodeParsing.cs

@@ -259,7 +259,7 @@ private async Task<List<Node>> ParseChildrenAsync(XElement element, object? scop
         return children;
     }
 
-    private async Task<(Node Node, int LastConsumedIndex)> ParseConditionalChainAsync(IReadOnlyList<XElement> siblings,
+    private async Task<(Node Node, int LastConsumedIndex)> ParseConditionalChainAsync(List<XElement> siblings,
         int index, object? scope)
     {
         XElement ifElement = siblings[index];
@@ -400,7 +400,7 @@ private static InvalidOperationException BuildInvalidForItemsException(string ex
         return result;
     }
 
-    private static void CopyParentScope(object? parent, IDictionary<string, object?> target)
+    private static void CopyParentScope(object? parent, Dictionary<string, object?> target)
     {
         if (parent is not IDictionary dictionary)
         {