Fix syncing issues for late-joiner by using OnDeserialization

Author: DerpyNewbie

Packages/dev.derpynewbie.common/Runtime/UniUI/UniDropdownSync.cs

@@ -12,39 +12,35 @@ public class UniDropdownSync : UniUI
         [SerializeField] [NewbieInject(SearchScope.Parents)]
         private TMP_Dropdown dropdown;
 
-        [UdonSynced] [FieldChangeCallback(nameof(SyncedValue))]
+        [UdonSynced]
         private int _syncedValue;
 
         private bool _inSyncedChangeContext;
 
-        public int SyncedValue
-        {
-            get => _syncedValue;
-            set
-            {
-                _syncedValue = value;
-                if (_inSyncedChangeContext) return;
-
-                _inSyncedChangeContext = true;
-                dropdown.value = value;
-                dropdown.RefreshShownValue();
-                _inSyncedChangeContext = false;
-            }
-        }
-
         private void Start()
         {
+            // serialize the initial value when instance master has first joined
             if (!Networking.IsMaster) return;
             _syncedValue = dropdown.value;
             RequestSerialization();
         }
 
+        public override void OnDeserialization()
+        {
+            // apply deserialized values to UI
+            _inSyncedChangeContext = true;
+            dropdown.value = _syncedValue;
+            dropdown.RefreshShownValue();
+            _inSyncedChangeContext = false;
+        }
+
         public override void OnUniUIUpdate()
         {
-            if (_inSyncedChangeContext || dropdown.value == SyncedValue) return;
+            // don't resync if the event was called by OnDeserialization change
+            if (_inSyncedChangeContext) return;
 
-            SyncedValue = dropdown.value;
-            Networking.SetOwner(Networking.LocalPlayer, gameObject);
+            _syncedValue = dropdown.value;
+            if (!Networking.IsOwner(gameObject)) Networking.SetOwner(Networking.LocalPlayer, gameObject);
             RequestSerialization();
         }
     }

Packages/dev.derpynewbie.common/Runtime/UniUI/UniSliderSync.cs

@@ -12,38 +12,34 @@ public class UniSliderSync : UniUI
         [SerializeField] [NewbieInject(SearchScope.Parents)]
         private Slider slider;
 
-        [UdonSynced] [FieldChangeCallback(nameof(SyncedValue))]
+        [UdonSynced]
         private float _syncedValue;
 
         private bool _inSyncedChangeContext;
 
-        public float SyncedValue
-        {
-            get => _syncedValue;
-            set
-            {
-                _syncedValue = value;
-                if (_inSyncedChangeContext) return;
-
-                _inSyncedChangeContext = true;
-                slider.value = value;
-                _inSyncedChangeContext = false;
-            }
-        }
-
         private void Start()
         {
+            // serialize the initial value when instance master has first joined
             if (!Networking.IsMaster) return;
             _syncedValue = slider.value;
             RequestSerialization();
         }
 
+        public override void OnDeserialization()
+        {
+            // apply deserialized values to UI
+            _inSyncedChangeContext = true;
+            slider.value = _syncedValue;
+            _inSyncedChangeContext = false;
+        }
+
         public override void OnUniUIUpdate()
         {
-            if (_inSyncedChangeContext || Mathf.Approximately(slider.value, SyncedValue)) return;
+            // don't resync if the event was called by OnDeserialization change
+            if (_inSyncedChangeContext) return;
 
-            SyncedValue = slider.value;
-            Networking.SetOwner(Networking.LocalPlayer, gameObject);
+            _syncedValue = slider.value;
+            if (!Networking.IsOwner(gameObject)) Networking.SetOwner(Networking.LocalPlayer, gameObject);
             RequestSerialization();
         }
     }

Packages/dev.derpynewbie.common/Runtime/UniUI/UniToggleSync.cs

@@ -12,38 +12,34 @@ public class UniToggleSync : UniUI
         [SerializeField] [NewbieInject(SearchScope.Parents)]
         private Toggle toggle;
 
-        [UdonSynced] [FieldChangeCallback(nameof(SyncedIsOn))]
+        [UdonSynced]
         private bool _syncedIsOn;
 
         private bool _inSyncedChangeContext;
 
-        public bool SyncedIsOn
-        {
-            get => _syncedIsOn;
-            set
-            {
-                _syncedIsOn = value;
-                if (_inSyncedChangeContext) return;
-
-                _inSyncedChangeContext = true;
-                toggle.isOn = value;
-                _inSyncedChangeContext = false;
-            }
-        }
-
         private void Start()
         {
+            // serialize the initial value when instance master has first joined
             if (!Networking.IsMaster) return;
             _syncedIsOn = toggle.isOn;
             RequestSerialization();
         }
 
+        public override void OnDeserialization()
+        {
+            // apply deserialized values to UI
+            _inSyncedChangeContext = true;
+            toggle.isOn = _syncedIsOn;
+            _inSyncedChangeContext = false;
+        }
+
         public override void OnUniUIUpdate()
         {
-            if (_inSyncedChangeContext || toggle.isOn == SyncedIsOn) return;
+            // don't resync if the event was called by OnDeserialization change
+            if (_inSyncedChangeContext) return;
 
-            SyncedIsOn = toggle.isOn;
-            Networking.SetOwner(Networking.LocalPlayer, gameObject);
+            _syncedIsOn = toggle.isOn;
+            if (!Networking.IsOwner(gameObject)) Networking.SetOwner(Networking.LocalPlayer, gameObject);
             RequestSerialization();
         }
     }