clean up success indicator

Author: grahamc

.github/workflows/ci.yml

@@ -15,9 +15,6 @@ on:
     types:
       - released
 
-env:
-  PUBLISH_TO_FLAKEHUB: ${{ !github.repository.fork && (github.ref == format('refs/heads/{0}', github.event.repository.default_branch) || startsWith(github.ref, 'refs/tags/')) }}
-
 jobs:
   checks:
     runs-on: ubuntu-latest
@@ -60,20 +57,24 @@ jobs:
           nix flake lock
           git diff --exit-code
 
+  success:
+    needs: [checks, test-modules]
+    runs-on: ubuntu-latest
+    steps:
+      - run: true
+
   publish:
+    if: !github.repository.fork && (github.ref == format('refs/heads/{0}', github.event.repository.default_branch) || startsWith(github.ref, 'refs/tags/'))
     environment: ${{ github.event_name == 'release' && 'production' || '' }}
-    needs: [checks, test-modules]
+    needs: [success]
     runs-on: ubuntu-latest
     permissions:
       contents: read
       id-token: write
     steps:
       - uses: actions/checkout@v4
-        if: fromJson(env.PUBLISH_TO_FLAKEHUB)
       - uses: DeterminateSystems/nix-installer-action@main
-        if: fromJson(env.PUBLISH_TO_FLAKEHUB)
       - uses: "DeterminateSystems/flakehub-push@main"
-        if: fromJson(env.PUBLISH_TO_FLAKEHUB)
         with:
           rolling: ${{ github.ref == format('refs/heads/{0}', github.event.repository.default_branch) }}
           visibility: "unlisted"