Skip to content

Commit 6dd311f

Browse files
committed
Fixes netbox-community#15961: Fix secret toggle button by avoiding duplicate event handler
1 parent 85d2500 commit 6dd311f

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

netbox/project-static/dist/netbox.js

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

netbox/project-static/dist/netbox.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

netbox/project-static/src/buttons/secretToggle.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,18 +60,17 @@ function handleSecretToggle(state: StateManager<SecretState>, button: HTMLButton
6060
toggleSecretButton(hidden, button);
6161
}
6262

63+
function toggleCallback(event: MouseEvent) {
64+
handleSecretToggle(secretState, event.currentTarget as HTMLButtonElement);
65+
}
66+
6367
/**
6468
* Initialize secret toggle button.
6569
*/
6670
export function initSecretToggle(): void {
6771
hideSecret();
6872
for (const button of getElements<HTMLButtonElement>('button.toggle-secret')) {
69-
button.addEventListener(
70-
'click',
71-
event => {
72-
handleSecretToggle(secretState, event.currentTarget as HTMLButtonElement);
73-
},
74-
false,
75-
);
73+
button.removeEventListener('click', toggleCallback);
74+
button.addEventListener('click', toggleCallback);
7675
}
7776
}

0 commit comments

Comments
 (0)