Skip to content

Commit 0a92a5d

Browse files
committed
change: Change ServiceRequestResult class to sealed class for improved code readability
1 parent 88a3e77 commit 0a92a5d

File tree

4 files changed

+114
-92
lines changed

4 files changed

+114
-92
lines changed

documentation/models_documentation.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,12 @@ The level of detail displayed in notifications on the lock screen.
125125

126126
### :chicken: ServiceRequestResult
127127

128-
Result of service request.
128+
sealed class: Represents the result of a service request.
129129

130-
| Property | Description |
131-
|-----------|-------------------------------------|
132-
| `success` | Whether the request was successful. |
133-
| `error` | Error when the request failed. |
130+
| child | Description |
131+
|---------------------------------------|-------------------------------------|
132+
| `ServiceRequestSuccess()` | The service request was successful. |
133+
| `ServiceRequestFailure(Object error)` | The service request failed. |
134134

135135
### :chicken: TaskStarter
136136

lib/flutter_foreground_task.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,9 @@ class FlutterForegroundTask {
127127
await checkServiceStateChange(target: true);
128128
}
129129

130-
return ServiceRequestResult.success();
130+
return const ServiceRequestSuccess();
131131
} catch (error) {
132-
return ServiceRequestResult.error(error);
132+
return ServiceRequestFailure(error: error);
133133
}
134134
}
135135

@@ -142,9 +142,9 @@ class FlutterForegroundTask {
142142

143143
await _platform.restartService();
144144

145-
return ServiceRequestResult.success();
145+
return const ServiceRequestSuccess();
146146
} catch (error) {
147-
return ServiceRequestResult.error(error);
147+
return ServiceRequestFailure(error: error);
148148
}
149149
}
150150

@@ -171,9 +171,9 @@ class FlutterForegroundTask {
171171
callback: callback,
172172
);
173173

174-
return ServiceRequestResult.success();
174+
return const ServiceRequestSuccess();
175175
} catch (error) {
176-
return ServiceRequestResult.error(error);
176+
return ServiceRequestFailure(error: error);
177177
}
178178
}
179179

@@ -190,9 +190,9 @@ class FlutterForegroundTask {
190190
await checkServiceStateChange(target: false);
191191
}
192192

193-
return ServiceRequestResult.success();
193+
return const ServiceRequestSuccess();
194194
} catch (error) {
195-
return ServiceRequestResult.error(error);
195+
return ServiceRequestFailure(error: error);
196196
}
197197
}
198198

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,17 @@
1-
/// Result of service request.
2-
class ServiceRequestResult {
3-
const ServiceRequestResult({
4-
required this.success,
5-
this.error,
6-
});
7-
8-
/// Whether the request was successful.
9-
final bool success;
1+
/// Represents the result of a service request.
2+
sealed class ServiceRequestResult {
3+
const ServiceRequestResult();
4+
}
105

11-
/// Error when the request failed.
12-
final Object? error;
6+
/// The service request was successful.
7+
final class ServiceRequestSuccess extends ServiceRequestResult {
8+
const ServiceRequestSuccess();
9+
}
1310

14-
factory ServiceRequestResult.success() =>
15-
const ServiceRequestResult(success: true);
11+
/// The service request failed.
12+
final class ServiceRequestFailure extends ServiceRequestResult {
13+
const ServiceRequestFailure({required this.error});
1614

17-
factory ServiceRequestResult.error(Object error) =>
18-
ServiceRequestResult(success: false, error: error);
15+
/// The error that occurred when the service request failed.
16+
final Object error;
1917
}

0 commit comments

Comments
 (0)