move aggregate error constructor out of client class

Author: ajwootto

libs/providers/multi-provider/src/lib/errors.ts

@@ -17,3 +17,17 @@ export class AggregateError extends GeneralError {
     super(message);
   }
 }
+
+export const constructAggregateError = (providerErrors: { error: unknown; providerName: string }[]) => {
+  const errorsWithSource = providerErrors
+    .map(({ providerName, error }) => {
+      return { source: providerName, error };
+    })
+    .flat();
+
+  // log first error in the message for convenience, but include all errors in the error object for completeness
+  return new AggregateError(
+    `Provider errors occurred: ${errorsWithSource[0].source}: ${errorsWithSource[0].error}`,
+    errorsWithSource,
+  );
+};

libs/providers/multi-provider/src/lib/multi-provider.ts

@@ -14,9 +14,8 @@ import {
 } from '@openfeature/server-sdk';
 import { BeforeHookContext, ProviderMetadata } from '@openfeature/core';
 import { HookExecutor } from './hook-executor';
-import { AggregateError } from './errors';
-import { BaseEvaluationStrategy, ProviderResolutionResult } from './strategies/BaseEvaluationStrategy';
-import { FirstMatchStrategy } from './strategies/FirstMatchStrategy';
+import { constructAggregateError } from './errors';
+import { BaseEvaluationStrategy, ProviderResolutionResult, FirstMatchStrategy } from './strategies';
 import { StatusTracker } from './status-tracker';
 
 // Represents an entry in the constructor's provider array which may or may not have a name set
@@ -181,7 +180,7 @@ export class MultiProvider implements Provider {
     const finalResult = this.evaluationStrategy.determineFinalResult({ flagKey, flagType }, context, resolutions);
 
     if (finalResult.errors?.length) {
-      throw this.constructAggregateError(finalResult.errors);
+      throw constructAggregateError(finalResult.errors);
     }
 
     if (!finalResult.details) {
@@ -323,18 +322,4 @@ export class MultiProvider implements Provider {
       },
     ];
   }
-
-  private constructAggregateError(providerErrors: { error: unknown; providerName: string }[]) {
-    const errorsWithSource = providerErrors
-      .map(({ providerName, error }) => {
-        return { source: providerName, error };
-      })
-      .flat();
-
-    // log first error in the message for convenience, but include all errors in the error object for completeness
-    return new AggregateError(
-      `Provider errors occurred: ${errorsWithSource[0].source}: ${errorsWithSource[0].error}`,
-      errorsWithSource,
-    );
-  }
 }