fix: use custom JSON parsing for eval targetId to not crash when target_id is not defined on the API response from the DevCycle Bucketing API

Author: kaushalkapasi

src/main/java/com/devcycle/sdk/server/common/api/IDevCycleApi.java

@@ -1,11 +1,24 @@
 package com.devcycle.sdk.server.common.api;
 
-import com.devcycle.sdk.server.common.model.*;
+import java.util.Map;
+
+import com.devcycle.sdk.server.common.model.BaseVariable;
+import com.devcycle.sdk.server.common.model.DevCycleResponse;
+import com.devcycle.sdk.server.common.model.DevCycleUser;
+import com.devcycle.sdk.server.common.model.DevCycleUserAndEvents;
+import com.devcycle.sdk.server.common.model.Feature;
+import com.devcycle.sdk.server.common.model.ProjectConfig;
+import com.devcycle.sdk.server.common.model.Variable;
 import com.devcycle.sdk.server.local.model.EventsBatch;
-import retrofit2.Call;
-import retrofit2.http.*;
 
-import java.util.Map;
+import retrofit2.Call;
+import retrofit2.http.Body;
+import retrofit2.http.GET;
+import retrofit2.http.Header;
+import retrofit2.http.Headers;
+import retrofit2.http.POST;
+import retrofit2.http.Path;
+import retrofit2.http.Query;
 
 public interface IDevCycleApi {
     /**

src/main/java/com/devcycle/sdk/server/common/model/EvalReason.java

@@ -1,8 +1,14 @@
 package com.devcycle.sdk.server.common.model;
 
+import java.io.IOException;
+
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonDeserializer;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
 
 import io.swagger.v3.oas.annotations.media.Schema;
 import lombok.AllArgsConstructor;
@@ -24,7 +30,8 @@ public class EvalReason {
 
     @Schema(description = "Target ID")
     @JsonProperty("target_id")
-    @JsonInclude(value=JsonInclude.Include.NON_EMPTY, content=JsonInclude.Include.NON_NULL)
+    @JsonInclude(value=JsonInclude.Include.NON_NULL)
+    @JsonDeserialize(using = TargetIdDeserializer.class)
     private String targetId;
 
     private EvalReason(String reason, String details) {
@@ -33,13 +40,33 @@ private EvalReason(String reason, String details) {
     }
 
     public static EvalReason defaultReason(DefaultReasonDetailsEnum details) {
-        return new EvalReason("DEFAULT", details.getValue());
+        String defaultDetails = details.getValue();
+        System.out.println("Setting default reason to " + defaultDetails);
+        return new EvalReason("DEFAULT", defaultDetails);
     }
 
     public String getReason() {
         return reason == null ? "UNKNOWN" : reason;
     }
 
+    // Simple deserializer to handle target_id as string or object
+    public static class TargetIdDeserializer extends JsonDeserializer<String> {
+        @Override
+        public String deserialize(JsonParser parser, DeserializationContext context) throws IOException {
+            // Skip the current token and read the value as Object
+            Object value = parser.readValueAs(Object.class);
+            
+            if (value == null) {
+                return null;
+            } else if (value instanceof String) {
+                return (String) value;
+            } else {
+                // For any other type (object, number, boolean), convert to string
+                return value.toString();
+            }
+        }
+    }
+
     public enum DefaultReasonDetailsEnum {
         MISSING_CONFIG("Missing Config"),
         USER_NOT_TARGETED("User Not Targeted"),

src/main/java/com/devcycle/sdk/server/common/model/Variable.java

@@ -3,7 +3,9 @@
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 
+import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.annotation.JsonValue;
 
 import io.swagger.v3.oas.annotations.media.Schema;
@@ -33,13 +35,14 @@ public class Variable<T> {
     @Builder.Default
     private Boolean isDefaulted = false;
 
-    @Builder.Default
-    @Deprecated()
-    private String evalReason = null;
-
     @Schema(description = "Evaluation reason")
+    @JsonProperty("eval")
     private EvalReason eval;
 
+    @Deprecated()
+    @JsonIgnore
+    private final String evalReason = null;
+
     public enum TypeEnum {
         STRING("String"),
         BOOLEAN("Boolean"),