Skip to content

Commit 3abf2ee

Browse files
committed
update unit tests
1 parent e7c2c48 commit 3abf2ee

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

test/api/test_local_bucketing.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
Project,
1111
ProjectSettings,
1212
)
13+
from devcycle_python_sdk.models.eval_reason import EvalReason
1314
from devcycle_python_sdk.models.feature import Feature
1415
from devcycle_python_sdk.models.variable import Variable
1516
from devcycle_python_sdk.models.platform_data import default_platform_data
@@ -155,6 +156,11 @@ def test_generate_bucketed_config(self):
155156
evalReason=None,
156157
)
157158
}
159+
expected_eval = EvalReason(
160+
reason='TARGETING_MATCH',
161+
details='All Users',
162+
target_id='63125321d31c601f992288bc'
163+
)
158164
expected_variables = {
159165
"a-cool-new-feature": Variable(
160166
_id="62fbf6566f1ba302829f9e34",
@@ -164,6 +170,7 @@ def test_generate_bucketed_config(self):
164170
isDefaulted=None,
165171
defaultValue=None,
166172
evalReason=None,
173+
eval=expected_eval,
167174
),
168175
"string-var": Variable(
169176
_id="63125320a4719939fd57cb2b",
@@ -173,6 +180,7 @@ def test_generate_bucketed_config(self):
173180
isDefaulted=None,
174181
defaultValue=None,
175182
evalReason=None,
183+
eval=expected_eval,
176184
),
177185
"json-var": Variable(
178186
_id="64372363125123fca69d3f7b",
@@ -186,6 +194,7 @@ def test_generate_bucketed_config(self):
186194
isDefaulted=None,
187195
defaultValue=None,
188196
evalReason=None,
197+
eval=expected_eval,
189198
),
190199
"num-var": Variable(
191200
_id="65272363125123fca69d3a7d",
@@ -195,6 +204,7 @@ def test_generate_bucketed_config(self):
195204
isDefaulted=None,
196205
defaultValue=None,
197206
evalReason=None,
207+
eval=expected_eval,
198208
),
199209
"float-var": Variable(
200210
_id="61200363125123fca69d3a7a",
@@ -204,6 +214,7 @@ def test_generate_bucketed_config(self):
204214
isDefaulted=None,
205215
defaultValue=None,
206216
evalReason=None,
217+
eval=expected_eval,
207218
),
208219
}
209220

test/test_local_client.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from devcycle_python_sdk.local_client import _validate_user, _validate_sdk_key
1111
from devcycle_python_sdk.exceptions import MalformedConfigError
1212
from devcycle_python_sdk.models.eval_hook import EvalHook
13+
from devcycle_python_sdk.models.eval_reason import EvalReason
1314
from devcycle_python_sdk.models.event import DevCycleEvent
1415
from devcycle_python_sdk.models.feature import Feature
1516
from devcycle_python_sdk.api.local_bucketing import LocalBucketing
@@ -294,7 +295,11 @@ def test_all_variables(self):
294295
user = DevCycleUser(user_id="1234")
295296

296297
result = self.client.all_variables(user)
297-
298+
expected_eval = EvalReason(
299+
reason='TARGETING_MATCH',
300+
details='All Users',
301+
target_id='63125321d31c601f992288bc'
302+
)
298303
expected_variables = {
299304
"a-cool-new-feature": Variable(
300305
_id="62fbf6566f1ba302829f9e34",
@@ -304,6 +309,7 @@ def test_all_variables(self):
304309
isDefaulted=None,
305310
defaultValue=None,
306311
evalReason=None,
312+
eval=expected_eval,
307313
),
308314
"string-var": Variable(
309315
_id="63125320a4719939fd57cb2b",
@@ -313,6 +319,7 @@ def test_all_variables(self):
313319
isDefaulted=None,
314320
defaultValue=None,
315321
evalReason=None,
322+
eval=expected_eval,
316323
),
317324
"json-var": Variable(
318325
_id="64372363125123fca69d3f7b",
@@ -326,6 +333,7 @@ def test_all_variables(self):
326333
isDefaulted=None,
327334
defaultValue=None,
328335
evalReason=None,
336+
eval=expected_eval,
329337
),
330338
"num-var": Variable(
331339
_id="65272363125123fca69d3a7d",
@@ -335,6 +343,7 @@ def test_all_variables(self):
335343
isDefaulted=None,
336344
defaultValue=None,
337345
evalReason=None,
346+
eval=expected_eval,
338347
),
339348
"float-var": Variable(
340349
_id="61200363125123fca69d3a7a",
@@ -344,6 +353,7 @@ def test_all_variables(self):
344353
isDefaulted=None,
345354
defaultValue=None,
346355
evalReason=None,
356+
eval=expected_eval,
347357
),
348358
}
349359
self.assertEqual(result, expected_variables)

0 commit comments

Comments
 (0)