Skip to content

Commit a2c5a95

Browse files
chore: fix mypy issues with close()
1 parent 24c72da commit a2c5a95

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

devcycle_python_sdk/cloud_client.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,13 @@ def track(self, user: DevCycleUser, user_event: DevCycleEvent) -> None:
182182
except Exception as e:
183183
logger.error(f"DevCycle: Error tracking event: {e}")
184184

185+
def close(self) -> None:
186+
"""
187+
Closes the client and releases any resources held by it.
188+
"""
189+
# Cloud client doesn't need to release any resources
190+
logger.debug("DevCycle: Cloud client closed")
191+
185192

186193
def _validate_sdk_key(sdk_key: str) -> None:
187194
if sdk_key is None or len(sdk_key) == 0:

devcycle_python_sdk/devcycle_client.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,10 @@ def get_openfeature_provider(self) -> AbstractProvider:
3838
@abstractmethod
3939
def get_sdk_platform(self) -> str:
4040
pass
41+
42+
@abstractmethod
43+
def close(self) -> None:
44+
"""
45+
Closes the client and releases any resources held by it.
46+
"""
47+
pass

devcycle_python_sdk/local_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import logging
33
import uuid
44
from numbers import Real
5-
from typing import Any, Dict, Union
5+
from typing import Any, Dict, Union, Optional
66

77
from devcycle_python_sdk import DevCycleLocalOptions, AbstractDevCycleClient
88
from devcycle_python_sdk.api.local_bucketing import LocalBucketing
@@ -50,7 +50,7 @@ def __init__(self, sdk_key: str, options: DevCycleLocalOptions):
5050
sdk_key, self.client_uuid, self.options, self.local_bucketing
5151
)
5252

53-
self._openfeature_provider = None
53+
self._openfeature_provider: Optional[DevCycleProvider] = None
5454

5555
def get_sdk_platform(self) -> str:
5656
return "Local"

0 commit comments

Comments
 (0)