handle local bucketing eval reason

Author: phaym

devcycle_python_sdk/api/local_bucketing.py

@@ -323,14 +323,7 @@ def get_variable_for_user_protobuf(
                 var_bytes = self._read_assembly_script_byte_array(variable_addr)
                 sdk_variable = pb2.SDKVariable_PB()
                 sdk_variable.ParseFromString(var_bytes)
-
-                if sdk_variable.type != pb_variable_type:
-                    # this situation should never actually happen because the WASM handles
-                    # it internally and returns a null value from the WASM function
-                    # This check is here just in case that logic changes in the future
-                    raise VariableTypeMismatchError(
-                        f"Variable returned does not match requested type: {pb_variable_type}"
-                    )
+             
                 return pb_utils.create_variable(sdk_variable, default_value)
 
     def generate_bucketed_config(self, user: DevCycleUser) -> BucketedConfig:

devcycle_python_sdk/local_client.py

@@ -17,6 +17,7 @@
 from devcycle_python_sdk.models.bucketed_config import BucketedConfig
 from devcycle_python_sdk.models.eval_hook import EvalHook
 from devcycle_python_sdk.models.eval_hook_context import HookContext
+from devcycle_python_sdk.models.eval_reason import DefaultReasonDetails, EvalReason, EvalReasons
 from devcycle_python_sdk.models.event import DevCycleEvent, EventType
 from devcycle_python_sdk.models.feature import Feature
 from devcycle_python_sdk.models.platform_data import default_platform_data
@@ -139,7 +140,7 @@ def variable(self, user: DevCycleUser, key: str, default_value: Any) -> Variable
                 logger.warning(
                     f"DevCycle: Unable to track AggVariableDefaulted event for Variable {key}: {e}"
                 )
-            return Variable.create_default_variable(key, default_value)
+            return Variable.create_default_variable(key, default_value, DefaultReasonDetails.MISSING_CONFIG)
 
         context = HookContext(key, user, default_value)
         variable = Variable.create_default_variable(
@@ -159,22 +160,30 @@ def variable(self, user: DevCycleUser, key: str, default_value: Any) -> Variable
             )
             if bucketed_variable is not None:
                 variable = bucketed_variable
+            else:
+                variable.eval = EvalReason(
+                    reason=EvalReasons.DEFAULT,
+                    details=DefaultReasonDetails.USER_NOT_TARGETED
+                )
 
             if before_hook_error is None:
                 self.eval_hooks_manager.run_after(context, variable)
             else:
                 raise before_hook_error
-        except VariableTypeMismatchError:
-            logger.debug("DevCycle: Variable type mismatch, returning default value")
-            return variable
-        except BeforeHookError as e:
-            self.eval_hooks_manager.run_error(context, e)
-            return variable
-        except AfterHookError as e:
-            self.eval_hooks_manager.run_error(context, e)
-            return variable
         except Exception as e:
-            logger.warning(f"DevCycle: Error retrieving variable for user: {e}")
+            variable.eval = EvalReason(
+                reason=EvalReasons.DEFAULT,
+                details=DefaultReasonDetails.ERROR
+            )
+
+            if isinstance(e, BeforeHookError):
+                self.eval_hooks_manager.run_error(context, e)
+            elif isinstance(e, AfterHookError):
+                self.eval_hooks_manager.run_error(context, e)
+            else:
+                logger.warning(
+                    f"DevCycle: Error retrieving variable for user: {e}")
+
             return variable
         finally:
             self.eval_hooks_manager.run_finally(context, variable)

devcycle_python_sdk/models/eval_reason.py

@@ -0,0 +1,37 @@
+from dataclasses import dataclass
+from typing import Optional
+
+
+class EvalReasons:
+    """Evaluation reasons constants"""
+    DEFAULT = "DEFAULT"
+
+
+class DefaultReasonDetails:
+    """Default reason details constants"""
+    MISSING_CONFIG = "Missing Config"
+    USER_NOT_TARGETED = "User Not Targeted"
+    TYPE_MISMATCH = "Variable Type Mismatch"
+    ERROR = "Error"
+
+
+@dataclass(order=False)
+class EvalReason:
+    reason: str
+    details: Optional[str] = None
+    target_id: Optional[str] = None
+
+    def to_json(self):
+        return {
+            key: getattr(self, key)
+            for key in self.__dataclass_fields__
+            if getattr(self, key) is not None
+        }
+
+    @classmethod
+    def from_json(cls, data: dict) -> "EvalReason":
+        return cls(
+            reason=data["reason"],
+            details=data.get("details"),
+            target_id=data.get("target_id"),
+        ) 

devcycle_python_sdk/models/variable.py

@@ -2,6 +2,8 @@
 from dataclasses import dataclass
 from typing import Optional, Any
 
+from .eval_reason import EvalReason, EvalReasons, DefaultReasonDetails
+
 
 class TypeEnum:
     BOOLEAN = "Boolean"
@@ -32,16 +34,26 @@ class Variable:
     isDefaulted: Optional[bool] = False
     defaultValue: Any = None
     evalReason: Optional[str] = None
+    eval: Optional[EvalReason] = None
 
     def to_json(self):
-        return {
-            key: getattr(self, key)
-            for key in self.__dataclass_fields__
-            if getattr(self, key) is not None
-        }
+        result = {}
+        for key in self.__dataclass_fields__:
+            value = getattr(self, key)
+            if value is not None:
+                if key == "eval" and isinstance(value, EvalReason):
+                    result[key] = value.to_json()
+                else:
+                    result[key] = value
+        return result
 
     @classmethod
     def from_json(cls, data: dict) -> "Variable":
+        eval_data = data.get("eval")
+        eval_reason = None
+        if eval_data:
+            eval_reason = EvalReason.from_json(eval_data)
+
         return cls(
             _id=data["_id"],
             key=data["key"],
@@ -50,16 +62,25 @@ def from_json(cls, data: dict) -> "Variable":
             isDefaulted=data.get("isDefaulted", None),
             defaultValue=data.get("defaultValue"),
             evalReason=data.get("evalReason"),
+            eval=eval_reason,
         )
 
     @staticmethod
-    def create_default_variable(key: str, default_value: Any) -> "Variable":
+    def create_default_variable(key: str, default_value: Any, default_reason_detail: str = None) -> "Variable":
         var_type = determine_variable_type(default_value)
+        if default_reason_detail is not None:
+            eval_reason = EvalReason(
+                reason=EvalReasons.DEFAULT,
+                details=default_reason_detail
+            )
+        else:
+            eval_reason = None
         return Variable(
             _id=None,
             key=key,
             type=var_type,
             value=default_value,
             defaultValue=default_value,
             isDefaulted=True,
+            eval=eval_reason,
         )

devcycle_python_sdk/protobuf/utils.py

@@ -5,6 +5,7 @@
 from typing import Any, Optional
 
 from devcycle_python_sdk.models.variable import TypeEnum, Variable
+from devcycle_python_sdk.models.eval_reason import EvalReason
 from devcycle_python_sdk.models.user import DevCycleUser
 
 import devcycle_python_sdk.protobuf.variableForUserParams_pb2 as pb2
@@ -82,7 +83,20 @@ def create_dvcuser_pb(user: DevCycleUser) -> pb2.DVCUser_PB:  # type: ignore
     )
 
 
+def create_eval_reason_from_pb(eval_reason_pb: pb2.EvalReason_PB) -> EvalReason:  # type: ignore
+    """Convert EvalReason_PB protobuf message to EvalReason object"""
+    return EvalReason(
+        reason=eval_reason_pb.reason,
+        details=eval_reason_pb.details if eval_reason_pb.details else None,
+        target_id=eval_reason_pb.target_id if eval_reason_pb.target_id else None,
+    )
+
+
 def create_variable(sdk_variable: pb2.SDKVariable_PB, default_value: Any) -> Variable:  # type: ignore
+    eval_reason_obj = None
+    if sdk_variable.HasField('eval'):
+        eval_reason_obj = create_eval_reason_from_pb(sdk_variable.eval)
+
     if sdk_variable.type == pb2.VariableType_PB.Boolean:  # type: ignore
         return Variable(
             _id=None,
@@ -91,6 +105,7 @@ def create_variable(sdk_variable: pb2.SDKVariable_PB, default_value: Any) -> Var
             type=TypeEnum.BOOLEAN,
             isDefaulted=False,
             defaultValue=default_value,
+            eval=eval_reason_obj,
         )
 
     elif sdk_variable.type == pb2.VariableType_PB.String:  # type: ignore
@@ -101,6 +116,7 @@ def create_variable(sdk_variable: pb2.SDKVariable_PB, default_value: Any) -> Var
             type=TypeEnum.STRING,
             isDefaulted=False,
             defaultValue=default_value,
+            eval=eval_reason_obj,
         )
 
     elif sdk_variable.type == pb2.VariableType_PB.Number:  # type: ignore
@@ -111,6 +127,7 @@ def create_variable(sdk_variable: pb2.SDKVariable_PB, default_value: Any) -> Var
             type=TypeEnum.NUMBER,
             isDefaulted=False,
             defaultValue=default_value,
+            eval=eval_reason_obj,
         )
 
     elif sdk_variable.type == pb2.VariableType_PB.JSON:  # type: ignore
@@ -123,6 +140,7 @@ def create_variable(sdk_variable: pb2.SDKVariable_PB, default_value: Any) -> Var
             type=TypeEnum.JSON,
             isDefaulted=False,
             defaultValue=default_value,
+            eval=eval_reason_obj,
         )
 
     else: