Address PR review feedback: remove unused user_id_source, consolidate exclusion logic, include targeting_key

- Remove unused user_id_source variable and assignments (addresses code clutter concern)
- Consolidate user ID exclusion logic into single efficient statement
- Include targeting_key in exclusion logic to prevent it from being added to custom data
- Update comment to mention all three user ID types for clarity
- Add comprehensive test coverage for targeting_key exclusion from attributes

Author: jonathannorris

devcycle_python_sdk/models/user.py

@@ -107,18 +107,14 @@ def create_user_from_context(
         :return: A DevCycleUser instance
         """
         user_id = None
-        user_id_source = None
 
         if context:
             if context.targeting_key:
                 user_id = context.targeting_key
-                user_id_source = "targeting_key"
             elif context.attributes and "user_id" in context.attributes.keys():
                 user_id = context.attributes["user_id"]
-                user_id_source = "user_id"
             elif context.attributes and "userId" in context.attributes.keys():
                 user_id = context.attributes["userId"]
-                user_id_source = "userId"
 
         if not user_id or not isinstance(user_id, str):
             raise TargetingKeyMissingError(
@@ -130,10 +126,8 @@ def create_user_from_context(
         private_custom_data: Dict[str, Any] = {}
         if context and context.attributes:
             for key, value in context.attributes.items():
-                # Skip user_id and userId - these are reserved for user ID mapping
-                if key == "user_id":
-                    continue
-                if key == "userId":
+                # Skip user_id, userId, and targeting_key - these are reserved for user ID mapping
+                if key in ("user_id", "userId", "targeting_key"):
                     continue
 
                 if value is not None:

test/models/test_user.py

@@ -125,6 +125,20 @@ def test_create_user_from_context_user_id_fields_always_excluded(self):
         self.assertNotIn("userId", user.customData)
         self.assertEqual(user.customData["other_field"], "value")
 
+    def test_create_user_from_context_targeting_key_excluded_from_attributes(self):
+        targeting_key_id = "targeting-12345"
+        
+        # When targeting_key appears in attributes, it should be excluded from custom data
+        context = EvaluationContext(
+            targeting_key=targeting_key_id, 
+            attributes={"targeting_key": "should-be-excluded", "other_field": "value"}
+        )
+        user = DevCycleUser.create_user_from_context(context)
+        self.assertEqual(user.user_id, targeting_key_id)
+        self.assertIsNotNone(user.customData)
+        self.assertNotIn("targeting_key", user.customData)
+        self.assertEqual(user.customData["other_field"], "value")
+
     def test_create_user_from_context_userId_excluded_when_used(self):
         userId = "userId-12345"