Skip to content

Commit 08ac724

Browse files
marker-daomarker dao ®
andauthored
AIIntegration: Remove onChunk from RequestParams in .d.ts
Co-authored-by: marker dao ® <[email protected]>
1 parent 6a90c0d commit 08ac724

File tree

5 files changed

+13
-16
lines changed

5 files changed

+13
-16
lines changed

packages/devextreme/js/__internal/core/ai_integration/core/request_manager.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ import {
55
it,
66
jest,
77
} from '@jest/globals';
8-
import type { AIProvider, Prompt, RequestParams } from '@js/common/ai-integration';
8+
import type { AIProvider, Prompt } from '@js/common/ai-integration';
9+
import type { RequestManagerParams } from '@ts/core/ai_integration/core/request_manager';
910
import { ERROR_MESSAGES, RequestManager } from '@ts/core/ai_integration/core/request_manager';
1011
import { Provider } from '@ts/core/ai_integration/test_utils/provider_mock';
1112

@@ -146,7 +147,7 @@ describe('RequestManager', () => {
146147
it('should not forward chunks', () => {
147148
const onChunkSpy = jest.fn();
148149

149-
let capturedParams = undefined as unknown as RequestParams;
150+
let capturedParams = undefined as unknown as RequestManagerParams;
150151

151152
jest.spyOn(provider, 'sendRequest').mockImplementation((params) => {
152153
capturedParams = params;

packages/devextreme/js/__internal/core/ai_integration/core/request_manager.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ export interface RequestManagerCallbacks {
1010
onError?: (error: Error) => void;
1111
}
1212

13+
export type RequestManagerParams = RequestParams & {
14+
onChunk?: (chunk: string) => void;
15+
};
16+
1317
export class RequestManager {
1418
private readonly provider: AIProvider;
1519

@@ -21,7 +25,7 @@ export class RequestManager {
2125
if (typeof this.provider.sendRequest === 'function') {
2226
let aborted = false;
2327

24-
const params: RequestParams = {
28+
const params: RequestManagerParams = {
2529
prompt,
2630
onChunk: (chunk: string): void => { if (!aborted) { callbacks?.onChunk?.(chunk); } },
2731
};

packages/devextreme/js/__internal/core/ai_integration/test_utils/provider_mock.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
import type { AIProvider, RequestParams, Response } from '@js/common/ai-integration';
1+
import type { AIProvider, Response } from '@js/common/ai-integration';
2+
import type { RequestManagerParams } from '@ts/core/ai_integration/core/request_manager';
23

34
export class Provider implements AIProvider {
4-
sendRequest(params: RequestParams): Response {
5+
sendRequest(params: RequestManagerParams): Response {
56
const { onChunk } = params;
67

78
const promise = new Promise<string>((resolve) => {
8-
onChunk('AI');
9-
onChunk(' response');
9+
onChunk?.('AI');
10+
onChunk?.(' response');
1011

1112
resolve('AI response');
1213
});

packages/devextreme/js/common/ai-integration.d.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ export type RequestParams = {
2727
* @public
2828
*/
2929
prompt: Prompt;
30-
/**
31-
* @docid
32-
* @public
33-
*/
34-
onChunk: (chunk: string) => void;
3530
};
3631

3732
/**

packages/devextreme/ts/dx.all.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -996,10 +996,6 @@ declare module DevExpress.aiIntegration {
996996
* [descr:RequestParams.prompt]
997997
*/
998998
prompt: Prompt;
999-
/**
1000-
* [descr:RequestParams.onChunk]
1001-
*/
1002-
onChunk: (chunk: string) => void;
1003999
};
10041000
/**
10051001
* [descr:Response]

0 commit comments

Comments
 (0)