Skip to content

Commit 1a2e00a

Browse files
authored
Chat: unskip and fix unstable test with ScrollView integration
1 parent 0a86645 commit 1a2e00a

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

packages/devextreme/testing/tests/DevExpress.performance/widgetsRenderStyleRecalculations.tests.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ const components = [
9494
{ name: 'dxSelectBox', config: { labelMode: 'outside' }, expectedRecalculations: 1 },
9595
{ name: 'dxSelectBox', config: { label: 'Label', labelMode: 'hidden' }, expectedRecalculations: 1 },
9696
// { name: 'dxSelectBox', config: { label: 'Label', labelMode: 'static' }, expectedRecalculations: 2 },
97-
// TODO Chrome133: skipped during chrome update
9897
// { name: 'dxSelectBox', config: { label: 'Label', labelMode: 'floating' }, expectedRecalculations: 2 },
9998
{ name: 'dxSelectBox', config: { label: 'Label', labelMode: 'outside' }, expectedRecalculations: 1 },
10099

packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/messageList.tests.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ const SCROLLVIEW_REACHBOTTOM_INDICATOR = 'dx-scrollview-scrollbottom';
3232
const SCROLLABLE_CONTENT = 'dx-scrollable-content';
3333

3434
const MS_IN_DAY = 86400000;
35+
const SCROLLVIEW_TIMEOUT = 50;
3536

3637
const getStringDate = (date) => {
3738
return dateLocalization.format(date, 'shortdate');
@@ -1178,8 +1179,7 @@ QUnit.module('MessageList', () => {
11781179
});
11791180
});
11801181

1181-
// TODO Chrome133: skipped during chrome update
1182-
QUnit.test.skip('should not be scroll down if typingUsers changed at runtime if scroll position not at the bottom', function(assert) {
1182+
QUnit.test('should not be scroll down if typingUsers changed at runtime if scroll position not at the bottom', function(assert) {
11831183
const done = assert.async();
11841184

11851185
this.reinit({
@@ -1205,9 +1205,9 @@ QUnit.module('MessageList', () => {
12051205

12061206
assert.roughEqual(scrollTop, scrollTopBefore, 1, 'scroll position should remain the same after updating typingUsers when not at the bottom');
12071207
done();
1208-
});
1209-
});
1210-
});
1208+
}, SCROLLVIEW_TIMEOUT);
1209+
}, SCROLLVIEW_TIMEOUT);
1210+
}, SCROLLVIEW_TIMEOUT);
12111211
});
12121212

12131213
QUnit.test('should be scroll down if typingUsers changed at runtime, provided the content does not overflow before the typing indicator is displayed', function(assert) {
@@ -1398,9 +1398,9 @@ QUnit.module('MessageList', () => {
13981398
assert.notEqual(scrollTop, 0, 'scroll position should not be 0 after a new message is rendered');
13991399
assert.roughEqual(scrollTop, scrollTopBefore, 1, 'scroll position should be at the bottom after rendering the new message');
14001400
done();
1401-
});
1402-
});
1403-
});
1401+
}, SCROLLVIEW_TIMEOUT);
1402+
}, SCROLLVIEW_TIMEOUT);
1403+
}, SCROLLVIEW_TIMEOUT);
14041404
});
14051405

14061406
QUnit.test('should be scrolled down after showing if was initially rendered inside an invisible element', function(assert) {

0 commit comments

Comments
 (0)