UI.Gantt: fix task sorting when the sort column is hidden. (T1283506) (#29537)

Author: PavelMor25

packages/devextreme/js/__internal/grids/grid_core/columns_controller/m_columns_controller.ts

@@ -314,7 +314,7 @@ export class ColumnsController extends modules.Controller {
   }
 
   public publicMethods() {
-    return ['addColumn', 'deleteColumn', 'columnOption', 'columnCount', 'clearSorting', 'clearGrouping', 'getVisibleColumns', 'getVisibleColumnIndex'];
+    return ['addColumn', 'deleteColumn', 'columnOption', 'columnCount', 'clearSorting', 'clearGrouping', 'getVisibleColumns', 'getVisibleColumnIndex', 'getColumns'];
   }
 
   public applyDataSource(dataSource, forceApplying?, isApplyingUserState?) {

packages/devextreme/js/ui/gantt/ui.gantt.js

@@ -397,7 +397,7 @@ class Gantt extends Widget {
 
     _sortAndFilter() {
         const treeList = this._treeList;
-        const columns = treeList.getVisibleColumns();
+        const columns = treeList.getColumns();
 
         const sortedColumns = columns.filter(c => c.sortIndex > -1);
         const sortedState = sortedColumns.map(c => ({ sortIndex: c.sortIndex, sortOrder: c.sortOrder }));

packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/virtualColumns.tests.js

@@ -36,10 +36,6 @@ const setupModule = function() {
         }, options));
     };
 
-    this.getColumns = function(parameterNames) {
-        return this.columnsController.getColumns();
-    };
-
     this.getFixedColumns = function(parameterNames) {
         return this.columnsController.getFixedColumns();
     };
@@ -537,10 +533,6 @@ const setupRenderingModule = function() {
         }, options));
     };
 
-    this.getColumns = function(parameterNames) {
-        return this.columnsController.getColumns();
-    };
-
     this.clock = sinon.useFakeTimers();
 };
 

packages/devextreme/testing/tests/DevExpress.ui.widgets/ganttParts/sorting.tests.js

@@ -522,4 +522,55 @@ QUnit.module('Sorting', moduleConfig, () => {
         assert.equal(this.instance._treeList.getVisibleRows().length, 3);
     });
 
+    test('check sorting by invisible column (T1283506)', function(assert) {
+        const start = new Date('2019-02-21');
+        const end = new Date('2019-02-26');
+        const tasks = [
+            { 'id': 1, 'parentId': 0, 'title': 'Software Development', 'start': new Date('2019-02-21'), 'end': new Date('2019-02-22'), 'progress': 0 },
+            { 'id': 2, 'parentId': 1, 'title': 'Scope', 'start': new Date('2019-02-20'), 'end': new Date('2019-02-22'), 'progress': 0 },
+            { 'id': 3, 'parentId': 1, 'title': 'Determine project scope', 'start': start, 'end': end, 'progress': 50 }
+        ];
+        const options = {
+            tasks: { dataSource: tasks },
+            validation: { autoUpdateParentTasks: false },
+            sorting: { mode: 'single' },
+            columns:
+            [
+                {
+                    dataField: 'id',
+                },
+                {
+                    dataField: 'title'
+                },
+                {
+                    dataField: 'start',
+                    visible: false,
+                    sortOrder: 'desc'
+                }
+            ]
+        };
+
+        this.createInstance(options);
+        this.clock.tick(10);
+
+        const treeListIdText1 = $(this.instance._treeList.getCellElement(0, 0)).text();
+        const treeListTitleText1 = $(this.instance._treeList.getCellElement(0, 1)).text();
+        const treeListIdText2 = $(this.instance._treeList.getCellElement(1, 0)).text();
+        const treeListTitleText2 = $(this.instance._treeList.getCellElement(1, 1)).text();
+        const treeListIdText3 = $(this.instance._treeList.getCellElement(2, 0)).text();
+        const treeListTitleText3 = $(this.instance._treeList.getCellElement(2, 1)).text();
+
+        const taskText1 = this.$element.find(Consts.TASK_SELECTOR)[0].textContent;
+        const taskText2 = this.$element.find(Consts.TASK_SELECTOR)[1].textContent;
+        const taskText3 = this.$element.find(Consts.TASK_SELECTOR)[2].textContent;
+
+        assert.equal(treeListIdText1, '1');
+        assert.equal(treeListIdText2, '3');
+        assert.equal(treeListIdText3, '2');
+
+        assert.equal(treeListTitleText1, taskText1);
+        assert.equal(treeListTitleText2, taskText2);
+        assert.equal(treeListTitleText3, taskText3);
+    });
+
 });