Skip to content

Commit 3ec77ef

Browse files
authored
CardView: disable FilterSync feature (#30166)
1 parent af7a746 commit 3ec77ef

File tree

9 files changed

+11
-38
lines changed

9 files changed

+11
-38
lines changed

e2e/testcafe-devextreme/tests/cardView/filterSync/api.functional.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import CardView from 'devextreme-testcafe-models/cardView';
22
import url from '../../../helpers/getPageUrl';
33
import { createWidget } from '../../../helpers/createWidget';
44

5-
fixture.disablePageReloads`CardView - FilterSync API`
5+
// NOTE: Skip tests because FilterSync feature disabled
6+
fixture.skip`CardView - FilterSync API`
67
.page(url(__dirname, '../../container.html'));
78

89
const baseConfig = {

packages/devextreme-angular/src/ui/card-view/index.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -363,16 +363,6 @@ export class DxCardViewComponent<TCardData = any, TKey = any> extends DxComponen
363363

364364

365365

366-
@Input()
367-
get filterSyncEnabled(): boolean | Mode {
368-
return this._getOption('filterSyncEnabled');
369-
}
370-
set filterSyncEnabled(value: boolean | Mode) {
371-
this._setOption('filterSyncEnabled', value);
372-
}
373-
374-
375-
376366
@Input()
377367
get filterValue(): Array<any> | Function | string {
378368
return this._getOption('filterValue');
@@ -1015,13 +1005,6 @@ export class DxCardViewComponent<TCardData = any, TKey = any> extends DxComponen
10151005
*/
10161006
@Output() filterPanelChange: EventEmitter<FilterPanel>;
10171007

1018-
/**
1019-
1020-
* This member supports the internal infrastructure and is not intended to be used directly from your code.
1021-
1022-
*/
1023-
@Output() filterSyncEnabledChange: EventEmitter<boolean | Mode>;
1024-
10251008
/**
10261009
10271010
* This member supports the internal infrastructure and is not intended to be used directly from your code.
@@ -1274,7 +1257,6 @@ export class DxCardViewComponent<TCardData = any, TKey = any> extends DxComponen
12741257
{ emit: 'filterBuilderChange' },
12751258
{ emit: 'filterBuilderPopupChange' },
12761259
{ emit: 'filterPanelChange' },
1277-
{ emit: 'filterSyncEnabledChange' },
12781260
{ emit: 'filterValueChange' },
12791261
{ emit: 'focusStateEnabledChange' },
12801262
{ emit: 'headerFilterChange' },

packages/devextreme-vue/src/card-view.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ type AccessibleOptions = Pick<Properties,
219219
"filterBuilder" |
220220
"filterBuilderPopup" |
221221
"filterPanel" |
222-
"filterSyncEnabled" |
223222
"filterValue" |
224223
"focusStateEnabled" |
225224
"headerFilter" |
@@ -305,7 +304,6 @@ const componentConfig = {
305304
filterBuilder: Object as PropType<dxFilterBuilderOptions | Record<string, any>>,
306305
filterBuilderPopup: Object as PropType<Record<string, any>>,
307306
filterPanel: Object as PropType<FilterPanel>,
308-
filterSyncEnabled: [Boolean, String] as PropType<boolean | Mode>,
309307
filterValue: [Array, Function, String] as PropType<Array<any> | ((() => any)) | string>,
310308
focusStateEnabled: Boolean,
311309
headerFilter: Object as PropType<HeaderFilter | Record<string, any>>,
@@ -387,7 +385,6 @@ const componentConfig = {
387385
"update:filterBuilder": null,
388386
"update:filterBuilderPopup": null,
389387
"update:filterPanel": null,
390-
"update:filterSyncEnabled": null,
391388
"update:filterValue": null,
392389
"update:focusStateEnabled": null,
393390
"update:headerFilter": null,

packages/devextreme/js/__internal/grids/new/grid_core/filtering/filter_controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export class FilterController {
2929

3030
public readonly filterBuilderOptions = this.options.twoWay('filterBuilder');
3131

32-
public readonly filterSyncEnabledOption = this.options.oneWay('filterSyncEnabled');
32+
public readonly filterSyncEnabledOption = this.options.oneWay('_filterSyncEnabled');
3333

3434
public static dependencies = [
3535
OptionsController,

packages/devextreme/js/__internal/grids/new/grid_core/filtering/filter_sync/controller.integration.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ const TEST_CASES_GROUPS: TestCasesGroup[] = [
118118
},
119119
];
120120

121-
describe('FilterSync', () => {
121+
// NOTE: Skip tests because FilterSync feature disabled
122+
describe.skip('FilterSync', () => {
122123
TEST_CASES_GROUPS.forEach(({
123124
groupName,
124125
dataSource,
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import type { Mode } from '@js/common';
22

33
export interface Options {
4-
filterSyncEnabled?: boolean | Mode;
4+
// NOTE: Underscore for option name because FilterSync feature disabled
5+
_filterSyncEnabled?: boolean | Mode;
56
}
67

78
export const defaultOptions: Options = {
8-
filterSyncEnabled: 'auto',
9+
_filterSyncEnabled: false,
910
};

packages/devextreme/js/__internal/grids/new/grid_core/filtering/header_filter/options.integration.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,8 @@ describe('Options', () => {
272272
expect(popupContentElement).toMatchSnapshot();
273273
});
274274

275-
it.each<{
275+
// NOTE: Skip test because FilterSync feature disabled
276+
it.skip.each<{
276277
filterValue: Filter; result: number;
277278
}>([
278279
{
@@ -290,7 +291,7 @@ describe('Options', () => {
290291
headerFilter: {
291292
visible: true,
292293
},
293-
filterSyncEnabled: true,
294+
_filterSyncEnabled: true,
294295
filterPanel: { visible: true },
295296
});
296297

packages/devextreme/js/ui/card_view.d.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,12 +1474,6 @@ export interface dxCardViewOptions<TCardData = unknown, TKey = unknown> extends
14741474
*/
14751475
sorting?: Sorting;
14761476

1477-
/**
1478-
* @docid
1479-
* @default "auto"
1480-
* @public
1481-
*/
1482-
filterSyncEnabled?: boolean | Mode;
14831477
/**
14841478
* @docid
14851479
* @type Filter expression

packages/devextreme/ts/dx.all.d.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10791,10 +10791,6 @@ declare module DevExpress.ui {
1079110791
*/
1079210792
sorting?: DevExpress.common.grids.Sorting;
1079310793

10794-
/**
10795-
* [descr:dxCardViewOptions.filterSyncEnabled]
10796-
*/
10797-
filterSyncEnabled?: boolean | DevExpress.common.Mode;
1079810794
/**
1079910795
* [descr:dxCardViewOptions.filterValue]
1080010796
*/

0 commit comments

Comments
 (0)