revert some changes

Author: EugeniyKiyashko

.github/workflows/testcafe_tests.yml

@@ -62,13 +62,12 @@ jobs:
         path: |
           ${{ env.STORE_PATH }}
           .nx/cache
-          node_modules/.cache
         key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
         restore-keys: |
           ${{ runner.os }}-pnpm-store
 
     - name: Install dependencies
-      run: pnpm install --frozen-lockfile --prefer-offline
+      run: pnpm install --frozen-lockfile
 
     - name: Build
       shell: bash
@@ -167,18 +166,17 @@ jobs:
         path: |
           ${{ env.STORE_PATH }}
           .nx/cache
-          node_modules/.cache
         key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
         restore-keys: |
           ${{ runner.os }}-pnpm-store
 
     - name: Install dependencies
-      run: pnpm install --frozen-lockfile --prefer-offline
+      run: pnpm install --frozen-lockfile
 
     - name: Run TestCafe tests
       working-directory: ./e2e/testcafe-devextreme
       env:
-        NODE_OPTIONS: --max-old-space-size=8192 --max-semi-space-size=1024
+        NODE_OPTIONS: --max-old-space-size=8192
       run: |
         if [ "${{ matrix.ARGS.theme }}" != "" ]; then
           THEME="--theme ${{ matrix.ARGS.theme }}"

e2e/testcafe-devextreme/runner.ts

@@ -161,6 +161,7 @@ async function main() {
     console.info('Browsers:', browsers);
 
     const failedTests: Set<string> = new Set();
+    let isRetryRun = false;
 
     const createRunner = (filterByFailedTests = false) => {
       const runner: Runner = testCafe!.createRunner()
@@ -282,7 +283,7 @@ async function main() {
           after: async (t: TestController) => {
             await clearTestPage(t);
 
-            if (args.retryFailed) {
+            if (args.retryFailed && !isRetryRun) {
               // @ts-expect-error ts-errors
               const { test, errs } = t.testRun;
               if (errs && errs.length > 0) {
@@ -325,11 +326,13 @@ async function main() {
         const testsToRetry = new Set(failedTests);
         failedTests.clear();
 
+        isRetryRun = true;
         const retryRunner = createRunner(true);
         failedCount = await retry(
           () => retryRunner.run(runOptions),
           LAUNCH_RETRY_ATTEMPTS,
         );
+        isRetryRun = false;
 
         attemptsLeft -= 1;
 
@@ -340,7 +343,7 @@ async function main() {
         console.info('='.repeat(60));
         console.info(`Tests retried: ${testsToRetry.size}`);
         console.info(`Still failing: ${failedCount}`);
-        console.info(`Passed on this attempt: ${testsToRetry.size - failedCount}`);
+        console.info(`Passed on this attempt: ${Math.max(0, testsToRetry.size - failedCount)}`);
         console.info('='.repeat(60));
         console.info('\n');
         /* eslint-enable no-console */

e2e/testcafe-devextreme/tests/cardView/keyboardNavigation/header.functional.ts

@@ -8,7 +8,7 @@ import { addFocusableElementBefore } from '../../../helpers/domUtils';
 // It triggers this event on document level and process keyboard navigation action immediately.
 // Therefore, it's impossible to test switching focus between areas in TestCafe
 // Because this feature works with event bubbling + inert attribute
-fixture`KeyboardNavigation.Header`
+fixture.disablePageReloads`KeyboardNavigation.Header`
   .page(url(__dirname, '../../container.html'));
 
 const CARD_VIEW_SELECTOR = '#container';

e2e/testcafe-devextreme/tests/common/treeList/focusedRow.ts

@@ -7,7 +7,7 @@ const clearLocalStorage = ClientFunction(() => {
   (window as any).localStorage.removeItem('mystate');
 });
 
-fixture`Focused row`
+fixture.disablePageReloads`Focused row`
   .page(url(__dirname, '../../container.html'));
 
 const getItems = (): Record<string, unknown>[] => {

e2e/testcafe-devextreme/tests/common/treeList/keyboardNavigation/keyboardNavigation.functional.ts

@@ -103,7 +103,7 @@ test('TreeList - Template button in a data row isn\'t navigable with Tab button
   }, '#otherContainer');
 });
 
-test.meta({ unstable: true })('TreeList - Keyboard navigation on Expand/Collapse buttons is broken if the mouse used before (T1234949)', async (t) => {
+test('TreeList - Keyboard navigation on Expand/Collapse buttons is broken if the mouse used before (T1234949)', async (t) => {
   const treeList = new TreeList('#container');
   const target = treeList.getDataRow(0).getDataCell(0);
 

e2e/testcafe-devextreme/tests/common/treeList/scrolling.ts

@@ -19,7 +19,7 @@ const scrollWindowTo = async (position: object) => {
   )();
 };
 
-fixture`Virtual Scrolling`
+fixture.disablePageReloads`Virtual Scrolling`
   .page(url(__dirname, '../../container.html'));
 
 function generateData(rowCount): Record<string, unknown>[] {

e2e/testcafe-devextreme/tests/common/treeList/selection.ts

@@ -7,7 +7,7 @@ import { createWidget } from '../../../helpers/createWidget';
 import { tasksApiMock } from './apiMocks/tasksApiMock';
 import { testScreenshot } from '../../../helpers/themeUtils';
 
-fixture`Selection`
+fixture.disablePageReloads`Selection`
   .page(url(__dirname, '../../container.html'));
 
 // T1109666

e2e/testcafe-devextreme/tests/dataGrid/common/editing.ts

@@ -2796,8 +2796,7 @@ test('Cells should be focused correctly on click when cell editing mode is used
 
   // act
   await t
-    .click(dataGrid.getDataCell(0, 0).getEditor().element)
-    .wait(50);
+    .click(dataGrid.getDataCell(0, 0).getEditor().element);
 
   // assert
   await t
@@ -2810,8 +2809,7 @@ test('Cells should be focused correctly on click when cell editing mode is used
   await t
     .typeText(dataGrid.getDataCell(0, 0).getEditor().element, '1')
     .wait(50)
-    .click(dataGrid.getDataCell(1, 0).getEditor().element)
-    .wait(50);
+    .click(dataGrid.getDataCell(1, 0).getEditor().element);
 
   // assert
   await t
@@ -2826,8 +2824,7 @@ test('Cells should be focused correctly on click when cell editing mode is used
   await t
     .typeText(dataGrid.getDataCell(1, 0).getEditor().element, '2')
     .wait(50)
-    .click(dataGrid.getDataCell(2, 0).getEditor().element)
-    .wait(50);
+    .click(dataGrid.getDataCell(2, 0).getEditor().element);
 
   // assert
   await t
@@ -2842,8 +2839,7 @@ test('Cells should be focused correctly on click when cell editing mode is used
   await t
     .typeText(dataGrid.getDataCell(2, 0).getEditor().element, '3')
     .wait(50)
-    .click(dataGrid.getDataCell(1, 0).getEditor().element)
-    .wait(50);
+    .click(dataGrid.getDataCell(1, 0).getEditor().element);
 
   // assert
   await t
@@ -2858,8 +2854,7 @@ test('Cells should be focused correctly on click when cell editing mode is used
   await t
     .typeText(dataGrid.getDataCell(1, 0).getEditor().element, '2')
     .wait(50)
-    .click(dataGrid.getDataCell(0, 0).getEditor().element)
-    .wait(50);
+    .click(dataGrid.getDataCell(0, 0).getEditor().element);
 
   // assert
   await t

e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/columnReordering.visual.ts

@@ -1355,7 +1355,6 @@ test('reorder column to left when adaptability is enabled and there are hidden c
       .expect(firstHeader.element.textContent)
       .contains('Field');
 
-    await t.debug();
     await testScreenshot(t, takeScreenshot, `reorder_column_when_there_are_async_templates_and_renderAsync_=_${renderAsync}.png`, { element: dataGrid.element });
 
     await t.expect(compareResults.isValid())

e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.visual.ts

@@ -404,7 +404,7 @@ test('Focus the first cell in the firs row when pressing the Ctrl+Home key', asy
   showBorders: true,
 }));
 
-test.meta({ unstable: true })('Navigate to last cell in the last row when pressing the Ctrl+End key', async (t) => {
+test('Navigate to last cell in the last row when pressing the Ctrl+End key', async (t) => {
   // arrange
   const dataGrid = new DataGrid('#container');
   const { takeScreenshot, compareResults } = createScreenshotsComparer(t);