Skip to content

Commit 5ec426a

Browse files
List: reduce count of accessibility checks (#29413)
1 parent dce7887 commit 5ec426a

File tree

4 files changed

+42
-21
lines changed

4 files changed

+42
-21
lines changed

.github/workflows/testcafe_tests.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,6 @@ jobs:
8888
{ componentFolder: "accessibility/common", name: "accessibility - fluent (5/7)", theme: "fluent.blue.light", indices: "5/7" },
8989
{ componentFolder: "accessibility/common", name: "accessibility - fluent (6/7)", theme: "fluent.blue.light", indices: "6/7" },
9090
{ componentFolder: "accessibility/common", name: "accessibility - fluent (7/7)", theme: "fluent.blue.light", indices: "7/7" },
91-
{ componentFolder: "accessibility/list", name: "accessibility - list (1/2)", indices: "1/2" },
92-
{ componentFolder: "accessibility/list", name: "accessibility - list (1/2)", indices: "2/2" },
93-
{ componentFolder: "accessibility/list", name: "accessibility - list - material (1/2)", theme: "material.blue.light", indices: "1/2" },
94-
{ componentFolder: "accessibility/list", name: "accessibility - list - material (1/2)", theme: "material.blue.light", indices: "2/2" },
95-
{ componentFolder: "accessibility/list", name: "accessibility - list - fluent (1/2)", theme: "fluent.blue.light", indices: "1/2" },
96-
{ componentFolder: "accessibility/list", name: "accessibility - list - fluent (1/2)", theme: "fluent.blue.light", indices: "2/2" },
9791
{ componentFolder: "common", name: "common" },
9892
{ componentFolder: "common", name: "common - material", theme: 'material.blue.light' },
9993
{ componentFolder: "common", name: "common - fluent", theme: 'fluent.blue.light' },

e2e/testcafe-devextreme/tests/accessibility/list/complexItems.ts renamed to e2e/testcafe-devextreme/tests/accessibility/common/list/groupedItems.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Properties } from 'devextreme/ui/list.d';
2-
import url from '../../../helpers/getPageUrl';
3-
import { testAccessibility, Configuration } from '../../../helpers/accessibility/test';
4-
import { Options } from '../../../helpers/generateOptionMatrix';
2+
import url from '../../../../helpers/getPageUrl';
3+
import { testAccessibility, Configuration } from '../../../../helpers/accessibility/test';
4+
import { Options } from '../../../../helpers/generateOptionMatrix';
55

66
fixture.disablePageReloads`Accessibility`
77
.page(url(__dirname, '../../container.html'));
@@ -39,15 +39,12 @@ const groupedItems = [[
3939

4040
const options: Options<Properties> = {
4141
dataSource: [groupedItems],
42-
height: [undefined, 400],
42+
height: [400],
4343
grouped: [true],
4444
collapsibleGroups: [true, false],
4545
searchEnabled: [true, false],
46-
allowItemDeleting: [true, false],
47-
showSelectionControls: [true, false],
46+
showSelectionControls: [true],
4847
selectionMode: ['all', 'multiple', 'none', 'single'],
49-
itemDeleteMode: ['toggle', 'context', 'slideButton', 'slideItem', 'static', 'swipe'],
50-
useNativeScrolling: [true, false],
5148
};
5249

5350
const a11yCheckConfig = {
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
import { Properties } from 'devextreme/ui/list.d';
2+
import { Options } from '../../../../helpers/generateOptionMatrix';
3+
import url from '../../../../helpers/getPageUrl';
4+
import { Configuration, testAccessibility } from '../../../../helpers/accessibility/test';
5+
6+
fixture.disablePageReloads`Accessibility`
7+
.page(url(__dirname, '../../container.html'));
8+
9+
const simpleItems = ['Item_1', 'Item_2', 'Item_3'];
10+
11+
const optionsWithSimpleItems: Options<Properties> = {
12+
dataSource: [simpleItems],
13+
height: [400],
14+
grouped: [false],
15+
searchEnabled: [true],
16+
allowItemDeleting: [true, false],
17+
itemDeleteMode: ['toggle', 'context', 'slideButton', 'slideItem', 'static', 'swipe'],
18+
};
19+
20+
const a11yCheckConfig = {
21+
rules: {
22+
// NOTE: color-contrast issues
23+
'color-contrast': { enabled: false },
24+
},
25+
};
26+
27+
const configurationWithSimpleItems: Configuration = {
28+
component: 'dxList',
29+
a11yCheckConfig,
30+
options: optionsWithSimpleItems,
31+
};
32+
33+
testAccessibility(configurationWithSimpleItems);

e2e/testcafe-devextreme/tests/accessibility/list/simpleItems.ts renamed to e2e/testcafe-devextreme/tests/accessibility/common/list/simpleItems.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Properties } from 'devextreme/ui/list.d';
2-
import { Options } from '../../../helpers/generateOptionMatrix';
3-
import url from '../../../helpers/getPageUrl';
4-
import { Configuration, testAccessibility } from '../../../helpers/accessibility/test';
2+
import { Options } from '../../../../helpers/generateOptionMatrix';
3+
import url from '../../../../helpers/getPageUrl';
4+
import { Configuration, testAccessibility } from '../../../../helpers/accessibility/test';
55

66
fixture.disablePageReloads`Accessibility`
77
.page(url(__dirname, '../../container.html'));
@@ -10,14 +10,11 @@ const simpleItems = ['Item_1', 'Item_2', 'Item_3'];
1010

1111
const optionsWithSimpleItems: Options<Properties> = {
1212
dataSource: [[], simpleItems],
13-
height: [undefined, 400],
13+
height: [400],
1414
grouped: [false],
1515
searchEnabled: [true, false],
16-
allowItemDeleting: [true, false],
1716
showSelectionControls: [true, false],
1817
selectionMode: ['all', 'multiple', 'none', 'single'],
19-
itemDeleteMode: ['toggle', 'context', 'slideButton', 'slideItem', 'static', 'swipe'],
20-
useNativeScrolling: [true, false],
2118
};
2219

2320
const a11yCheckConfig = {

0 commit comments

Comments
 (0)