Skip to content

Commit 5f4e7ee

Browse files
e2e tests: remove safeTestSize utility (#31259)
1 parent c214744 commit 5f4e7ee

File tree

212 files changed

+1017
-1124
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

212 files changed

+1017
-1124
lines changed

.github/workflows/testcafe_tests.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,8 @@ jobs:
102102
{ componentFolder: "dataGrid/common", name: "dataGrid / common (3/5)", indices: "3/5" },
103103
{ componentFolder: "dataGrid/common", name: "dataGrid / common (4/5)", indices: "4/5" },
104104
{ componentFolder: "dataGrid/common", name: "dataGrid / common (5/5)", indices: "5/5" },
105-
{ componentFolder: "dataGrid/sticky/common", name: "dataGrid / sticky common" },
106-
{ componentFolder: "dataGrid/sticky/fixed", name: "dataGrid / sticky (1/3)", indices: "1/3" },
107-
{ componentFolder: "dataGrid/sticky/fixed", name: "dataGrid / sticky (2/3)", indices: "2/3" },
108-
{ componentFolder: "dataGrid/sticky/fixed", name: "dataGrid / sticky (3/3)", indices: "3/3" },
105+
{ componentFolder: "dataGrid/sticky", name: "dataGrid / sticky (1/2)", indices: "1/2" },
106+
{ componentFolder: "dataGrid/sticky", name: "dataGrid / sticky (2/2)", indices: "2/2" },
109107
{ componentFolder: "cardView", name: "cardView" },
110108

111109
# Scheduler tests need to be reworked to work in fluent theme
@@ -120,8 +118,7 @@ jobs:
120118
{ componentFolder: "scheduler/timezones", name: "scheduler / timezones (Europe/Berlin)", timezone: "Europe/Berlin", theme: 'generic.light' },
121119
{ componentFolder: "scheduler/timezones", name: "scheduler / timezones (America/Los_Angeles)", timezone: "America/Los_Angeles", theme: 'generic.light' },
122120

123-
{ componentFolder: "editors", name: "editors (1/2)", indices: "1/2" },
124-
{ componentFolder: "editors", name: "editors (2/2)", indices: "2/2" },
121+
{ componentFolder: "editors", name: "editors" },
125122
{ componentFolder: "navigation", name: "navigation" },
126123
]
127124
runs-on: devextreme-shr2

apps/demos/Demos/Stepper/StepTemplate/Angular/app/app.component.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
border-radius: 4px;
6868
}
6969

70-
::ng-deep #iconOnly :is(.dx-step-selected, .dx-step-completed) .dx-icon {
71-
color: var(--dx-color-primary);
70+
::ng-deep #iconOnly .dx-step-selected .dx-icon,
71+
::ng-deep #iconOnly .dx-step-completed .dx-icon {
72+
color: var(--dx-color-primary);
7273
}

apps/demos/testing/widgets/dropdownbutton/DropDownButton.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,14 @@ runManualTest('DropDownButton', 'Overview', (test) => {
1717

1818
await t
1919
.click($(`.${DROP_DOWN_BUTTON_CLASS}`).nth(0));
20-
// .wait(200);
2120

2221
await testScreenshot(t, takeScreenshot, 'dropdown_button_overview_custom_static_text.png');
2322

2423
await t
2524
.click($(`.${DROP_DOWN_BUTTON_CLASS}`).nth(0));
26-
// .wait(200);
2725

2826
await t
2927
.click($(`.${DROP_DOWN_BUTTON_TOGGLE_CLASS}`));
30-
// .wait(200);
3128

3229
await testScreenshot(t, takeScreenshot, 'dropdown_button_overview_custom_button_action.png');
3330

apps/demos/testing/widgets/lookup/Lookup.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@ runManualTest('Lookup', 'Basics', (test) => {
1616

1717
await t
1818
.click($(`.${LOOKUP_CLASS}`).nth(0));
19-
// .wait(200);
2019

2120
await t
2221
.click($(`.${LOOKUP_CLASS}`).nth(1));
23-
// .wait(200);
2422

2523
await testScreenshot(t, takeScreenshot, 'lookup_templates_custom_appearance.png');
2624

apps/demos/testing/widgets/tabpanel/Overview.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,18 @@ runManualTest('TabPanel', 'Overview', (test) => {
2222
await t
2323
.click($selectBox.nth(0))
2424
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(1));
25-
// .wait(200);
2625

2726
await testScreenshot(t, takeScreenshot, 'tabpanel_tabsposition_top.png');
2827

2928
await t
3029
.click($selectBox.nth(1))
3130
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(1));
32-
// .wait(200);
3331

3432
await testScreenshot(t, takeScreenshot, 'tabpanel_stylingmode_primary.png');
3533

3634
await t
3735
.click($selectBox.nth(2))
3836
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(1));
39-
// .wait(200);
4037

4138
await testScreenshot(t, takeScreenshot, 'tabpanel_iconposition_start.png');
4239

apps/demos/testing/widgets/tabs/Overview.test.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,54 +21,46 @@ runManualTest('Tabs', 'Overview', (test) => {
2121
await t
2222
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(0))
2323
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(1));
24-
// .wait(200);
2524

2625
await testScreenshot(t, takeScreenshot, 'tabs_orientation_vertical.png');
2726

2827
await t
2928
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(1))
3029
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(1));
31-
// .wait(200);
3230

3331
await testScreenshot(t, takeScreenshot, 'tabs_stylingmode_secondary.png');
3432

3533
await t
3634
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(2))
3735
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(2));
38-
// .wait(200);
3936

4037
await testScreenshot(t, takeScreenshot, 'tabs_iconposition_end.png');
4138

4239
await t
4340
.click($(`.${OPTION_CLASS} .${CHECKBOX_CLASS}`).nth(3));
44-
// .wait(200);
4541

4642
await testScreenshot(t, takeScreenshot, 'tabs_rtlenabled_true.png');
4743

4844
await t
4945
.click($(`.${OPTION_CLASS} .${CHECKBOX_CLASS}`).nth(3))
5046
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(0))
5147
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(0));
52-
// .wait(200);
5348

5449
await t
5550
.click($(`.${OPTION_CLASS} .${CHECKBOX_CLASS}`).nth(0));
56-
// .wait(200);
5751

5852
await testScreenshot(t, takeScreenshot, 'tabs_shownavbuttons_true.png');
5953

6054
await t
6155
.click($(`.${OPTION_CLASS} .${CHECKBOX_CLASS}`).nth(2))
6256
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(0))
6357
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(1));
64-
// .wait(200);
6558

6659
await testScreenshot(t, takeScreenshot, 'tabs_orientation_vertical_without_strict_class.png');
6760

6861
await t
6962
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(0))
7063
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(0));
71-
// .wait(200);
7264

7365
await testScreenshot(t, takeScreenshot, 'tabs_orientation_horizontal_with_strict_class.png');
7466

apps/demos/testing/widgets/tabs/Selection.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,12 @@ runManualTest('Tabs', 'Selection', (test) => {
2121

2222
await t
2323
.click($(`.${TABS_WRAPPER_CLASS} .${TAB_CLASS}`).nth(1));
24-
// .wait(200);
2524

2625
await testScreenshot(t, takeScreenshot, 'tabs_second_item_selection.png');
2726

2827
await t
2928
.click($(`.${SELECT_BOX_CONTAINER_CLASS} .${SELECTBOX_CLASS}`).nth(0))
3029
.click($(`.${SELECTBOX_POPUP_WRAPPER_CLASS} .${LIST_ITEM_CLASS}`).nth(2));
31-
// .wait(200);
3230

3331
await testScreenshot(t, takeScreenshot, 'tabs_third_item_selection.png');
3432

apps/demos/testing/widgets/treeview/ItemSelectionAndCustomization.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ runManualTest('TreeView', 'ItemSelectionAndCustomization', (test) => {
1717

1818
await t
1919
.click($(`.${OPTION_CLASS} .${SELECTBOX_CLASS}`).nth(0));
20-
// .wait(200);
2120

2221
await testScreenshot(t, takeScreenshot, 'treeview_selection_field_is_open.png');
2322

apps/demos/testing/widgets/vectormap/VectorMapZooming.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ fixture('VectorMap.DynamicViewport')
1111
runManualTest('VectorMap', 'DynamicViewport', (test) => {
1212
test('VectorMap.DynamicViewport', async (t) => {
1313
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
14-
const zoomButton = $($('#vector-map .dxm-control-bar g').nth(1)).find('circle').nth(0);
14+
const zoomButton = $($('#vector-map .dxm-control-bar g').nth(1));
1515
const showSelectBoxItems = () => t.click($('.options .dx-dropdowneditor-input-wrapper input.dx-texteditor-input'));
1616
const selectItem = (index) => $('.dx-dropdowneditor-overlay .dx-list-item-content').nth(index);
1717

18-
await t.click(zoomButton);
19-
await t.click(zoomButton);
18+
await t.click(zoomButton, { offsetX: 10, offsetY: 10 });
19+
await t.click(zoomButton, { offsetX: 10, offsetY: 10 });
2020
await testScreenshot(t, takeScreenshot, 'zoom_vector_map_by_control_bar.png');
2121

2222
await showSelectBoxItems();

apps/demos/utils/visual-tests/matrix-test-helper.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,21 +220,22 @@ const SKIPPED_TESTS = {
220220
],
221221
},
222222
Angular: {
223+
Charts: ['Crosshair'],
223224
Common: ['PopupAndNotificationsOverview'],
224225
DataGrid: ['EditStateManagement', 'Toolbar', 'RemoteGrouping'],
225226
Scheduler: ['ContextMenu'],
226227
FileUploader: ['CustomDropzone'],
227-
// TODO: make this more stable
228-
// Stepper: ['StepTemplate'],
229228
},
230229
Vue: {
230+
Charts: ['Crosshair'],
231231
Common: ['PopupAndNotificationsOverview'],
232232
// NOTE: Context menu item position is different across themes
233233
Scheduler: ['ContextMenu'],
234234
DataGrid: ['EditStateManagement', 'Toolbar', 'RemoteGrouping'],
235235
FileUploader: ['CustomDropzone']
236236
},
237237
React: {
238+
Charts: ['Crosshair'],
238239
Common: ['PopupAndNotificationsOverview'],
239240
Scheduler: ['ContextMenu'],
240241
DataGrid: ['EditStateManagement', 'Toolbar', 'RemoteGrouping'],

0 commit comments

Comments
 (0)