Splitter: resizeHandle should not be duplicated when changing the template option at runtime (T1279224) (#29466)

Author: EugeniyKiyashko

packages/devextreme/js/__internal/ui/splitter/splitter.ts

@@ -547,7 +547,7 @@ class Splitter extends CollectionWidgetLiveUpdate<Properties> {
           event,
           handleElement: getPublicElement<HTMLElement>($resizeHandle),
         };
-        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+
         this._feedbackDeferred?.resolve();
         this._toggleActiveState($resizeHandle, false);
 
@@ -688,6 +688,12 @@ class Splitter extends CollectionWidgetLiveUpdate<Properties> {
         this._itemVisibleOptionChanged(item, value as PropertyType, prevValue as PropertyType);
         break;
       }
+      case 'template':
+        super._itemOptionChanged(item, property, value, prevValue);
+
+        this._applyStylesFromLayout(this.getLayout());
+        this._updateResizeHandles();
+        break;
       default:
         super._itemOptionChanged(item, property, value, prevValue);
     }

packages/devextreme/js/__internal/ui/splitter/splitter_item.ts

@@ -82,6 +82,12 @@ class SplitterItem extends CollectionWidgetItem<Item> {
   isLast(): boolean {
     return this._owner._isLastVisibleItem(this.getIndex());
   }
+
+  _dispose(): void {
+    this._removeResizeHandle();
+
+    super._dispose();
+  }
 }
 
 export default SplitterItem;

packages/devextreme/testing/tests/DevExpress.ui.widgets/splitter.tests.js

@@ -1607,6 +1607,47 @@ QUnit.module('Pane visibility', moduleConfig, () => {
     });
 });
 
+QUnit.module('Pane.template', moduleConfig, () => {
+    QUnit.test('ResizeHandle should not be duplicated when changing the template option at runtime (T1279224)', function(assert) {
+        const firstPaneTemplate = () => $('<div>').text('Pane 1');
+        const secondPaneTemplate = () => $('<div>').text('Pane 2');
+
+        this.reinit({
+            dataSource: [{
+                template: firstPaneTemplate
+            }, {
+                template: secondPaneTemplate
+            }]
+        });
+
+        this.instance.option({
+            'items[0].template': secondPaneTemplate,
+            'items[1].template': firstPaneTemplate,
+        });
+
+        assert.strictEqual(this.getResizeHandles().length, 1);
+    });
+
+    QUnit.test('Layout should restore the distribution when changing the template option at runtime (T1279224)', function(assert) {
+        const firstPaneTemplate = () => $('<div>').text('Pane 1');
+        const secondPaneTemplate = () => $('<div>').text('Pane 2');
+
+        this.reinit({
+            dataSource: [{
+                size: '300px',
+                template: firstPaneTemplate
+            }, {
+                template: secondPaneTemplate
+            }]
+        });
+
+        this.instance.option('items[0].template', secondPaneTemplate);
+
+        this.checkItemSizes([300, 692]);
+        this.assertLayout(['30.2419', '69.7581']);
+    });
+});
+
 QUnit.module('Resizing', moduleConfig, () => {
     ['horizontal', 'vertical'].forEach(orientation => {
         QUnit.test(`collapsed pane should move its neighboring pane on expansion to left, orientation ${orientation}`, function(assert) {
@@ -2931,6 +2972,24 @@ QUnit.module('Visibility of control elements', {
             });
         });
     });
+
+    QUnit.test('ResizeHandle control elements visibility should be updated when changing the template option at runtime (T1279224)', function(assert) {
+        const firstPaneTemplate = () => $('<div>').text('Pane 1');
+        const secondPaneTemplate = () => $('<div>').text('Pane 2');
+
+        this.reinit({
+            dataSource: [{
+                template: firstPaneTemplate
+            }, {
+                template: secondPaneTemplate,
+                collapsible: true,
+            }]
+        });
+
+        this.instance.option('items[0].template', secondPaneTemplate);
+
+        this.checkIconsVisibility([{ prev: false, resize: true, next: true }]);
+    });
 });
 
 QUnit.module('Events', moduleConfig, () => {