Fix after review: implement deprecation warning for old scrollTo API

Author: aleksei-semikozov

packages/devextreme/js/__internal/scheduler/__tests__/scheduler.test.ts

@@ -0,0 +1,37 @@
+import {
+  describe, expect, it, jest,
+} from '@jest/globals';
+import { logger } from '@ts/core/utils/m_console';
+
+import { createScheduler } from './__mock__/create_scheduler';
+import { setupSchedulerTestEnvironment } from './__mock__/m_mock_scheduler';
+
+describe('Scheduler scrollTo deprecation', () => {
+  it('should log deprecation warning when using old scrollTo API', async () => {
+    setupSchedulerTestEnvironment();
+    const loggerWarnSpy = jest.spyOn(logger, 'warn');
+
+    const { scheduler } = await createScheduler({
+      dataSource: [{
+        text: 'Meeting',
+        startDate: new Date(2025, 0, 15, 9, 0),
+        endDate: new Date(2025, 0, 15, 10, 0),
+      }],
+      views: ['week'],
+      currentView: 'week',
+      currentDate: new Date(2025, 0, 15),
+      startDayHour: 8,
+      endDayHour: 18,
+    });
+    loggerWarnSpy.mockReset();
+
+    const testDate = new Date(2025, 0, 16, 14, 0);
+
+    scheduler.scrollTo(testDate, undefined, false);
+
+    expect(loggerWarnSpy).toHaveBeenCalledTimes(1);
+    expect(loggerWarnSpy).toHaveBeenCalledWith(
+      expect.stringContaining('W0002'),
+    );
+  });
+});

packages/devextreme/js/__internal/scheduler/m_scheduler.ts

@@ -64,7 +64,7 @@ import { MobileTooltipStrategy } from './tooltip_strategies/m_mobile_tooltip_str
 import type {
   AppointmentTooltipItem,
   SafeAppointment,
-  TargetedAppointment,
+  ScrollToGroupValuesOrOptions, ScrollToOptions, TargetedAppointment,
 } from './types';
 import { AppointmentAdapter } from './utils/appointment_adapter/appointment_adapter';
 import { AppointmentDataAccessor } from './utils/data_accessor/appointment_data_accessor';
@@ -77,7 +77,6 @@ import type { NormalizedView } from './utils/options/types';
 import { setAppointmentGroupValues } from './utils/resource_manager/appointment_groups_utils';
 import { createResourceEditorModel } from './utils/resource_manager/popup_utils';
 import { ResourceManager } from './utils/resource_manager/resource_manager';
-import type { GroupValues, RawGroupValues } from './utils/resource_manager/types';
 import AppointmentLayoutManager from './view_model/appointments_layout_manager';
 import { AppointmentDataSource } from './view_model/m_appointment_data_source';
 import type { AppointmentViewModelPlain } from './view_model/types';
@@ -91,14 +90,6 @@ import SchedulerWorkSpaceMonth from './workspaces/m_work_space_month';
 import SchedulerWorkSpaceWeek from './workspaces/m_work_space_week';
 import SchedulerWorkSpaceWorkWeek from './workspaces/m_work_space_work_week';
 
-interface ScrollToOptions {
-  group?: RawGroupValues | GroupValues;
-  allDay?: boolean | undefined;
-  align?: 'start' | 'center';
-}
-
-type ScrollToGroupValuesOrOptions = RawGroupValues | GroupValues | ScrollToOptions | undefined;
-
 const toMs = dateUtils.dateToMilliseconds;
 
 const WIDGET_CLASS = 'dx-scheduler';
@@ -2045,6 +2036,7 @@ class Scheduler extends SchedulerOptionsBaseWidget {
       allDayValue = groupValuesOrOptions.allDay;
       align = groupValuesOrOptions.align ?? 'center';
     } else {
+      errors.log('W0002', 'dxScheduler', 'scrollTo', '26.1', 'Use an object with "group", "allDay", and "align" properties instead of separate parameters.');
       groupValues = groupValuesOrOptions;
       allDayValue = allDay;
     }

packages/devextreme/js/__internal/scheduler/types.ts

@@ -2,6 +2,7 @@ import type { dxElementWrapper } from '@js/core/renderer';
 import type { Appointment, Properties } from '@js/ui/scheduler';
 
 import type { ResourceLoader } from './utils/loader/resource_loader';
+import type { GroupValues, RawGroupValues } from './utils/resource_manager/types';
 import type { AppointmentViewModelPlain } from './view_model/types';
 
 export type Direction = 'vertical' | 'horizontal';
@@ -269,3 +270,15 @@ export interface CompactAppointmentOptions {
   allowDrag: boolean;
   isCompact: boolean;
 }
+
+export interface ScrollToOptions {
+  group?: RawGroupValues | GroupValues;
+  allDay?: boolean | undefined;
+  align?: 'start' | 'center';
+}
+
+export type ScrollToGroupValuesOrOptions =
+  | RawGroupValues
+  | GroupValues
+  | ScrollToOptions
+  | undefined;