Skip to content

Commit 8324c58

Browse files
authored
DataGrid - Contrast between icons in the Filter Row menu and their background doesn't comply with WCAG accessibility standards (T1257970) (#28522)
1 parent e28d129 commit 8324c58

File tree

13 files changed

+65
-17
lines changed

13 files changed

+65
-17
lines changed
110 Bytes
Loading
243 Bytes
Loading
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
2+
import DataGrid from 'devextreme-testcafe-models/dataGrid';
3+
import FilterTextBox from 'devextreme-testcafe-models/dataGrid/editors/filterTextBox';
4+
import url from '../../../helpers/getPageUrl';
5+
import { createWidget } from '../../../helpers/createWidget';
6+
import { getData } from '../helpers/generateDataSourceData';
7+
import { Themes } from '../../../helpers/themes';
8+
import { changeTheme } from '../../../helpers/changeTheme';
9+
10+
fixture.disablePageReloads`DataGrid - contrast`
11+
.page(url(__dirname, '../../container.html'));
12+
13+
// T1257970
14+
[
15+
Themes.genericLight,
16+
Themes.fluentBlue,
17+
Themes.materialBlue,
18+
].forEach((theme) => {
19+
test('DataGrid - Contrast between icons in the Filter Row menu and their background doesn\'t comply with WCAG accessibility standards', async (t) => {
20+
const dataGrid = new DataGrid('#container');
21+
const filterEditor = dataGrid.getFilterEditor(0, FilterTextBox);
22+
const searchButton = filterEditor.menuButton;
23+
const filterMenu = filterEditor.menu;
24+
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
25+
26+
await t
27+
.expect(dataGrid.isReady())
28+
.ok();
29+
await t
30+
.click(searchButton)
31+
.expect(filterMenu.element.exists)
32+
.ok();
33+
await t
34+
.expect(await takeScreenshot(`T1257970-datagrid-menu-icon-contrast-${theme}.png`, dataGrid.element))
35+
.ok()
36+
.expect(compareResults.isValid())
37+
.ok(compareResults.errorMessages());
38+
}).before(
39+
async () => {
40+
await changeTheme(theme);
41+
await createWidget('dxDataGrid', {
42+
dataSource: getData(5, 5),
43+
filterRow: {
44+
visible: true,
45+
},
46+
});
47+
},
48+
).after(
49+
async () => {
50+
if (theme === Themes.genericLight) {
51+
return;
52+
}
53+
await changeTheme(Themes.genericLight);
54+
},
55+
);
56+
});
39.7 KB
Loading
33.7 KB
Loading
35.8 KB
Loading
241 Bytes
Loading
275 Bytes
Loading
714 Bytes
Loading

packages/devextreme-scss/scss/widgets/fluent/menu/_colors.scss

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,9 @@ $menu-item-link-color: $base-link-color !default;
2727
$menu-item-focused-selected-bg: null !default;
2828

2929
@if $mode == "light" {
30-
$menu-item-focused-selected-bg: darken($base-bg, 9.8) !default;
30+
$menu-item-focused-selected-bg: darken($base-bg, 9.8) !default;
3131
}
32-
32+
3333
@if $mode == "dark" {
34-
$menu-item-focused-selected-bg: lighten($base-bg, 18.04) !default;
34+
$menu-item-focused-selected-bg: lighten($base-bg, 18.04) !default;
3535
}
36-

0 commit comments

Comments
 (0)