Skip to content

Commit 84e062b

Browse files
r-farkhutdinovRuslan Farkhutdinov
andauthored
Revert "DropDownEditor: remove overflow:hidden for overlay content (T1312677) (#31751)
Co-authored-by: Ruslan Farkhutdinov <[email protected]>
1 parent 0276ab6 commit 84e062b

File tree

4 files changed

+2
-34
lines changed

4 files changed

+2
-34
lines changed

e2e/testcafe-devextreme/tests/editors/dateBox/dateBox.ts

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
22
import DateBox from 'devextreme-testcafe-models/dateBox';
3-
import { Selector } from 'testcafe';
43
import url from '../../../helpers/getPageUrl';
54
import asyncForEach from '../../../helpers/asyncForEach';
65
import { createWidget } from '../../../helpers/createWidget';
@@ -11,9 +10,6 @@ fixture.disablePageReloads`DateBox`
1110

1211
const ITEM_HEIGHT = 40;
1312

14-
const TIME_VIEW_FIELD_CLASS = 'dx-timeview-field';
15-
const SELECT_BOX_CONTAINER_CLASS = 'dx-selectbox-container';
16-
1713
if (!isMaterialBased()) {
1814
[[11, 12, 1925], [10, 23, 2001]].forEach(([month, day, year]) => {
1915
test(`Rollers should be scrolled correctly when value is changed to ${day}/${month}/${year} using kbn and valueChangeEvent=keyup (T948310)`, async (t) => {
@@ -70,31 +66,3 @@ test('DateBox with datetime and root element as container (T1193495)', async (t)
7066
container: '#container',
7167
},
7268
}, '#container'));
73-
74-
test('DateBox with datetime and opened AM/PM select (T1312677)', async (t) => {
75-
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
76-
77-
const timeViewSelect = Selector(`#container .${TIME_VIEW_FIELD_CLASS} .${SELECT_BOX_CONTAINER_CLASS}`);
78-
79-
await t
80-
.click(timeViewSelect);
81-
82-
await testScreenshot(
83-
t,
84-
takeScreenshot,
85-
'DateBox with datetime and opened AMPM select.png',
86-
{ element: '#container' },
87-
);
88-
89-
await t
90-
.expect(compareResults.isValid())
91-
.ok(compareResults.errorMessages());
92-
}).before(async () => createWidget('dxDateBox', {
93-
value: new Date(2022, 10, 23, 17, 23),
94-
type: 'datetime',
95-
pickerType: 'calendar',
96-
opened: true,
97-
dropDownOptions: {
98-
container: '#container',
99-
},
100-
}, '#container'));

packages/devextreme-scss/scss/widgets/fluent/dropDownEditor/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ $fluent-dropdowneditor-invalid-badge-size: $fluent-invalid-badge-size + $fluent-
123123
&.dx-popup-wrapper {
124124
.dx-overlay-content {
125125
box-shadow: $fluent-base-dropdown-widgets-shadow;
126-
overflow: visible;
126+
overflow: hidden;
127127
}
128128
}
129129

packages/devextreme-scss/scss/widgets/material/dropDownEditor/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ $material-dropdowneditor-invalid-badge-size: $material-invalid-badge-size + $mat
123123
&.dx-popup-wrapper {
124124
.dx-overlay-content {
125125
box-shadow: $material-base-dropdown-widgets-shadow;
126-
overflow: visible;
126+
overflow: hidden;
127127
}
128128
}
129129

0 commit comments

Comments
 (0)