Skip to content

Commit 8a2f960

Browse files
r-farkhutdinovRuslan Farkhutdinov
andauthored
DropDownEditor: remove overflow:hidden for overlay content (T1312677) (#31737)
Co-authored-by: Ruslan Farkhutdinov <[email protected]>
1 parent 2098236 commit 8a2f960

File tree

4 files changed

+34
-2
lines changed

4 files changed

+34
-2
lines changed

e2e/testcafe-devextreme/tests/editors/dateBox/dateBox.ts

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
22
import DateBox from 'devextreme-testcafe-models/dateBox';
3+
import { Selector } from 'testcafe';
34
import url from '../../../helpers/getPageUrl';
45
import asyncForEach from '../../../helpers/asyncForEach';
56
import { createWidget } from '../../../helpers/createWidget';
@@ -10,6 +11,9 @@ fixture.disablePageReloads`DateBox`
1011

1112
const ITEM_HEIGHT = 40;
1213

14+
const TIME_VIEW_FIELD_CLASS = 'dx-timeview-field';
15+
const SELECT_BOX_CONTAINER_CLASS = 'dx-selectbox-container';
16+
1317
if (!isMaterialBased()) {
1418
[[11, 12, 1925], [10, 23, 2001]].forEach(([month, day, year]) => {
1519
test(`Rollers should be scrolled correctly when value is changed to ${day}/${month}/${year} using kbn and valueChangeEvent=keyup (T948310)`, async (t) => {
@@ -66,3 +70,31 @@ test('DateBox with datetime and root element as container (T1193495)', async (t)
6670
container: '#container',
6771
},
6872
}, '#container'));
73+
74+
test('DateBox with datetime and opened AM/PM select (T1312677)', async (t) => {
75+
const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
76+
77+
const timeViewSelect = Selector(`#container .${TIME_VIEW_FIELD_CLASS} .${SELECT_BOX_CONTAINER_CLASS}`);
78+
79+
await t
80+
.click(timeViewSelect);
81+
82+
await testScreenshot(
83+
t,
84+
takeScreenshot,
85+
'DateBox with datetime and opened AMPM select.png',
86+
{ element: '#container' },
87+
);
88+
89+
await t
90+
.expect(compareResults.isValid())
91+
.ok(compareResults.errorMessages());
92+
}).before(async () => createWidget('dxDateBox', {
93+
value: new Date(2022, 10, 23, 17, 23),
94+
type: 'datetime',
95+
pickerType: 'calendar',
96+
opened: true,
97+
dropDownOptions: {
98+
container: '#container',
99+
},
100+
}, '#container'));
41.9 KB
Loading

packages/devextreme-scss/scss/widgets/fluent/dropDownEditor/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ $fluent-dropdowneditor-invalid-badge-size: $fluent-invalid-badge-size + $fluent-
123123
&.dx-popup-wrapper {
124124
.dx-overlay-content {
125125
box-shadow: $fluent-base-dropdown-widgets-shadow;
126-
overflow: hidden;
126+
overflow: visible;
127127
}
128128
}
129129

packages/devextreme-scss/scss/widgets/material/dropDownEditor/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ $material-dropdowneditor-invalid-badge-size: $material-invalid-badge-size + $mat
123123
&.dx-popup-wrapper {
124124
.dx-overlay-content {
125125
box-shadow: $material-base-dropdown-widgets-shadow;
126-
overflow: hidden;
126+
overflow: visible;
127127
}
128128
}
129129

0 commit comments

Comments
 (0)