DataGrid: Don't calculate additional filter when filtering column list is empty (T1311818) (#31849) (#31859)

Author: dmirgaev

…case-sensitive-1 (fluent.blue.light).png …case-sensitive-1 (fluent.blue.light).pnge2e/testcafe-devextreme/tests/dataGrid/common/etalons/filter-method-with-case-sensitive-1 (fluent.blue.light).png renamed to e2e/testcafe-devextreme/tests/dataGrid/common/filtering/etalons/filter-method-with-case-sensitive-1 (fluent.blue.light).png e2e/testcafe-devextreme/tests/dataGrid/common/etalons/filter-method-with-case-sensitive-1 (fluent.blue.light).png renamed to e2e/testcafe-devextreme/tests/dataGrid/common/filtering/etalons/filter-method-with-case-sensitive-1 (fluent.blue.light).png

@@ -0,0 +1,48 @@
+import DataGrid from 'devextreme-testcafe-models/dataGrid';
+import url from '../../../../helpers/getPageUrl';
+import { createWidget } from '../../../../helpers/createWidget';
+
+fixture.disablePageReloads`Filtering`
+  .page(url(__dirname, '../../../container.html'));
+
+const GRID_CONTAINER = '#container';
+
+// T1311818
+test('Don\'t calculate additional filter when filtering column list is empty', async (t) => {
+  // arrange
+  const dataGrid = new DataGrid(GRID_CONTAINER);
+  const consoleMessages = await t.getBrowserConsoleMessages();
+
+  // act
+  await dataGrid.option({
+    columns: [
+      { dataField: 'id', caption: 'ID', dataType: 'number' },
+      { dataField: 'name', caption: 'Name', dataType: 'string' },
+    ],
+    dataSource: [
+      { id: 1, name: 'Item 1' },
+      { id: 2, name: 'Item 2' },
+      { id: 3, name: 'Item 3' },
+    ],
+  });
+
+  // assert
+  await t.expect(dataGrid.isReady()).ok();
+
+  // act
+  await dataGrid.option({
+    columns: [],
+    dataSource: undefined,
+  });
+
+  // assert
+  await t
+    .expect(consoleMessages.error.every((msg) => !msg.includes('E1047')))
+    .ok();
+}).before(async () => createWidget('dxDataGrid', {
+  keyExpr: 'id',
+  filterValue: ['id', '>=', 1],
+  dataSource: null,
+  columns: [],
+  showBorders: true,
+}));

…case-sensitive-2 (fluent.blue.light).png …case-sensitive-2 (fluent.blue.light).pnge2e/testcafe-devextreme/tests/dataGrid/common/etalons/filter-method-with-case-sensitive-2 (fluent.blue.light).png renamed to e2e/testcafe-devextreme/tests/dataGrid/common/filtering/etalons/filter-method-with-case-sensitive-2 (fluent.blue.light).png e2e/testcafe-devextreme/tests/dataGrid/common/etalons/filter-method-with-case-sensitive-2 (fluent.blue.light).png renamed to e2e/testcafe-devextreme/tests/dataGrid/common/filtering/etalons/filter-method-with-case-sensitive-2 (fluent.blue.light).png

@@ -1,15 +1,15 @@
 import { createScreenshotsComparer } from 'devextreme-screenshot-comparer';
 import DataGrid from 'devextreme-testcafe-models/dataGrid';
-import url from '../../../helpers/getPageUrl';
-import { createWidget } from '../../../helpers/createWidget';
-import { testScreenshot } from '../../../helpers/themeUtils';
+import url from '../../../../helpers/getPageUrl';
+import { createWidget } from '../../../../helpers/createWidget';
+import { testScreenshot } from '../../../../helpers/themeUtils';
 
 fixture.disablePageReloads`Filtering`
-  .page(url(__dirname, '../../container.html'));
+  .page(url(__dirname, '../../../container.html'));
 
 const GRID_CONTAINER = '#container';
 
-test('Data should be filtered if True is selected via the filter method when case sensitive is enabled', async (t) => {
+test('Data should be filtered if True is selected via the filter method when case sensitivity is enabled', async (t) => {
   // arrange
   const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
   const dataGrid = new DataGrid(GRID_CONTAINER);
@@ -50,7 +50,7 @@ test('Data should be filtered if True is selected via the filter method when cas
   showBorders: true,
 }));
 
-test('Data should be filtered if True is selected via the option method when case sensitive is enabled', async (t) => {
+test('Data should be filtered if True is selected via the option method when case sensitivity is enabled', async (t) => {
   // arrange
   const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
   const dataGrid = new DataGrid(GRID_CONTAINER);

…case-sensitive-1 (fluent.blue.light).png …case-sensitive-1 (fluent.blue.light).pnge2e/testcafe-devextreme/tests/dataGrid/common/etalons/filtering-via-option-method-with-case-sensitive-1 (fluent.blue.light).png renamed to e2e/testcafe-devextreme/tests/dataGrid/common/filtering/etalons/filtering-via-option-method-with-case-sensitive-1 (fluent.blue.light).png e2e/testcafe-devextreme/tests/dataGrid/common/etalons/filtering-via-option-method-with-case-sensitive-1 (fluent.blue.light).png renamed to e2e/testcafe-devextreme/tests/dataGrid/common/filtering/etalons/filtering-via-option-method-with-case-sensitive-1 (fluent.blue.light).png

@@ -299,12 +299,13 @@ const data = (Base: ModuleType<DataController>) => class DataControllerFilterSyn
   }
 
   protected _calculateAdditionalFilter() {
-    if (this.option('filterPanel.filterEnabled') === false) {
+    const columns = this._columnsController.getFilteringColumns();
+
+    if (!columns?.length || this.option('filterPanel.filterEnabled') === false) {
       return super._calculateAdditionalFilter();
     }
 
     const filters = [super._calculateAdditionalFilter()];
-    const columns = this._columnsController.getFilteringColumns();
     let filterValue = this.option('filterValue');
 
     if (this.isFilterSyncActive()) {