TreeList - The W1025 warning occurs when dragging a row even if the component's height is specified. (T1280519) (#29404)

Author: tongsonbarbs

e2e/testcafe-devextreme/tests/treeList/rowDragging.ts

@@ -59,3 +59,27 @@ test('TreeList - Expand/collapse mechanism breaks after dragging action in the s
     },
   });
 });
+
+[undefined, 200].forEach((height) => {
+  test(`TreeList - The W1025 warning occurs when dragging a row (height: ${height ?? 'not set'}). (T1280519)`, async (t) => {
+    const treeList = new TreeList('#container');
+
+    await treeList.isReady();
+
+    await treeList.moveRow(0, 10, 10, true);
+
+    const consoleMessages = await t.getBrowserConsoleMessages();
+    const warningExists = !!consoleMessages?.warn.find((message) => message.startsWith('W1025'));
+
+    await t.expect(warningExists).eql(height === undefined);
+  }).before(async () => createWidget('dxDataGrid', {
+    height,
+    scrolling: {
+      mode: 'virtual',
+    },
+    dataSource: tasksT1228650,
+    rowDragging: {
+      allowReordering: true,
+    },
+  }));
+});

packages/devextreme/js/__internal/grids/grid_core/row_dragging/m_row_dragging.ts

@@ -105,7 +105,6 @@ const rowsView = (Base: ModuleType<RowsView>) => class RowsViewRowDraggingExtend
         onDragStart: (e) => {
           // TODO getController
           this.getController('keyboardNavigation')?._resetFocusedCell();
-
           const row = e.component.getVisibleRows()[e.fromIndex];
           e.itemData = row && row.data;
 
@@ -212,6 +211,7 @@ const rowsView = (Base: ModuleType<RowsView>) => class RowsViewRowDraggingExtend
         fixed: column.fixed,
         fixedPosition: column.fixedPosition,
       })),
+      isDragging: true,
       onRowPrepared: (e) => {
         const rowsView = e.component.getView('rowsView');
         $(e.rowElement).replaceWith($rowElement.eq(rowsView._isFixedTableRendering ? 1 : 0).clone());

packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling.ts

@@ -1788,10 +1788,15 @@ export const rowsView = (Base: ModuleType<RowsView>) => class VirtualScrollingRo
     super.setLoading.call(this, isLoading, messageText);
   }
 
+  private isGridDragging() {
+    return this.component.option('isDragging');
+  }
+
   // NOTE: warning won't be thrown if height was specified and then removed,
   // because for some reason `_hasHeight` is not updated properly in this case
   private throwHeightWarningIfNeed() {
-    if (this._hasHeight === undefined) {
+    const isGridDragging = this.isGridDragging();
+    if (this._hasHeight === undefined || isGridDragging) {
       return;
     }
 

packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/rowDragging.tests.js

@@ -150,6 +150,7 @@ QUnit.module('Drag and Drop rows', moduleConfig, () => {
             pager: {
                 visible: true
             },
+            isDragging: true,
             scrolling: {
                 useNative: true,
                 showScrollbar: 'onScroll'
@@ -188,6 +189,7 @@ QUnit.module('Drag and Drop rows', moduleConfig, () => {
                     fixedPosition: 'right'
                 }
             ],
+            isDragging: true,
             columnAutoWidth: true,
             showColumnHeaders: false,
             showBorders: true,