Skip to content

Commit ac984e4

Browse files
Remove Bootstrap < 5 (less) entities (#28396)
1 parent 1d1cc2e commit ac984e4

File tree

4 files changed

+106
-222
lines changed

4 files changed

+106
-222
lines changed

packages/devextreme-themebuilder/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
"dependencies": {
2727
"autoprefixer": "^10.4.7",
2828
"clean-css": "^5.3.0",
29-
"less": "^3.13.1",
3029
"postcss": "^8.2.6",
3130
"sass-embedded": "1.66.0"
3231
},
@@ -35,7 +34,6 @@
3534
"@types/dependency-tree": "7.2.0",
3635
"@types/filing-cabinet": "2.5.3",
3736
"@types/fs-extra": "11.0.4",
38-
"@types/less": "3.0.6",
3937
"@types/node": "20.11.17",
4038
"eslint": "8.56.0",
4139
"eslint-config-airbnb-base": "15.0.0",

packages/devextreme-themebuilder/src/modules/bootstrap-extractor.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import * as sass from 'sass-embedded';
2-
import less from 'less';
32
import { promises as fs, existsSync } from 'fs';
43
import bootstrap5meta from '../data/bootstrap-metadata/bootstrap5-metadata';
54

@@ -50,15 +49,6 @@ export default class BootstrapExtractor {
5049
});
5150
}
5251

53-
static async lessRender(input: string): Promise<string> {
54-
return new Promise((resolve, reject) => {
55-
less.render(
56-
input,
57-
(error, result) => (error ? reject(error.message) : resolve(result.css)),
58-
);
59-
});
60-
}
61-
6252
static convertRemToPx(cssValue: string): string {
6353
const remValueRegex = /(\d*?\.?\d+?)rem([;\s])?/g;
6454
const replaceHandler = (_match: string, value: string, separator: string): string => {
@@ -96,14 +86,6 @@ ${this.getCollectorServiceCode()}`;
9686
return result;
9787
}
9888

99-
async lessProcessor(): Promise<string> {
100-
return Promise.resolve(
101-
this.getSetterServiceCode()
102-
+ this.input
103-
+ this.getCollectorServiceCode(),
104-
);
105-
}
106-
10789
getVariables(variables: string): string {
10890
return variables.replace(/^@import "variables-dark";.*$/gm, '');
10991
}

packages/devextreme-themebuilder/tests/modules/bootstrap-extractor.test.ts

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,6 @@ describe('BootstrapExtractor', () => {
2323
.rejects
2424
.toMatch(/^Error: expected "{"\./));
2525

26-
test('lessRender', async () => {
27-
const less = '@var: red; div { color: @var;}';
28-
const css = 'div {\n color: red;\n}\n';
29-
30-
return expect(await BootstrapExtractor.lessRender(less)).toBe(css);
31-
});
32-
33-
test('lessRender (error)', async () => expect(BootstrapExtractor.lessRender('0'))
34-
.rejects
35-
.toBe('Unrecognised input. Possibly missing something'));
36-
3726
test('sassProcessor (bootstrap5)', async () => {
3827
const testSassString = 'test string';
3928
const setterServiceCode = 'setter';
@@ -57,20 +46,6 @@ ${setterServiceCode}
5746
${collectorServiceCode}`);
5847
});
5948

60-
test('lessProcessor', async () => {
61-
const testLessString = 'test string';
62-
const setterServiceCode = 'setter';
63-
const collectorServiceCode = 'collector';
64-
const extractor = new BootstrapExtractor(testLessString, 3);
65-
extractor.getSetterServiceCode = (): string => setterServiceCode;
66-
extractor.getCollectorServiceCode = (): string => collectorServiceCode;
67-
68-
expect(await extractor.lessProcessor())
69-
.toBe(setterServiceCode
70-
+ testLessString
71-
+ collectorServiceCode);
72-
});
73-
7449
test('getSetterServiceCode', () => {
7550
const extractor = new BootstrapExtractor('', 4);
7651
extractor.meta = {

0 commit comments

Comments
 (0)