Skip to content

Commit b579f7e

Browse files
GHPages - move ignored to metadata (#29418)
1 parent c0ebbe0 commit b579f7e

File tree

4 files changed

+34
-41
lines changed

4 files changed

+34
-41
lines changed

apps/demos/menuMeta.json

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
],
7272
"MvcDocUrl": "https://docs.devexpress.com/DevExtremeAspNetMvc/400704/concepts/data-binding",
7373
"NetCoreDocUrl": "https://docs.devexpress.com/AspNetCore/400575/concepts/devextreme-based-controls/data-binding",
74+
"NoPreloaded": "Max callstack exceeded",
7475
"DemoType": "Web"
7576
},
7677
{
@@ -89,6 +90,7 @@
8990
"Stock.cs",
9091
"StockTicker.cs"
9192
],
93+
"NoPreloaded": "uses DevExtreme which is not defined",
9294
"DemoType": "Web"
9395
},
9496
{
@@ -134,6 +136,7 @@
134136
"MvcAdditionalFiles": [
135137
"/Models/DataService/Sale.cs"
136138
],
139+
"NoPreloaded": "Max callstack exceeded",
137140
"DemoType": "Web"
138141
},
139142
{
@@ -243,6 +246,7 @@
243246
"/Models/SampleData/CustomEditorsTasks.cs",
244247
"/Scripts/data/statuses.js"
245248
],
249+
"NoPreloaded": "Max callstack exceeded",
246250
"DemoType": "Web"
247251
},
248252
{
@@ -258,6 +262,7 @@
258262
],
259263
"MvcDocUrl": "https://docs.devexpress.com/DevExtremeAspNetMvc/400705/concepts/client-side-data-validation#overview",
260264
"NetCoreDocUrl": "https://docs.devexpress.com/AspNetCore/400576/concepts/devextreme-based-controls/client-side-data-validation#overview",
265+
"NoPreloaded": "Max callstack exceeded",
261266
"DemoType": "Web",
262267
"Modules": "devextreme-aspnet-data-nojquery"
263268
},
@@ -284,6 +289,7 @@
284289
"Title": "Collaborative Editing",
285290
"Name": "CollaborativeEditing",
286291
"Widget": "DataGrid",
292+
"NoPreloaded": "Max callstack exceeded",
287293
"DemoType": "Web",
288294
"Equivalents": "signalr, real time, live update",
289295
"Modules": "devextreme-aspnet-data-nojquery,signalr",
@@ -336,6 +342,7 @@
336342
"Name": "BatchUpdateRequest",
337343
"DocUrl": "",
338344
"Widget": "DataGrid",
345+
"NoPreloaded": "Max callstack exceeded",
339346
"DemoType": "Web",
340347
"Equivalents": "",
341348
"Modules": "whatwg-fetch,devextreme-aspnet-data-nojquery",
@@ -354,6 +361,7 @@
354361
"Name": "EditStateManagement",
355362
"DocUrl": "",
356363
"Widget": "DataGrid",
364+
"NoPreloaded": "Max callstack exceeded",
357365
"DemoType": "Web",
358366
"Equivalents": "",
359367
"Modules": "whatwg-fetch,vuex",
@@ -371,6 +379,7 @@
371379
"NetCoreDescription": "",
372380
"MvcAdditionalFiles": [],
373381
"Modules": "devextreme-aspnet-data-nojquery",
382+
"NoPreloaded": "Max callstack exceeded",
374383
"DemoType": "Web"
375384
}
376385
]
@@ -397,6 +406,7 @@
397406
"MvcAdditionalFiles": [
398407
"/Models/DataService/Sale.cs"
399408
],
409+
"NoPreloaded": "Max callstack exceeded",
400410
"DemoType": "Web",
401411
"Modules": "devextreme-aspnet-data-nojquery"
402412
}
@@ -433,6 +443,7 @@
433443
"Title": "Filtering API",
434444
"Name": "FilteringAPI",
435445
"Widget": "DataGrid",
446+
"NoPreloaded": "Vue doesnt work",
436447
"DemoType": "Web"
437448
},
438449
{
@@ -491,6 +502,7 @@
491502
"Title": "Remote Reordering",
492503
"Name": "RemoteReordering",
493504
"Widget": "DataGrid",
505+
"NoPreloaded": "Max callstack exceeded",
494506
"DemoType": "Web",
495507
"Modules": "devextreme-aspnet-data-nojquery",
496508
"MvcAdditionalFiles": [
@@ -586,6 +598,7 @@
586598
"MvcAdditionalFiles": [
587599
"/Models/SampleData/CountriesPopulationAndGDP.cs"
588600
],
601+
"NoPreloaded": "Vue doesnt work",
589602
"DemoType": "Web"
590603
},
591604
{
@@ -681,6 +694,7 @@
681694
"/Models/EuropeanCountry.cs",
682695
"/Models/SampleData/EuropeanCountries.cs"
683696
],
697+
"NoPreloaded": "Vue doesnt work",
684698
"DemoType": "Web"
685699
}
686700
]
@@ -708,6 +722,7 @@
708722
"/Models/DataGrid/Employee.cs",
709723
"/Models/SampleData/DataGridEmployees.cs"
710724
],
725+
"NoPreloaded": "localization package",
711726
"DemoType": "Web"
712727
},
713728
{
@@ -734,6 +749,7 @@
734749
"/Models/Intraday.cs",
735750
"/Models/SampleData/IntradayData.cs"
736751
],
752+
"NoPreloaded": "localization package",
737753
"DemoType": "Web"
738754
},
739755
{
@@ -833,6 +849,7 @@
833849
"MvcAdditionalFiles": [
834850
"/Controllers/ApiControllers/DataGridAdvancedMasterDetailViewController.cs"
835851
],
852+
"NoPreloaded": "Max callstack exceeded",
836853
"DemoType": "Web"
837854
}
838855
]

apps/demos/utils/create-bundles/helper/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ import { createHash } from 'crypto';
99
import { version as DX_Version } from 'devextreme/package.json';
1010
import { Demo, Framework } from './types';
1111
import { resourceLinks } from './external-resource-metadata';
12+
import gitHubIgnored from '../../visual-tests/github-ignored-list'
1213

1314
export const isSkipDemo = (demo: Demo) => {
1415
const { Widget, Name } = demo;
15-
const excluded = ['Localization', 'RowTemplate', 'CellCustomization', 'TimeZonesSupport', 'ExportToPDF'];
16-
const shouldSkip = excluded.includes(Widget) || excluded.includes(Name);
16+
const shouldSkip = gitHubIgnored.includes(Widget) || gitHubIgnored.includes(Name);
1717

1818
return shouldSkip;
1919
};
Lines changed: 14 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,14 @@
1-
/* eslint-disable spellcheck/spell-checker */
2-
// ignored because they have import of localization package and fail during bundling
3-
// 2 for Grid (RowTemplate, CellCustomization)
4-
const ignoredLocalization = ['Localization', 'RowTemplate', 'CellCustomization', 'TimeZonesSupport', 'ExportToPDF'];
5-
// ignored becuse react and vue fail to max callstack exceeded
6-
7-
const ignoredCallstack = [
8-
'AdvancedMasterDetailView',
9-
'BatchUpdateRequest',
10-
'CollaborativeEditing',
11-
'CustomEditors',
12-
'CustomNewRecordPosition',
13-
'DataValidation',
14-
'EditStateManagement', // fail only in vue
15-
'RemoteGrouping',
16-
'RemoteReordering',
17-
'RemoteVirtualScrolling',
18-
'WebAPIService',
19-
];
20-
21-
// ignored, because test uses DevExtreme which is not defined
22-
// (probably something with path on CI, need to research)
23-
const ignoredDevextreme = ['SignalRService'];
24-
25-
// ignored vue some problems with template + 1 miss style
26-
const ignoredVue = [
27-
'FilteringAPI',
28-
'MultiRowHeadersBands',
29-
'RightToLeftSupport',
30-
'EditStateManagement',
31-
];
32-
33-
export const gitHubIgnored = [
34-
...ignoredLocalization,
35-
...ignoredCallstack,
36-
...ignoredDevextreme,
37-
...ignoredVue,
38-
];
1+
import menuMeta from '../../menuMeta.json';
2+
3+
const gridMeta = menuMeta[0].Groups;
4+
5+
export const gitHubIgnored = gridMeta.reduce((result, Group) => {
6+
if (Group.Demos) {
7+
Group.Demos.forEach(demo => {
8+
if (!!demo.NoPreloaded) {
9+
result.push(demo.Name);
10+
}
11+
});
12+
}
13+
return result
14+
}, []).sort()

apps/demos/utils/visual-tests/matrix-test-helper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ export function runManualTestCore(
428428
let testURL = '';
429429

430430
if (isGitHubDemos) {
431-
if (widget !== 'DataGrid' || gitHubIgnored.includes(demo)) {
431+
if (widget !== 'DataGrid' || demo.NoPreloaded) {
432432
return;
433433
}
434434

0 commit comments

Comments
 (0)