Skip to content

Commit bf7f61f

Browse files
authored
Collection, TreeView, FileManager: get rid of unused this._selectionChangePromise (#28862)
Signed-off-by: Anton Kuznetsov <[email protected]>
1 parent faf7b43 commit bf7f61f

File tree

3 files changed

+8
-17
lines changed

3 files changed

+8
-17
lines changed

packages/devextreme/js/__internal/ui/collection/m_collection_widget.edit.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -545,8 +545,6 @@ class CollectionWidget<
545545
const { addedItemKeys, removedItemKeys } = args;
546546

547547
if (this._rendered && (addedItemKeys.length || removedItemKeys.length)) {
548-
// @ts-expect-error ts-error
549-
const selectionChangePromise = this._selectionChangePromise;
550548
if (!this._rendering) {
551549
const addedSelection = [];
552550
const removedSelection = [];
@@ -574,12 +572,9 @@ class CollectionWidget<
574572
this._updateSelection(addedSelection, removedSelection);
575573
}
576574

577-
// eslint-disable-next-line @typescript-eslint/no-floating-promises
578-
when(selectionChangePromise).done(() => {
579-
this._actions.onSelectionChanged({
580-
addedItems: args.addedItems,
581-
removedItems: args.removedItems,
582-
});
575+
this._actions.onSelectionChanged({
576+
addedItems: args.addedItems,
577+
removedItems: args.removedItems,
583578
});
584579
}
585580
}

packages/devextreme/js/__internal/ui/tree_view/m_tree_view.base.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,9 @@ const TreeViewBase = (HierarchicalCollectionWidget as any).inherit({
214214
_syncSelectionOptions: asyncNoop,
215215

216216
_fireSelectionChanged() {
217-
const selectionChangePromise = this._selectionChangePromise;
218-
when(selectionChangePromise).done(() => {
219-
this._createActionByOption('onSelectionChanged', {
220-
excludeValidators: ['disabled', 'readOnly'],
221-
})();
222-
});
217+
this._createActionByOption('onSelectionChanged', {
218+
excludeValidators: ['disabled', 'readOnly'],
219+
})();
223220
},
224221

225222
_createSelectAllValueChangedAction() {

packages/devextreme/js/ui/file_manager/ui.file_manager.items_list.thumbnails.list_box.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { getOuterWidth, getOuterHeight, getInnerWidth, getInnerHeight } from '..
22
import $ from '../../core/renderer';
33
import { extend } from '../../core/utils/extend';
44
import { isDefined } from '../../core/utils/type';
5-
import { Deferred, when } from '../../core/utils/deferred';
5+
import { Deferred } from '../../core/utils/deferred';
66

77
import holdEvent from '../../common/core/events/hold';
88
import { addNamespace, isCommandKeyPressed } from '../../common/core/events/utils/index';
@@ -284,7 +284,6 @@ class FileManagerThumbnailListBox extends CollectionWidget {
284284
const removedItemKeys = args.removedItemKeys;
285285

286286
if(this._rendered && (addedItemKeys.length || removedItemKeys.length)) {
287-
const selectionChangePromise = this._selectionChangePromise;
288287
if(!this._rendering) {
289288
const addedSelection = [];
290289
let normalizedIndex;
@@ -309,7 +308,7 @@ class FileManagerThumbnailListBox extends CollectionWidget {
309308
this._updateSelection(addedSelection, removedSelection);
310309
}
311310

312-
when(selectionChangePromise).done(() => this._fireSelectionChangeEvent(args));
311+
this._fireSelectionChangeEvent(args);
313312
}
314313
}
315314

0 commit comments

Comments
 (0)