Skip to content

Commit dfeb0f5

Browse files
committed
apply copilot's review
1 parent 325edf8 commit dfeb0f5

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

apps/demos/Demos/Scheduler/Templates/Angular/app/app.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export class AppComponent {
109109
};
110110

111111
updateEndDate = (movie: MovieData): void => {
112-
const form = this.formInstance!;
112+
const form = this.formInstance;
113113
const formData = form.option('formData');
114114
const { startDate } = formData;
115115

@@ -139,11 +139,12 @@ export class AppComponent {
139139
};
140140

141141
onMovieValueChanged = (e: DxSelectBoxTypes.ValueChangedEvent): void => {
142+
const form = this.formInstance!;
142143
const movie = this.getMovieById(e.value);
143144
this.currentSelectedMovie = movie;
144145

145146
if (movie) {
146-
this.formInstance.updateData('director', movie.director);
147+
form.updateData('director', movie.director);
147148
this.updateEndDate(movie);
148149
}
149150
};

apps/demos/Demos/Scheduler/Templates/React/App.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const currentDate = new Date(2025, 3, 27);
2424
const views: SchedulerTypes.ViewType[] = ['day', 'week', 'timelineDay'];
2525
const groups = ['theatreId'];
2626

27-
const getMovieById = (id: number | undefined): any => id
27+
const getMovieById = (id: number | undefined): MovieResource | null => id
2828
? query(moviesData).filter(['id', '=', id]).toArray()[0]
2929
: null;
3030

@@ -56,7 +56,7 @@ const App = () => {
5656
}), [onPopupOptionChanged]);
5757

5858
const updateEndDate = useCallback((movie: MovieResource): void => {
59-
const form = formInstanceRef.current;
59+
const form = formInstanceRef.current!;
6060
const formData = form.option('formData');
6161
const { startDate } = formData;
6262

@@ -67,7 +67,7 @@ const App = () => {
6767
}, []);
6868

6969
const onFormInitialized = useCallback((e: FormTypes.InitializedEvent) => {
70-
const form = e.component;
70+
const form = e.component!;
7171
formInstanceRef.current = form;
7272

7373
form.on('fieldDataChanged', (fieldEvent: FormTypes.FieldDataChangedEvent) => {
@@ -83,10 +83,11 @@ const App = () => {
8383
}, [updateEndDate]);
8484

8585
const onMovieValueChanged = useCallback((e: SelectBoxTypes.ValueChangedEvent) => {
86+
const form = formInstanceRef.current!;
8687
const movie = getMovieById(e.value);
8788

8889
if (movie) {
89-
formInstanceRef.current.updateData('director', movie.director);
90+
form.updateData('director', movie.director);
9091
updateEndDate(movie);
9192
}
9293
}, [updateEndDate]);

apps/demos/Demos/Scheduler/Templates/React/MovieInfoContainer.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,15 @@ type MovieInfoContainerProps = {
99
formInstanceRef: React.RefObject<dxForm | null>;
1010
};
1111

12-
const getMovieById = (id: number | undefined) => id ? query(moviesData).filter(['id', id]).toArray()[0] : null;
12+
const getMovieById = (id: number | undefined): MovieResource | null => id
13+
? query(moviesData).filter(['id', '=', id]).toArray()[0]
14+
: null;
1315

1416
const MovieInfoContainer: React.FC<MovieInfoContainerProps> = ({ formInstanceRef }) => {
1517
const [movie, setMovie] = useState<MovieResource | null>(null);
1618

1719
useEffect(() => {
18-
const form = formInstanceRef.current;
20+
const form = formInstanceRef.current!;
1921
const formData = form.option('formData');
2022

2123
const currentMovie = getMovieById(formData.movieId);

apps/demos/Demos/Scheduler/Templates/ReactJs/App.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,10 @@ const App = () => {
6767
);
6868
const onMovieValueChanged = useCallback(
6969
(e) => {
70+
const form = formInstanceRef.current;
7071
const movie = getMovieById(e.value);
7172
if (movie) {
72-
formInstanceRef.current.updateData('director', movie.director);
73+
form.updateData('director', movie.director);
7374
updateEndDate(movie);
7475
}
7576
},

apps/demos/Demos/Scheduler/Templates/ReactJs/MovieInfoContainer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React, { useState, useEffect } from 'react';
22
import { query } from 'devextreme-react/common/data';
33
import { moviesData } from './data.js';
44

5-
const getMovieById = (id) => (id ? query(moviesData).filter(['id', id]).toArray()[0] : null);
5+
const getMovieById = (id) => (id ? query(moviesData).filter(['id', '=', id]).toArray()[0] : null);
66
const MovieInfoContainer = ({ formInstanceRef }) => {
77
const [movie, setMovie] = useState(null);
88
useEffect(() => {

0 commit comments

Comments
 (0)