Merge branch '25_2' into 25_2_reduce_runners

Author: EugeniyKiyashko

.github/instructions/localization.instructions.md

@@ -0,0 +1,39 @@
+---
+applyTo: "**/localization/messages/**/*.json"
+---
+
+# CRITICAL: DO NOT REVIEW LOCALIZATION FILES
+
+These files are managed by a dedicated localization team through a separate workflow.
+
+## Absolute Prohibitions - You MUST NOT:
+
+- ❌ NEVER suggest translating English text to other languages
+- ❌ NEVER comment that text should be translated to match the locale
+- ❌ NEVER suggest alternative translations or phrasings in any language
+- ❌ NEVER comment on language consistency (e.g., "this should be in Arabic")
+- ❌ NEVER suggest changing text content for localization purposes
+- ❌ NEVER comment on which language should be used
+- ❌ NEVER suggest adding or removing message keys
+- ❌ NEVER provide language-specific style recommendations
+
+## Why These Files Are Off-Limits:
+
+Translation suggestions make PR pages UNRESPONSIVE and overwhelm human reviewers. The localization team handles all translation work through a separate quality assurance process.
+
+## The ONLY Acceptable Comments:
+
+✅ Critical JSON syntax errors that would break the build (missing commas, unclosed brackets)
+✅ Severe grammar errors (ONLY if they would cause user confusion)
+
+## Examples of FORBIDDEN Comments:
+
+- ❌ "This English text should be translated to Arabic"
+- ❌ "Translation is missing for this locale"
+- ❌ "Consider translating '(No subject)' to '(بدون موضوع)'"
+- ❌ "This text is in English but should be in German"
+- ❌ "Inconsistent language - use native translation"
+
+If you have ANY doubt about whether to comment on a localization file, DO NOT COMMENT.
+
+Focus your review on actual code files instead.

.github/workflows/testcafe_tests.yml

@@ -101,8 +101,8 @@ jobs:
           { componentFolder: "dataGrid/common", name: "dataGrid / common (1/3)", indices: "1/3" },
           { componentFolder: "dataGrid/common", name: "dataGrid / common (2/3)", indices: "2/3" },
           { componentFolder: "dataGrid/common", name: "dataGrid / common (3/3)", indices: "3/3" },
-          { componentFolder: "dataGrid/sticky/common", name: "dataGrid / sticky common" },
-          { componentFolder: "dataGrid/sticky/fixed", name: "dataGrid / sticky"},
+          { componentFolder: "dataGrid/sticky", name: "dataGrid / sticky (1/2)", indices: "1/2" },
+          { componentFolder: "dataGrid/sticky", name: "dataGrid / sticky (2/2)", indices: "2/2" },
           { componentFolder: "cardView", name: "cardView" },
 
           # Scheduler tests need to be reworked to work in fluent theme

apps/demos/Demos/Stepper/StepTemplate/Angular/app/app.component.css

@@ -67,6 +67,7 @@
   border-radius: 4px;
 }
 
-::ng-deep #iconOnly :is(.dx-step-selected, .dx-step-completed) .dx-icon {
-  color: var(--dx-color-primary);
+::ng-deep #iconOnly .dx-step-selected .dx-icon,
+::ng-deep #iconOnly .dx-step-completed .dx-icon {
+    color: var(--dx-color-primary);
 }

apps/demos/testing/widgets/vectormap/VectorMapZooming.test.ts

@@ -11,12 +11,12 @@ fixture('VectorMap.DynamicViewport')
 runManualTest('VectorMap', 'DynamicViewport', (test) => {
   test('VectorMap.DynamicViewport', async (t) => {
     const { takeScreenshot, compareResults } = createScreenshotsComparer(t);
-    const zoomButton = $($('#vector-map .dxm-control-bar g').nth(1)).find('circle').nth(0);
+    const zoomButton = $($('#vector-map .dxm-control-bar g').nth(1));
     const showSelectBoxItems = () => t.click($('.options .dx-dropdowneditor-input-wrapper input.dx-texteditor-input'));
     const selectItem = (index) => $('.dx-dropdowneditor-overlay .dx-list-item-content').nth(index);
 
-    await t.click(zoomButton);
-    await t.click(zoomButton);
+    await t.click(zoomButton, { offsetX: 10, offsetY: 10 });
+    await t.click(zoomButton, { offsetX: 10, offsetY: 10 });
     await testScreenshot(t, takeScreenshot, 'zoom_vector_map_by_control_bar.png');
 
     await showSelectBoxItems();

apps/demos/utils/visual-tests/matrix-test-helper.ts

@@ -225,8 +225,6 @@ const SKIPPED_TESTS = {
     DataGrid: ['EditStateManagement', 'Toolbar', 'RemoteGrouping'],
     Scheduler: ['ContextMenu'],
     FileUploader: ['CustomDropzone'],
-    // TODO: make this more stable
-    Stepper: ['StepTemplate'],
   },
   Vue: {
     Charts: ['Crosshair'],

apps/react-storybook/stories/chat/Chat.stories.tsx

@@ -790,3 +790,127 @@ export const Editing: Story = {
         );
     }
 };
+
+export const FileAttachments: Story = {
+  args: {
+    user: firstAuthor,
+    ...commonArgs,
+  },
+  argTypes: {
+    user: {
+      control: 'select',
+      options: [firstAuthor.name, secondAuthor.name],
+      mapping: {
+        [firstAuthor.name]: firstAuthor,
+        [secondAuthor.name]: secondAuthor,
+      },
+      defaultValue: firstAuthor.name,
+    },
+  },
+  render: ({
+    width,
+    height,
+    disabled,
+    rtlEnabled,
+    user,
+    visible,
+    activeStateEnabled,
+    hoverStateEnabled,
+    focusStateEnabled,
+  }) => {
+    const [messages, setMessages] = useState<ChatTypes.Message[]>([
+      {
+        id: 1,
+        author: firstAuthor,
+        text: 'Files attached in a very long message: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed vel tempus orci, sit amet tempor tortor. Etiam ut aliquam nisi.',
+        attachments: [
+          { name: 'report.pdf', size: 1024 * 512 },
+          { name: 'presentation.pptx', size: 1024 * 1024 },
+          { name: 'photo.jpg', size: 1024 * 300 },
+          { name: 'song.mp3', size: 1024 * 300 },
+        ],
+      },
+      {
+        id: 2,
+        author: secondAuthor,
+        text: 'Files, short message',
+        attachments: [
+          { name: 'report.pdf', size: 1024 * 512 },
+          { name: 'song.mp3', size: 1024 * 1024 },
+        ],
+      },
+    ]);
+
+    const [toastConfig, setToastConfig] = useState({
+      visible: false,
+      message: '',
+    });
+
+    const onAttachmentDownloadClick = useCallback((e: ChatTypes.AttachmentDownloadClickEvent) => {
+      const { attachment } = e;
+
+      setToastConfig({
+        visible: true,
+        message: `Downloading ${attachment?.name}...`,
+      });
+
+      setTimeout(() => {
+        setToastConfig({
+          visible: true,
+          message: `${attachment?.name} downloaded successfully`,
+        });
+      }, 1000);
+    }, []);
+
+    const onMessageEntered = useCallback(
+      ({ message }) => {
+        setMessages((prev) => [...prev, message]);
+      },
+      []
+    );
+
+    const onToastHiding = useCallback(() => {
+      setToastConfig({ visible: false, message: '' });
+    }, []);
+
+    const fileUploaderOptions = useMemo(() => ({
+        uploadFile: (file: File) => {
+          setToastConfig({
+            visible: true,
+            message: `Uploading ${file.name}...`,
+          });
+          setTimeout(() => {
+            setToastConfig({
+              visible: true,
+              message: `${file.name} uploaded successfully`,
+            });
+          }, 1000);
+        }
+    }), []);
+
+    return (
+      <div style={{ display: 'flex', justifyContent: 'center', alignItems: 'center' }}>
+        <Chat
+          width={width}
+          height={height}
+          items={messages}
+          disabled={disabled}
+          rtlEnabled={rtlEnabled}
+          user={user}
+          visible={visible}
+          activeStateEnabled={activeStateEnabled}
+          focusStateEnabled={focusStateEnabled}
+          hoverStateEnabled={hoverStateEnabled}
+          onAttachmentDownloadClick={onAttachmentDownloadClick}
+          onMessageEntered={onMessageEntered}
+          fileUploaderOptions={fileUploaderOptions}
+        />
+        <Toast
+          {...toastConfig}
+          onHiding={onToastHiding}
+          displayTime={1000}
+        />
+      </div>
+    );
+  },
+};

e2e/testcafe-devextreme/helpers/restoreBrowserSize.ts

@@ -103,7 +103,7 @@ function getArgs(): ParsedArgs {
       concurrency: 0,
       browsers: 'chrome',
       test: '',
-      reporter: [process.env.CI === 'true' ? 'list' : 'minimal'],
+      reporter: process.env.CI === 'true' ? 'list' : 'spec',
       componentFolder: '',
       file: '*',
       cache: true,

e2e/testcafe-devextreme/runner.ts

@@ -21,7 +21,7 @@ fixture.disablePageReloads`DataGrid - Editing`
       .click(dataGrid.getToolbar().getItem(0));
 
     await a11yCheck(t);
-  }).before(() => createWidget('dxDataGrid', {
+  }).before(async () => createWidget('dxDataGrid', {
     dataSource: getData(3, 2),
     height: 400,
     showBorders: true,

e2e/testcafe-devextreme/tests/accessibility/dataGrid/editing.ts

@@ -15,7 +15,7 @@ test('Infinite scrolling', async (t) => {
     .ok();
 
   await a11yCheck(t);
-}).before(() => createWidget('dxDataGrid', {
+}).before(async () => createWidget('dxDataGrid', {
   dataSource: getData(1000, 2),
   height: 400,
   showBorders: true,
@@ -32,7 +32,7 @@ test('Horizontal Virtual Scrolling', async (t) => {
     .ok();
 
   await a11yCheck(t);
-}).before(() => createWidget('dxDataGrid', {
+}).before(async () => createWidget('dxDataGrid', {
   dataSource: getData(20, 100),
   columnWidth: 100,
   height: 400,